Skip to content

Commit cd087e1

Browse files
AndrewLopezHerrerajamescr
authored andcommitted
feat: A border has been added to the rest of the popup-style menus.
fix: It resolves the low contrast that existed between the contextual menus and the rest of the application. docs: Nothing
1 parent c643479 commit cd087e1

3 files changed

Lines changed: 22 additions & 9 deletions

File tree

app/src/main/res/values-v14/theme_highcontrast.xml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
<!-- item name="android:background">#ffffff</item -->
55
<item name="android:buttonStyle">@style/Widget.Button</item>
66
<item name="android:buttonStyleToggle">@style/Widget.Button.Toggle</item>
7-
<item name="actionOverflowMenuStyle">@style/PopupMenu</item>
7+
<item name="android:actionOverflowMenuStyle">@style/NativePopupMenu</item>
8+
<item name="android:popupMenuStyle">@style/NativePopupMenu</item>
9+
<item name="android:panelBackground">@drawable/menu_border_background</item>
810
</style>
911

1012
<style name="Widget.Button" parent="@android:style/Widget.DeviceDefault.Button">
@@ -15,9 +17,5 @@
1517
<style name="Widget.Button.Toggle" parent="@android:style/Widget.DeviceDefault.Button.Toggle">
1618
<item name="android:textColor">#ffffff</item>
1719
</style>
18-
19-
<style name="PopupMenu" parent="Widget.AppCompat.PopupMenu.Overflow">
20-
<item name="android:popupBackground">@drawable/menu_border_background</item>
21-
</style>
2220

2321
</resources>
Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,21 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<resources>
3-
<style name="DefaultTheme" parent="@android:style/Theme.DeviceDefault"/>
4-
<style name="DarkTheme" parent="@android:style/Theme.DeviceDefault"/>
5-
<style name="LightTheme" parent="@android:style/Theme.DeviceDefault.Light"/>
3+
<style name="DefaultTheme" parent="@android:style/Theme.DeviceDefault">
4+
<item name="android:actionOverflowMenuStyle">@style/NativePopupMenu</item>
5+
<item name="android:popupMenuStyle">@style/NativePopupMenu</item>
6+
<item name="android:panelBackground">@drawable/menu_border_background</item>
7+
</style>
8+
<style name="DarkTheme" parent="@android:style/Theme.DeviceDefault">
9+
<item name="android:actionOverflowMenuStyle">@style/NativePopupMenu</item>
10+
<item name="android:popupMenuStyle">@style/NativePopupMenu</item>
11+
<item name="android:panelBackground">@drawable/menu_border_background</item>
12+
</style>
13+
<style name="LightTheme" parent="@android:style/Theme.DeviceDefault.Light">
14+
<item name="android:actionOverflowMenuStyle">@style/NativePopupMenu</item>
15+
<item name="android:popupMenuStyle">@style/NativePopupMenu</item>
16+
<item name="android:panelBackground">@drawable/menu_border_background</item>
17+
</style>
18+
<style name="NativePopupMenu" parent="">
19+
<item name="android:popupBackground">@drawable/menu_border_background</item>
20+
</style>
621
</resources>

app/src/main/res/values/styles.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
<item name="colorAccent">@color/colorAccent</item>
1010
-->
1111
<item name="actionOverflowMenuStyle">@style/PopupMenu</item>
12+
<item name="popupMenuStyle">@style/PopupMenu</item>
1213
<item name="android:contextPopupMenuStyle">@style/PopupMenu</item>
13-
<item name="android:panelBackground">@drawable/menu_border_background</item>
1414
</style>
1515

1616
<!-- Base application theme. -->

0 commit comments

Comments
 (0)