fix(tapo): add pylint disables for python-kasa version compatibility

Suppress unexpected-keyword-arg warnings for uses_http and http_port
parameters that exist in different python-kasa API versions.

Additionally tapo.py and test_tapo.py are now ruff formatted.

Signed-off-by: Marek Szczypiński <markacy@gmail.com>

Author: MarekSzczypinski

labgrid/driver/power/tapo.py

@@ -43,6 +43,8 @@ def _get_connection_type() -> DeviceConnectionParameters:
             https=False,
             login_version=2,
         )
+    # http_port parameter exists in new kasa (>= 0.10.0) API but not in old versions (<= 0.9.1)
+    # pylint: disable-next=unexpected-keyword-arg
     return DeviceConnectionParameters(
         device_family=DeviceFamily.SmartTapoPlug,
         encryption_type=DeviceEncryptionType.Klap,
@@ -55,12 +57,12 @@ def _get_connection_type() -> DeviceConnectionParameters:
 def _get_device_config(host: str) -> DeviceConfig:
     # Same as with `_get_connection_type` - python-kasa API changed
     if _using_old_kasa_api():
+        # uses_http parameter exists in old kasa (<= 0.9.1) API but not in new versions (>= 0.10.0)
+        # pylint: disable-next=unexpected-keyword-arg
         return DeviceConfig(
             host=host, credentials=_get_credentials(), connection_type=_get_connection_type(), uses_http=True
         )  # type: ignore[call-arg]
-    return DeviceConfig(
-        host=host, credentials=_get_credentials(), connection_type=_get_connection_type()
-    )
+    return DeviceConfig(host=host, credentials=_get_credentials(), connection_type=_get_connection_type())
 
 
 async def _power_set(host: str, port: str, index: str, value: bool) -> None:

tests/test_tapo.py

@@ -9,11 +9,7 @@
 @pytest.fixture
 def mock_device_strip():
     device = AsyncMock()
-    device.children = [
-        AsyncMock(is_on=True),
-        AsyncMock(is_on=False),
-        AsyncMock(is_on=True)
-    ]
+    device.children = [AsyncMock(is_on=True), AsyncMock(is_on=False), AsyncMock(is_on=True)]
     return device
 
 
@@ -26,117 +22,117 @@ def mock_device_single_plug():
 
 @pytest.fixture
 def mock_env():
-    os.environ['KASA_USERNAME'] = 'test_user'
-    os.environ['KASA_PASSWORD'] = 'test_pass'
+    os.environ["KASA_USERNAME"] = "test_user"
+    os.environ["KASA_PASSWORD"] = "test_pass"
     yield
-    del os.environ['KASA_USERNAME']
-    del os.environ['KASA_PASSWORD']
+    del os.environ["KASA_USERNAME"]
+    del os.environ["KASA_PASSWORD"]
 
 
 class TestTapoPowerDriver:
     def test_get_credentials_should_raise_value_error_when_credentials_missing(self):
         # Save existing environment variables
-        saved_username = os.environ.pop('KASA_USERNAME', None)
-        saved_password = os.environ.pop('KASA_PASSWORD', None)
+        saved_username = os.environ.pop("KASA_USERNAME", None)
+        saved_password = os.environ.pop("KASA_PASSWORD", None)
 
         try:
             with pytest.raises(EnvironmentError, match="KASA_USERNAME or KASA_PASSWORD environment variable not set"):
                 _get_credentials()
         finally:
             # Restore environment variables if they existed
             if saved_username is not None:
-                os.environ['KASA_USERNAME'] = saved_username
+                os.environ["KASA_USERNAME"] = saved_username
             if saved_password is not None:
-                os.environ['KASA_PASSWORD'] = saved_password
+                os.environ["KASA_PASSWORD"] = saved_password
 
     def test_credentials_valid(self, mock_env):
         creds = _get_credentials()
-        assert creds.username == 'test_user'
-        assert creds.password == 'test_pass'
+        assert creds.username == "test_user"
+        assert creds.password == "test_pass"
 
     @pytest.mark.asyncio
     async def test_power_get_single_plug_turn_on(self, mock_device_single_plug, mock_env):
         mock_device_single_plug.is_on = True
 
-        with patch('kasa.Device.connect', return_value=mock_device_single_plug):
-            result = await _power_get('192.168.1.100', None, "0")
+        with patch("kasa.Device.connect", return_value=mock_device_single_plug):
+            result = await _power_get("192.168.1.100", None, "0")
             assert result is True
 
     @pytest.mark.asyncio
     async def test_power_get_single_plug_turn_off(self, mock_device_single_plug, mock_env):
         mock_device_single_plug.is_on = False
 
-        with patch('kasa.Device.connect', return_value=mock_device_single_plug):
-            result = await _power_get('192.168.1.100', None, "0")
+        with patch("kasa.Device.connect", return_value=mock_device_single_plug):
+            result = await _power_get("192.168.1.100", None, "0")
             assert result is False
 
     @pytest.mark.asyncio
     async def test_power_get_single_plug_should_not_care_for_index(self, mock_device_single_plug, mock_env):
         invalid_index_ignored = "7"
         mock_device_single_plug.is_on = True
 
-        with patch('kasa.Device.connect', return_value=mock_device_single_plug):
-            result = await _power_get('192.168.1.100', None, invalid_index_ignored)
+        with patch("kasa.Device.connect", return_value=mock_device_single_plug):
+            result = await _power_get("192.168.1.100", None, invalid_index_ignored)
             assert result is True
 
     @pytest.mark.asyncio
     async def test_power_set_single_plug_turn_on(self, mock_device_single_plug, mock_env):
         mock_device_single_plug.is_on = False
-        with patch('kasa.Device.connect', return_value=mock_device_single_plug):
-            await _power_set('192.168.1.100', None, "0", True)
+        with patch("kasa.Device.connect", return_value=mock_device_single_plug):
+            await _power_set("192.168.1.100", None, "0", True)
             mock_device_single_plug.turn_on.assert_called_once()
 
     @pytest.mark.asyncio
     async def test_power_set_single_plug_turn_off(self, mock_device_single_plug, mock_env):
         mock_device_single_plug.is_on = True
-        with patch('kasa.Device.connect', return_value=mock_device_single_plug):
-            await _power_set('192.168.1.100', None, "0", False)
+        with patch("kasa.Device.connect", return_value=mock_device_single_plug):
+            await _power_set("192.168.1.100", None, "0", False)
             mock_device_single_plug.turn_off.assert_called_once()
 
     @pytest.mark.asyncio
     async def test_power_get_strip_valid_socket(self, mock_device_strip, mock_env):
-        with patch('kasa.Device.connect', return_value=mock_device_strip):
+        with patch("kasa.Device.connect", return_value=mock_device_strip):
             # Test first outlet (on)
-            result = await _power_get('192.168.1.100', None, "0")
+            result = await _power_get("192.168.1.100", None, "0")
             assert result is True
 
             # Test second outlet (off)
-            result = await _power_get('192.168.1.100', None, "1")
+            result = await _power_get("192.168.1.100", None, "1")
             assert result is False
 
             # Test third outlet (on)
-            result = await _power_get('192.168.1.100', None, "2")
+            result = await _power_get("192.168.1.100", None, "2")
             assert result is True
 
     @pytest.mark.asyncio
     async def test_power_set_strip_valid_socket(self, mock_device_strip, mock_env):
-        with patch('kasa.Device.connect', return_value=mock_device_strip):
-            await _power_set('192.168.1.100', None, "0", False)
+        with patch("kasa.Device.connect", return_value=mock_device_strip):
+            await _power_set("192.168.1.100", None, "0", False)
             mock_device_strip.children[0].turn_off.assert_called_once()
 
-            await _power_set('192.168.1.100', None, "1", True)
+            await _power_set("192.168.1.100", None, "1", True)
             mock_device_strip.children[1].turn_on.assert_called_once()
 
     def test_power_get_should_raise_assertion_error_when_invalid_index_strip(self, mock_device_strip, mock_env):
         invalid_socket = "5"
-        with patch('kasa.Device.connect', return_value=mock_device_strip):
+        with patch("kasa.Device.connect", return_value=mock_device_strip):
             with pytest.raises(AssertionError, match="Trying to access non-existant plug socket"):
-                power_get('192.168.1.100', None, invalid_socket)
+                power_get("192.168.1.100", None, invalid_socket)
 
     @pytest.mark.asyncio
     async def test_power_set_should_raise_assertion_error_when_invalid_index_strip(self, mock_device_strip, mock_env):
         invalid_socket = "5"
-        with patch('kasa.Device.connect', return_value=mock_device_strip):
+        with patch("kasa.Device.connect", return_value=mock_device_strip):
             with pytest.raises(AssertionError, match="Trying to access non-existant plug socket"):
-                await _power_set('192.168.1.100', None, invalid_socket, True)
+                await _power_set("192.168.1.100", None, invalid_socket, True)
 
     def test_port_not_none_strip(self, mock_device_strip):
-        with patch('kasa.Device.connect', return_value=mock_device_strip):
+        with patch("kasa.Device.connect", return_value=mock_device_strip):
             with pytest.raises(AssertionError):
-                power_get('192.168.1.100', '8080', "0")
+                power_get("192.168.1.100", "8080", "0")
 
     def test_port_not_none_single_socket(self, mock_device_single_plug):
         mock_device_single_plug.is_on = True
-        with patch('kasa.Device.connect', return_value=mock_device_single_plug):
+        with patch("kasa.Device.connect", return_value=mock_device_single_plug):
             with pytest.raises(AssertionError):
-                power_get('192.168.1.100', '8080', "0")
+                power_get("192.168.1.100", "8080", "0")