driver: shelly_gen1: fix for Shelly Plug US Gen4#1852
Open
jiez wants to merge 1 commit intolabgrid-project:masterfrom
Open
driver: shelly_gen1: fix for Shelly Plug US Gen4#1852jiez wants to merge 1 commit intolabgrid-project:masterfrom
jiez wants to merge 1 commit intolabgrid-project:masterfrom
Conversation
POST is not supported by Shelly Plug US Gen4. Use GET instead. Signed-off-by: Jie Zhang <jie.zhang@analog.com>
Author
|
I'm using the labgrid packages from Debian forky. They were created based on the latest release, which has no shelly_gen2 driver yet. I copied shelly_gen2 python file into the installation location and tried it. It has a bug. And there is already a PR for it: #1766 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST is not supported by Shelly Plug US Gen4. Use GET instead.
I tried shelly_gen1 driver on a Shelly Plug US Gen4 and found that this Shelly plug does not support POST. Replacing POST with GET seems working. But I don't have other Shelly plugs to test for.