Exporter error propagation#1886
Conversation
There was a problem hiding this comment.
The second commit message will need an actual message instead of the title line and it may be beneficial to squash some commits.
I would like some test infrastructure for these new changes, but this requires rework of the coordinator/exporter/client testing in the testsuite first, which is out of scope for this PR.
Implementation wise this looks good and should improve our error reporting to the user.
|
@Emantor happy to squash down to one commit if you think fits better? |
|
Yes, squashing to one commit should be fine. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1886 +/- ##
========================================
- Coverage 46.0% 45.8% -0.2%
========================================
Files 180 180
Lines 14464 14498 +34
========================================
Hits 6654 6654
- Misses 7810 7844 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Report exporter acquire and release failures back through the coordinator RPCs instead of collapsing them to generic precondition errors. Preserve exporter command timeout and exception details so clients can see the underlying failure reason. Signed-off-by: Asher Pemberton <asher.pemberton@arm.com> Reviewed-by: Asher Pemberton <asher.pemberton@arm.com> # gatekeeper Co-authored-by: Idan Saadon <idan.saadon@arm.com>
2053716 to
1337d98
Compare
Forward acquire/release failure reasons through the coordinator to the client.
This makes coordinator and exporter failures visible to users instead of returning only a generic lock/acquire failure.
The MR is split into focused commits:
report coordinator-side acquire/release failures to the client
preserve exporter failure reasons
report exporter command timeouts
reduce exported resource details in user-facing errors
Without this, it is hard to tell whether a failure happened in the client, coordinator, exporter.