Skip to content

Exporter error propagation#1886

Open
asher-pem-arm wants to merge 1 commit into
labgrid-project:masterfrom
ARM-software:exporter-error-propagation
Open

Exporter error propagation#1886
asher-pem-arm wants to merge 1 commit into
labgrid-project:masterfrom
ARM-software:exporter-error-propagation

Conversation

@asher-pem-arm

Copy link
Copy Markdown
Contributor

Forward acquire/release failure reasons through the coordinator to the client.
This makes coordinator and exporter failures visible to users instead of returning only a generic lock/acquire failure.
The MR is split into focused commits:

report coordinator-side acquire/release failures to the client
preserve exporter failure reasons
report exporter command timeouts
reduce exported resource details in user-facing errors

Without this, it is hard to tell whether a failure happened in the client, coordinator, exporter.

@Emantor Emantor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit message will need an actual message instead of the title line and it may be beneficial to squash some commits.

I would like some test infrastructure for these new changes, but this requires rework of the coordinator/exporter/client testing in the testsuite first, which is out of scope for this PR.

Implementation wise this looks good and should improve our error reporting to the user.

@asher-pem-arm

Copy link
Copy Markdown
Contributor Author

@Emantor happy to squash down to one commit if you think fits better?

@Emantor

Emantor commented Jun 18, 2026

Copy link
Copy Markdown
Member

Yes, squashing to one commit should be fine.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.8%. Comparing base (915b591) to head (2053716).
⚠️ Report is 12 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/remote/coordinator.py 0.0% 45 Missing ⚠️
labgrid/remote/exporter.py 0.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1886     +/-   ##
========================================
- Coverage    46.0%   45.8%   -0.2%     
========================================
  Files         180     180             
  Lines       14464   14498     +34     
========================================
  Hits         6654    6654             
- Misses       7810    7844     +34     
Flag Coverage Δ
3.10 45.8% <0.0%> (-0.2%) ⬇️
3.11 45.8% <0.0%> (-0.2%) ⬇️
3.12 45.8% <0.0%> (-0.2%) ⬇️
3.13 45.8% <0.0%> (-0.2%) ⬇️
3.14 45.8% <0.0%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Report exporter acquire and release failures back through the coordinator RPCs instead of collapsing them to generic precondition errors.

Preserve exporter command timeout and exception details so clients can see the underlying failure reason.

Signed-off-by: Asher Pemberton <asher.pemberton@arm.com>
Reviewed-by: Asher Pemberton <asher.pemberton@arm.com> # gatekeeper
Co-authored-by: Idan Saadon <idan.saadon@arm.com>
@asher-pem-arm asher-pem-arm force-pushed the exporter-error-propagation branch from 2053716 to 1337d98 Compare June 30, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants