driver/power: Add RPM1521 support - #1934
Open
CalebEthridgeADI wants to merge 2 commits into
Open
Conversation
jluebbe
reviewed
Jul 13, 2026
Comment on lines
+52
to
+58
| # The status CGI returns a list literal, e.g. | ||
| # ['RPM1521E','0.0','NULL','1','1','109.9',['1','0'],['0','1'],['0.0','0.0']] | ||
| # It contains several bracketed sub-lists; the second to last one holds the | ||
| # on/off status of each outlet. | ||
| groups = re.findall(r"\[[^\[\]]+\]", r.text) | ||
| socket_states = re.findall(r"\d+", groups[-2]) | ||
| return int(socket_states[index - 1]) == 1 |
Member
There was a problem hiding this comment.
This looks like JSON... Is there a reason not to use json.loads instead of regex?
Author
There was a problem hiding this comment.
Updated the driver to switch from regex to json.loads. Thanks for the review Jan!
Add power backend for the Minuteman RPM1521 series of power switches(2,4,8 ports). Signed-off-by: Caleb Ethridge <caleb.ethridge@analog.com>
CalebEthridgeADI
force-pushed
the
add-rpm1521-driver
branch
from
July 13, 2026 18:25
d0f1f31 to
cb93903
Compare
Signed-off-by: Caleb Ethridge <caleb.ethridge@analog.com>
CalebEthridgeADI
force-pushed
the
add-rpm1521-driver
branch
from
July 13, 2026 18:29
cb93903 to
b7abeaf
Compare
Emantor
approved these changes
Jul 31, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1934 +/- ##
========================================
- Coverage 61.0% 60.9% -0.1%
========================================
Files 182 183 +1
Lines 14881 14900 +19
========================================
+ Hits 9083 9088 +5
- Misses 5798 5812 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add power driver support for the Minuteman RPM1521 series which comes in 2, 4 and 8 port configurations. This driver should also work for the Amberry IP2,4,8 series as they are based on the same hardware.
Tested locally on an RPM1521E.
Checklist