remote/client: let -p restrict env-wide acquire/release - #1943
Open
Sanjays2402 wants to merge 1 commit into
Open
remote/client: let -p restrict env-wide acquire/release#1943Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
Since acquire/release started operating on all RemotePlaces in the environment config, passing both -c env.yaml and -p NAME silently ignored -p and acquired every place in the env, contending with other users and CI jobs. An explicitly requested place (-p/--place, LG_PLACE or the legacy PLACE variable) now restricts acquire/release to that single place; without one the env-wide behaviour is unchanged. Adds a regression test covering -c env.yaml combined with -p.
Member
|
I don't think we want to support this case. Environment files describe the complete testing environment, if only a subset of places is required for the test run, this should be done in a new separate environment file. |
Author
|
Fair enough, that's a reasonable line to hold. I read Happy to close this. #1942 is unrelated and stands on its own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since
acquire/releasestarted operating on allRemotePlaces in the environment config, passing both-c env.yamland-p NAMEsilently ignored-pand acquired every place in the env — contending with other users and CI jobs that historically used that combination to manage one device at a time.An explicitly requested place (
-p/--place,LG_PLACE, or the legacyPLACEvariable) now restrictsacquire/releaseto that single place. Without one, the env-wide behaviour is unchanged.Checklist
Tested locally: the new
test_place_acquire_with_env_and_placefails on master (both places acquired) and passes with the fix;test_place_acquire,test_place_acquire_multipleandtest_place_acquire_enforcestill pass.Fixes #1868