driver: add initial type hints for common driver code - #1946
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1946 +/- ##
======================================
Coverage 61.0% 61.0%
======================================
Files 182 182
Lines 14898 14902 +4
======================================
+ Hits 9094 9104 +10
+ Misses 5804 5798 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
2631215 to
8411023
Compare
Emantor
left a comment
There was a problem hiding this comment.
Changes look good to me, do you also want to add a ty check run to this PR for the CI or is it too early for that?
Thanks for your approval! I'd be happy to add such check to CI. If you don't mind, I'd do that in a separate commit. EDIT: just re-pushed to get the commit of this PR verified. |
8411023 to
5efa0dc
Compare
Add `ty` as a development dependency and configure it to check one initial driver module. Annotate `labgrid.driver.common` while leaving existing attrs-based exception behavior unchanged. Signed-off-by: Rainer Poisel <rainer@embedded-focus.com>
5efa0dc to
427d66f
Compare
Description
This PR starts adding type annotations incrementally, as discussed in #1945.
It adds
tyas a development dependency and configures it to check a small initial module of the codebase:labgrid/driver/common.py.Verified locally with:
Checklist