Use dedicated loggers for ClientSession/Place - #1950
Open
Bastian-Krause wants to merge 3 commits into
Open
Conversation
Allows attributing the messages logged to the corresponding labgrid component. Signed-off-by: Bastian Krause <bst@pengutronix.de>
Helps attributing log messages to ClientSession. Otherwise they are logged using the root logger. Signed-off-by: Bastian Krause <bst@pengutronix.de>
Helps attributing log messages to Place. Otherwise they are logged using the root logger. Signed-off-by: Bastian Krause <bst@pengutronix.de>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1950 +/- ##
======================================
Coverage 61.0% 61.0%
======================================
Files 182 182
Lines 14898 14903 +5
======================================
+ Hits 9097 9103 +6
+ Misses 5801 5800 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Emantor
reviewed
Aug 3, 2026
| self.sync_id = itertools.count(start=1) | ||
| self.sync_events = {} | ||
|
|
||
| self.logger = logging.getLogger("ClientSession") |
Member
There was a problem hiding this comment.
Should we add a session identifier into the longer? f"ClientSession.{address}"?
Member
Author
There was a problem hiding this comment.
I can't think of a case with multiple ClientSessions in a single run, so I guess it's not required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
labgrid produces a lot of logs. Try to get rid of logs emitted by the root logger, so proper filtering and attribution is possible.
Checklist