Commit 2ab8e80
committed
resolves #6589 (FR-2519)
**Changes:**
Modified the Service Launcher to send `undefined` for `modelDefinitionPath` when the field is left empty, instead of hardcoding the default value `'model-definition.yaml'`. This allows the server to infer the appropriate model definition path rather than forcing a specific filename.
**Rationale:**
Previously, empty `modelDefinitionPath` values were automatically converted to `'model-definition.yaml'` on the client side. By sending `undefined` instead, the server can now determine the most appropriate model definition file based on its own logic and the specific context of the service being launched.
**Impact:**
Users can now leave the model definition path field blank and rely on server-side inference for determining the correct model definition file, providing more flexibility in service configuration.
**Checklist:** (if applicable)
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
1 parent cad7b3b commit 2ab8e80
1 file changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
630 | 630 | | |
631 | 631 | | |
632 | 632 | | |
| 633 | + | |
| 634 | + | |
633 | 635 | | |
634 | 636 | | |
635 | | - | |
| 637 | + | |
636 | 638 | | |
637 | 639 | | |
638 | 640 | | |
| |||
920 | 922 | | |
921 | 923 | | |
922 | 924 | | |
923 | | - | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
924 | 928 | | |
925 | 929 | | |
926 | 930 | | |
| |||
0 commit comments