refactor(FR-3223): swap enabled toggle for footer Reset + Delete actions

The manager stores the announcement purely by presence, so the `enabled` flag
cannot be persisted and its footer toggle could not work. Comment out the
toggle (kept for a future backend that can persist it) and give the footer two
explicit actions, following the Edit Bootstrap Script modal:

- Reset: clears the editor content locally (Popconfirm-guarded) so the admin
  can start over without touching the server.
- Delete: removes the published announcement via update_announcement(false, ''),
  routed through a confirm modal (not an inline Popconfirm); disabled when
  nothing is stored.

Publishing always enables (enabled=true) and requires a non-empty message.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: agatha197

react/src/components/AnnouncementEditModal.tsx

@@ -9,7 +9,9 @@ import BAICodeEditor from './BAICodeEditor';
 import { SyntaxHighlighter } from './Chat/SyntaxHighlighter';
 import {
   BoldOutlined,
+  ClearOutlined,
   CodeOutlined,
+  DeleteOutlined,
   FontSizeOutlined,
   ItalicOutlined,
   LinkOutlined,
@@ -23,8 +25,8 @@ import { useQueryClient } from '@tanstack/react-query';
 import {
   App,
   Button,
-  Checkbox,
   Dropdown,
+  Popconfirm,
   Skeleton,
   theme,
   Tooltip,
@@ -222,7 +224,7 @@ const AnnouncementEditModal: React.FC<AnnouncementEditModalProps> = ({
   const { t } = useTranslation();
   const { token } = theme.useToken();
   const { styles } = useStyles();
-  const { message: appMessage } = App.useApp();
+  const { message: appMessage, modal } = App.useApp();
   const { logger } = useBAILogger();
   const { getErrorMessage } = useErrorMessageResolver();
 
@@ -236,19 +238,22 @@ const AnnouncementEditModal: React.FC<AnnouncementEditModalProps> = ({
     announcementQueryOptions(baiClient),
   );
 
-  // `enabled` and `message` are plain local state, not antd Form fields: the
-  // Enabled toggle lives in the modal footer (outside any <Form>), so keeping
-  // both in one state model avoids bridging a footer control into a form store.
-  // `undefined` means "not edited yet" → fall back to the server value; once the
-  // user changes a field the draft takes over.
-  const [enabledDraft, setEnabledDraft] = useState<boolean>();
+  // The `enabled` flag is not user-controllable for now: the manager stores the
+  // announcement purely by presence — publishing a message enables it, and
+  // "disabling" it just deletes the stored message (there is no way to persist a
+  // disabled-but-present announcement). So the footer exposes an explicit Delete
+  // action instead of an Enabled toggle. The toggle implementation is kept below
+  // (commented out) so it can be restored once the backend can persist the flag.
+  //
+  // const [enabledDraft, setEnabledDraft] = useState<boolean>();
+  // const enabled = enabledDraft ?? announcement?.enabled ?? true;
   const [messageDraft, setMessageDraft] = useState<string>();
-  const enabled = enabledDraft ?? announcement?.enabled ?? true;
   const message = messageDraft ?? announcement?.message ?? '';
 
-  // The backend rejects enabling an announcement with an empty message ("Empty
-  // message not allowed to enable announcement"); enforce the same rule here.
-  const isMessageMissing = enabled && !message.trim();
+  // Publishing always enables the announcement, and the backend rejects an empty
+  // message ("Empty message not allowed to enable announcement"), so a non-empty
+  // message is required to publish. (Previously gated on `enabled && ...`.)
+  const isMessageMissing = !message.trim();
 
   const updateMutation = useTanMutation({
     mutationFn: (values: AnnouncementValues) => {
@@ -259,10 +264,16 @@ const AnnouncementEditModal: React.FC<AnnouncementEditModalProps> = ({
     },
   });
 
+  // Deleting is `update_announcement(false, ...)`: with `enabled: false` the
+  // manager removes the stored message from etcd, clearing the announcement.
+  const deleteMutation = useTanMutation({
+    mutationFn: () => baiClient.service.update_announcement(false, ''),
+  });
+
   const handleSubmit = () => {
     if (isMessageMissing) return;
     updateMutation.mutate(
-      { enabled, message },
+      { enabled: true, message },
       {
         onSuccess: () => {
           appMessage.success(t('summary.AnnouncementUpdated'));
@@ -279,20 +290,83 @@ const AnnouncementEditModal: React.FC<AnnouncementEditModalProps> = ({
     );
   };
 
+  // Reset only clears the editor content locally so the admin can start over;
+  // it does not touch the server. Publish stays disabled until a non-empty
+  // message exists again.
+  const handleReset = () => {
+    setMessageDraft('');
+  };
+
+  const handleDelete = async () => {
+    try {
+      await deleteMutation.mutateAsync();
+      appMessage.success(t('summary.AnnouncementDeleted'));
+      queryClient.invalidateQueries({
+        queryKey: announcementQueryOptions(baiClient).queryKey,
+      });
+      onRequestClose(true);
+    } catch (error) {
+      appMessage.error(getErrorMessage(error));
+      logger.error(error);
+    }
+  };
+
+  // Delete removes the published announcement from the server, so it goes
+  // through a confirm modal instead of firing on the footer click. `onOk`
+  // returns the delete promise so the modal's OK button shows a spinner until
+  // the request settles.
+  const confirmDelete = () => {
+    modal.confirm({
+      title: t('dialog.ask.DoYouWantToDelete'),
+      content: t('dialog.warning.CannotBeUndone'),
+      okText: t('button.Delete'),
+      okButtonProps: { danger: true },
+      onOk: handleDelete,
+    });
+  };
+
   return (
     <BAIModal
       width="90%"
       style={{ maxWidth: 1900 }}
       title={t('summary.EditAnnouncement')}
       onCancel={() => onRequestClose()}
       footer={
-        <BAIFlex justify="between" align="center" gap="sm">
+        <BAIFlex
+          justify="between"
+          align="center"
+          gap="sm"
+          style={{ width: '100%' }}
+        >
+          {/* Delete clears the published announcement. Disabled when there is
+              nothing stored to delete. Restore the Enabled checkbox here once
+              the backend can persist a disabled-but-present announcement:
           <Checkbox
             checked={enabled}
             onChange={(e) => setEnabledDraft(e.target.checked)}
           >
             {t('summary.AnnouncementEnabled')}
-          </Checkbox>
+          </Checkbox> */}
+          <BAIFlex gap="xs" align="center">
+            <Popconfirm
+              title={t('dialog.ask.DoYouWantToResetChanges')}
+              okButtonProps={{ danger: true }}
+              onConfirm={handleReset}
+            >
+              <Button icon={<ClearOutlined />} disabled={isLoading}>
+                {t('button.Reset')}
+              </Button>
+            </Popconfirm>
+            <Button
+              danger
+              icon={<DeleteOutlined />}
+              disabled={isLoading || !announcement?.enabled}
+              loading={deleteMutation.isPending}
+              onClick={confirmDelete}
+            >
+              {t('button.Delete')}
+            </Button>
+          </BAIFlex>
           <BAIFlex gap="xs" align="center">
             <Button onClick={() => onRequestClose()}>
               {t('button.Cancel')}

resources/i18n/de.json

@@ -3222,18 +3222,19 @@
     "AcceptSharedVFolder": "Sie können jetzt auf den Ordner zugreifen:",
     "ActiveSessions": "Aktive Sitzungen",
     "Announcement": "Ankündigung",
+    "AnnouncementDeleted": "Ankündigung wurde gelöscht.",
+    "AnnouncementEnabled": "Aktiviert",
+    "AnnouncementMessage": "Nachricht",
+    "AnnouncementMessageRequired": "Bitte geben Sie eine Nachricht ein, um die Ankündigung zu aktivieren.",
+    "AnnouncementPreview": "Vorschau",
+    "AnnouncementUpdated": "Ankündigung wurde aktualisiert.",
     "CLI": "CLI",
     "CLIDownloadExecutable": "Eigenständige ausführbare Datei herunterladen",
     "CLIGetStartedDescription": "Konfigurieren Sie mit Ihren aktuellen Sitzungsanmeldedaten:",
     "CLIInstallViaPip": "Über pip installieren",
     "CLIMacOSUnsignedDescription": "Dieser Build ist nicht signiert, daher könnte macOS ihn blockieren. Entfernen Sie nach dem Herunterladen das Quarantäne-Flag und machen Sie die Datei ausführbar:",
     "CLIMacOSUnsignedTitle": "macOS könnte diesen unsignierten Build blockieren",
     "CLIRunExecutableDescription": "Machen Sie die Datei nach dem Herunterladen ausführbar und führen Sie sie aus:",
-    "AnnouncementEnabled": "Aktiviert",
-    "AnnouncementMessage": "Nachricht",
-    "AnnouncementMessageRequired": "Bitte geben Sie eine Nachricht ein, um die Ankündigung zu aktivieren.",
-    "AnnouncementPreview": "Vorschau",
-    "AnnouncementUpdated": "Ankündigung wurde aktualisiert.",
     "ChangeSystemSetting": "Systemeinstellung ändern",
     "CheckResources": "Ressourcen prüfen",
     "ConnectedNodes": "Verbunden <br/> Knoten",

resources/i18n/el.json

@@ -3220,18 +3220,19 @@
     "AcceptSharedVFolder": "Τώρα μπορείτε να αποκτήσετε πρόσβαση σε φάκελο:",
     "ActiveSessions": "Ενεργές Συνεδρίες",
     "Announcement": "Ανακοίνωση",
+    "AnnouncementDeleted": "Η ανακοίνωση διαγράφηκε.",
+    "AnnouncementEnabled": "Ενεργοποιημένο",
+    "AnnouncementMessage": "Μήνυμα",
+    "AnnouncementMessageRequired": "Παρακαλώ εισάγετε ένα μήνυμα για να ενεργοποιήσετε την ανακοίνωση.",
+    "AnnouncementPreview": "Προεπισκόπηση",
+    "AnnouncementUpdated": "Η ανακοίνωση ενημερώθηκε.",
     "CLI": "CLI",
     "CLIDownloadExecutable": "Λήψη αυτόνομου εκτελέσιμου αρχείου",
     "CLIGetStartedDescription": "Διαμορφώστε με τα διαπιστευτήρια της τρέχουσας περιόδου σύνδεσής σας:",
     "CLIInstallViaPip": "Εγκατάσταση μέσω pip",
     "CLIMacOSUnsignedDescription": "Αυτή η έκδοση δεν είναι υπογεγραμμένη, επομένως το macOS ενδέχεται να την αποκλείσει. Μετά τη λήψη, καταργήστε τη σήμανση quarantine και κάντε το αρχείο εκτελέσιμο:",
     "CLIMacOSUnsignedTitle": "Το macOS ενδέχεται να αποκλείσει αυτήν την ανυπόγραφη έκδοση",
     "CLIRunExecutableDescription": "Μετά τη λήψη, κάντε το αρχείο εκτελέσιμο και εκτελέστε το:",
-    "AnnouncementEnabled": "Ενεργοποιημένο",
-    "AnnouncementMessage": "Μήνυμα",
-    "AnnouncementMessageRequired": "Παρακαλώ εισάγετε ένα μήνυμα για να ενεργοποιήσετε την ανακοίνωση.",
-    "AnnouncementPreview": "Προεπισκόπηση",
-    "AnnouncementUpdated": "Η ανακοίνωση ενημερώθηκε.",
     "ChangeSystemSetting": "Αλλαγή ρύθμισης συστήματος",
     "CheckResources": "Ελέγξτε πόρους",
     "ConnectedNodes": "Συνδεδεμένοι κόμβοι <br/>",

resources/i18n/en.json

@@ -3207,6 +3207,7 @@
     "AcceptSharedVFolder": "You can now access folder: ",
     "ActiveSessions": "Active Sessions",
     "Announcement": "Announcement",
+    "AnnouncementDeleted": "Announcement deleted.",
     "AnnouncementEnabled": "Enabled",
     "AnnouncementMessage": "Message",
     "AnnouncementMessageRequired": "Please enter a message to enable the announcement.",

resources/i18n/es.json

@@ -3220,18 +3220,19 @@
     "AcceptSharedVFolder": "Ahora puede acceder a la carpeta:",
     "ActiveSessions": "Sesiones activas",
     "Announcement": "Anuncio",
+    "AnnouncementDeleted": "El anuncio ha sido eliminado.",
+    "AnnouncementEnabled": "Habilitado",
+    "AnnouncementMessage": "Mensaje",
+    "AnnouncementMessageRequired": "Por favor, ingrese un mensaje para habilitar el anuncio.",
+    "AnnouncementPreview": "Vista previa",
+    "AnnouncementUpdated": "El anuncio ha sido actualizado.",
     "CLI": "CLI",
     "CLIDownloadExecutable": "Descargar ejecutable independiente",
     "CLIGetStartedDescription": "Configura con las credenciales de tu sesión actual:",
     "CLIInstallViaPip": "Instalar mediante pip",
     "CLIMacOSUnsignedDescription": "Esta compilación no está firmada, por lo que macOS puede bloquearla. Después de descargarla, elimina el indicador de quarantine y hazla ejecutable:",
     "CLIMacOSUnsignedTitle": "macOS puede bloquear esta compilación sin firmar",
     "CLIRunExecutableDescription": "Después de descargarlo, hazlo ejecutable y ejecútalo:",
-    "AnnouncementEnabled": "Habilitado",
-    "AnnouncementMessage": "Mensaje",
-    "AnnouncementMessageRequired": "Por favor, ingrese un mensaje para habilitar el anuncio.",
-    "AnnouncementPreview": "Vista previa",
-    "AnnouncementUpdated": "El anuncio ha sido actualizado.",
     "ChangeSystemSetting": "Cambiar la configuración del sistema",
     "CheckResources": "Comprobar recursos",
     "ConnectedNodes": "Conectado<br/>Nodos",

resources/i18n/fi.json

@@ -3220,18 +3220,19 @@
     "AcceptSharedVFolder": "Voit nyt käyttää kansiota:",
     "ActiveSessions": "Aktiiviset istunnot",
     "Announcement": "Ilmoitus",
+    "AnnouncementDeleted": "Ilmoitus on poistettu.",
+    "AnnouncementEnabled": "Käytössä",
+    "AnnouncementMessage": "Viesti",
+    "AnnouncementMessageRequired": "Syötä viesti ottaaksesi ilmoituksen käyttöön.",
+    "AnnouncementPreview": "Esikatselu",
+    "AnnouncementUpdated": "Ilmoitus on päivitetty.",
     "CLI": "CLI",
     "CLIDownloadExecutable": "Lataa itsenäinen suoritettava tiedosto",
     "CLIGetStartedDescription": "Määritä nykyisen istuntosi tunnistetiedoilla:",
     "CLIInstallViaPip": "Asenna pip-komennolla",
     "CLIMacOSUnsignedDescription": "Tätä koontiversiota ei ole allekirjoitettu, joten macOS saattaa estää sen. Poista latauksen jälkeen quarantine-merkintä ja tee tiedostosta suoritettava:",
     "CLIMacOSUnsignedTitle": "macOS saattaa estää tämän allekirjoittamattoman koontiversion",
     "CLIRunExecutableDescription": "Tee lataamisen jälkeen tiedostosta suoritettava ja suorita se:",
-    "AnnouncementEnabled": "Käytössä",
-    "AnnouncementMessage": "Viesti",
-    "AnnouncementMessageRequired": "Syötä viesti ottaaksesi ilmoituksen käyttöön.",
-    "AnnouncementPreview": "Esikatselu",
-    "AnnouncementUpdated": "Ilmoitus on päivitetty.",
     "ChangeSystemSetting": "Vaihda järjestelmäasetusta",
     "CheckResources": "Tarkista resurssit",
     "ConnectedNodes": "Yhdistetyt<br/>Solmut",

resources/i18n/fr.json

@@ -3223,18 +3223,19 @@
     "AcceptSharedVFolder": "Vous pouvez maintenant accéder au dossier :",
     "ActiveSessions": "sessions actives",
     "Announcement": "Annonce",
+    "AnnouncementDeleted": "L'annonce a été supprimée.",
+    "AnnouncementEnabled": "Activé",
+    "AnnouncementMessage": "Message",
+    "AnnouncementMessageRequired": "Veuillez saisir un message pour activer l'annonce.",
+    "AnnouncementPreview": "Aperçu",
+    "AnnouncementUpdated": "L'annonce a été mise à jour.",
     "CLI": "CLI",
     "CLIDownloadExecutable": "Télécharger l'exécutable autonome",
     "CLIGetStartedDescription": "Configurez avec les informations d'identification de votre session actuelle :",
     "CLIInstallViaPip": "Installer via pip",
     "CLIMacOSUnsignedDescription": "Cette version n'est pas signée, macOS peut donc la bloquer. Après le téléchargement, retirez l'attribut quarantine et rendez le fichier exécutable :",
     "CLIMacOSUnsignedTitle": "macOS peut bloquer cette version non signée",
     "CLIRunExecutableDescription": "Après le téléchargement, rendez-le exécutable et exécutez-le :",
-    "AnnouncementEnabled": "Activé",
-    "AnnouncementMessage": "Message",
-    "AnnouncementMessageRequired": "Veuillez saisir un message pour activer l'annonce.",
-    "AnnouncementPreview": "Aperçu",
-    "AnnouncementUpdated": "L'annonce a été mise à jour.",
     "ChangeSystemSetting": "Modifier les paramètres du système",
     "CheckResources": "Consulter les ressources",
     "ConnectedNodes": "Nœuds connectés <br/>",

resources/i18n/id.json

@@ -3224,18 +3224,19 @@
     "AcceptSharedVFolder": "Anda sekarang dapat mengakses folder: ",
     "ActiveSessions": "Sesi Aktif",
     "Announcement": "Pengumuman",
+    "AnnouncementDeleted": "Pengumuman telah dihapus.",
+    "AnnouncementEnabled": "Diaktifkan",
+    "AnnouncementMessage": "Pesan",
+    "AnnouncementMessageRequired": "Masukkan pesan untuk mengaktifkan pengumuman.",
+    "AnnouncementPreview": "Pratinjau",
+    "AnnouncementUpdated": "Pengumuman telah diperbarui.",
     "CLI": "CLI",
     "CLIDownloadExecutable": "Unduh executable mandiri",
     "CLIGetStartedDescription": "Konfigurasikan dengan kredensial sesi Anda saat ini:",
     "CLIInstallViaPip": "Instal melalui pip",
     "CLIMacOSUnsignedDescription": "Build ini tidak ditandatangani, sehingga macOS mungkin memblokirnya. Setelah mengunduh, hapus flag quarantine dan jadikan dapat dieksekusi:",
     "CLIMacOSUnsignedTitle": "macOS mungkin memblokir build yang tidak ditandatangani ini",
     "CLIRunExecutableDescription": "Setelah mengunduh, jadikan dapat dieksekusi dan jalankan:",
-    "AnnouncementEnabled": "Diaktifkan",
-    "AnnouncementMessage": "Pesan",
-    "AnnouncementMessageRequired": "Masukkan pesan untuk mengaktifkan pengumuman.",
-    "AnnouncementPreview": "Pratinjau",
-    "AnnouncementUpdated": "Pengumuman telah diperbarui.",
     "ChangeSystemSetting": "Ubah pengaturan sistem",
     "CheckResources": "Periksa sumber daya",
     "ConnectedNodes": "Node<br/>Terhubung",

resources/i18n/it.json

@@ -3220,18 +3220,19 @@
     "AcceptSharedVFolder": "Ora puoi accedere alla cartella:",
     "ActiveSessions": "Sessioni Attive",
     "Announcement": "Annuncio",
+    "AnnouncementDeleted": "L'annuncio è stato eliminato.",
+    "AnnouncementEnabled": "Abilitato",
+    "AnnouncementMessage": "Messaggio",
+    "AnnouncementMessageRequired": "Inserisci un messaggio per abilitare l'annuncio.",
+    "AnnouncementPreview": "Anteprima",
+    "AnnouncementUpdated": "L'annuncio è stato aggiornato.",
     "CLI": "CLI",
     "CLIDownloadExecutable": "Scarica l'eseguibile standalone",
     "CLIGetStartedDescription": "Configura con le credenziali della sessione corrente:",
     "CLIInstallViaPip": "Installa tramite pip",
     "CLIMacOSUnsignedDescription": "Questa build non è firmata, quindi macOS potrebbe bloccarla. Dopo il download, rimuovi il flag di quarantine e rendila eseguibile:",
     "CLIMacOSUnsignedTitle": "macOS potrebbe bloccare questa build non firmata",
     "CLIRunExecutableDescription": "Dopo il download, rendilo eseguibile ed eseguilo:",
-    "AnnouncementEnabled": "Abilitato",
-    "AnnouncementMessage": "Messaggio",
-    "AnnouncementMessageRequired": "Inserisci un messaggio per abilitare l'annuncio.",
-    "AnnouncementPreview": "Anteprima",
-    "AnnouncementUpdated": "L'annuncio è stato aggiornato.",
     "ChangeSystemSetting": "Modifica impostazioni di sistema",
     "CheckResources": "Controlla le risorse",
     "ConnectedNodes": "Nodi connessi <br/>",

resources/i18n/ja.json

@@ -3222,18 +3222,19 @@
     "AcceptSharedVFolder": "これで、フォルダにアクセスできます。",
     "ActiveSessions": "アクティブセッション",
     "Announcement": "発表",
+    "AnnouncementDeleted": "発表が削除されました。",
+    "AnnouncementEnabled": "有効",
+    "AnnouncementMessage": "メッセージ",
+    "AnnouncementMessageRequired": "発表を有効にするには、メッセージを入力してください。",
+    "AnnouncementPreview": "プレビュー",
+    "AnnouncementUpdated": "発表が更新されました。",
     "CLI": "CLI",
     "CLIDownloadExecutable": "スタンドアロン実行ファイルをダウンロード",
     "CLIGetStartedDescription": "現在のセッションの認証情報で設定してください：",
     "CLIInstallViaPip": "pipでインストール",
     "CLIMacOSUnsignedDescription": "このビルドは署名されていないため、macOSによってブロックされる場合があります。ダウンロード後、quarantine属性を解除して実行可能にしてください：",
     "CLIMacOSUnsignedTitle": "macOSがこの未署名ビルドをブロックする場合があります",
     "CLIRunExecutableDescription": "ダウンロード後、実行可能にして実行してください：",
-    "AnnouncementEnabled": "有効",
-    "AnnouncementMessage": "メッセージ",
-    "AnnouncementMessageRequired": "発表を有効にするには、メッセージを入力してください。",
-    "AnnouncementPreview": "プレビュー",
-    "AnnouncementUpdated": "発表が更新されました。",
     "ChangeSystemSetting": "システム設定変更",
     "CheckResources": "リソース確認",
     "ConnectedNodes": "接続中ノード数",