e2e(FR-2472): review and rewrite failing Serving E2E tests

- Add deduplicateTomlKeys() to test-util.ts to handle duplicate TOML keys
  in remote server config.toml (fixes config.toml parse failures)
- Fix serving-deploy-lifecycle.spec.ts: set AI Accelerator to 0 to avoid
  GPU-based allocation preset (cuda01-small) causing service creation failures
- Fix model-definition.yaml fixture: remove initial_delay from health_check
  section which is rejected by the backend trafaret validator
- Update E2E_COVERAGE_REPORT.md with new Serving and Service Launcher coverage

Author: ironAiken2

e2e/E2E_COVERAGE_REPORT.md

@@ -1,6 +1,6 @@
 # E2E Test Coverage Report
 
-> **Last Updated:** 2026-04-01
+> **Last Updated:** 2026-04-07
 > **Router Source:** [`react/src/routes.tsx`](../react/src/routes.tsx)
 > **E2E Root:** [`e2e/`](.)
 >
@@ -22,9 +22,9 @@
 | Dashboard | `/dashboard` | 9 | 7 | 🔶 78% |
 | Session List | `/session` | 22 | 14 | 🔶 64% |
 | Session Launcher | `/session/start` | 14 | 3 | 🔶 21% |
-| Serving | `/serving` | 7 | 0 | ❌ 0% |
+| Serving | `/serving` | 7 | 2 | 🔶 29% |
 | Endpoint Detail | `/serving/:serviceId` | 20 | 9 | 🔶 45% |
-| Service Launcher | `/service/start` | 5 | 0 | ❌ 0% |
+| Service Launcher | `/service/start` | 5 | 1 | 🔶 20% |
 | VFolder / Data | `/data` | 45 | 32 | 🔶 71% |
 | Model Store | `/model-store` | 6 | 0 | ❌ 0% |
 | Storage Host | `/storage-settings/:hostname` | 3 | 0 | ❌ 0% |
@@ -222,7 +222,7 @@
 
 ### 6. Serving / Model Service (`/serving`)
 
-**Test files:** None (visual regression only: [`e2e/visual_regression/serving/serving_page.test.ts`](visual_regression/serving/serving_page.test.ts))
+**Test files:** [`e2e/serving/serving-deploy-lifecycle.spec.ts`](serving/serving-deploy-lifecycle.spec.ts) (integration, `@integration @serving`)
 
 **Filter:** Active | Destroyed (radio)
 **Primary action:** "Start Service" → navigates to `/service/start`
@@ -231,15 +231,15 @@
 
 | Feature | Status | Test |
 | --------------------------------------------------------- | ------ | ---- |
-| Endpoint list rendering | ❌ | - |
+| Endpoint list rendering | ✅ | `Admin can deploy a model service via ServiceLauncher UI` (verifies row visible in serving list) |
 | "Start Service" → navigate to `/service/start` | ❌ | - |
 | Endpoint name click → EndpointDetailPage | ❌ | - |
 | Status filtering (Active/Destroyed) | ❌ | - |
 | Property filtering | ❌ | - |
 | Edit endpoint → navigate to `/service/update/:endpointId` | ❌ | - |
-| Delete endpoint → confirm dialog | ❌ | - |
+| Delete endpoint → confirm dialog | ✅ | `Admin can terminate a deployed service` |
 
-**Coverage: ❌ 0/7 features**
+**Coverage: 🔶 2/7 features**
 
 ---
 
@@ -280,17 +280,17 @@
 
 ### 8. Service Launcher (`/service/start`, `/service/update/:endpointId`)
 
-**Test files:** None
+**Test files:** [`e2e/serving/serving-deploy-lifecycle.spec.ts`](serving/serving-deploy-lifecycle.spec.ts) (integration, `@integration @serving`)
 
 | Feature | Status | Test |
 | ----------------------- | ------ | ---- |
-| Create model service | ❌ | - |
+| Create model service | ✅ | `Admin can deploy a model service via ServiceLauncher UI` |
 | Update existing service | ❌ | - |
 | Resource configuration | ❌ | - |
 | Model folder selection | ❌ | - |
 | Form validation | ❌ | - |
 
-**Coverage: ❌ 0/5 features**
+**Coverage: 🔶 1/5 features**
 
 ---
 

e2e/serving/fixtures/model-definition.yaml

@@ -8,5 +8,4 @@ models:
       port: 8000
       health_check:
         path: /health
-        initial_delay: 5.0
         max_retries: 10

e2e/serving/serving-deploy-lifecycle.spec.ts

@@ -191,6 +191,33 @@ async function createServiceViaUI(
     .first()
     .click({ timeout: 10000 });
 
+  // Set AI Accelerator to 0 to avoid GPU-based allocation presets.
+  // When the resource group has a GPU preset selected by default (e.g. cuda01-small),
+  // service creation would fail if no GPU agents are available.
+  // Setting the accelerator count to 0 ensures CPU-only resource allocation.
+  //
+  // Strategy: Find the AI Accelerator form item by its label text, then target
+  // the spinbutton inside it. Ant Design Form.Item uses a `label` element that
+  // may not have a `for` attribute in all versions, so we use a compound selector.
+  const acceleratorFormItem = page
+    .locator('.ant-form-item')
+    .filter({ hasText: 'AI Accelerator' })
+    .first();
+  const acceleratorSpinbutton = acceleratorFormItem.getByRole('spinbutton');
+  if (
+    await acceleratorSpinbutton.isVisible({ timeout: 5000 }).catch(() => false)
+  ) {
+    // Scroll into view first to ensure the element is interactable
+    await acceleratorSpinbutton.scrollIntoViewIfNeeded();
+    // Triple-click to select all content, then type the new value
+    await acceleratorSpinbutton.click({ clickCount: 3 });
+    await acceleratorSpinbutton.fill('0');
+    // Trigger change event so form updates allocationPreset to 'custom'
+    await acceleratorSpinbutton.press('Tab');
+    // Wait briefly for form to react to the change
+    await page.waitForTimeout(500);
+  }
+
   // Check "Open To Public"
   const openToPublicCheckbox = page.getByLabel('Open To Public');
   await openToPublicCheckbox.scrollIntoViewIfNeeded();
@@ -205,8 +232,10 @@ async function createServiceViaUI(
   await expect(createButton).toBeEnabled({ timeout: 5000 });
   await createButton.click();
 
-  // Wait for redirect to serving page and verify the service appears
-  await page.waitForURL('**/serving', { timeout: 15000 });
+  // Wait for the service creation to complete.
+  // The form navigates to /serving on success or stays on /service/start on error.
+  await page.waitForURL('**/serving', { timeout: 30000 });
+
   await expect(
     page.getByRole('row').filter({ hasText: serviceName }).first(),
   ).toBeVisible({ timeout: 15000 });

e2e/utils/test-util.ts

@@ -715,6 +715,57 @@ function tomlStringifyCompatible(config: any): string {
   return tomlStr;
 }
 
+/**
+ * Pre-process a TOML string to remove duplicate keys within each section.
+ * Some server configurations may have duplicate keys (e.g., `debug = true`
+ * duplicated keys (e.g., `debug = true` appearing twice under [general]).
+ * @returns A deduplicated TOML string safe for strict parsers
+ */
+function deduplicateTomlKeys(tomlStr: string): string {
+  const lines = tomlStr.split('\n');
+  // Collect lines per section, tracking the last definition of each key
+  type SectionEntry = { key: string; lineIndex: number };
+  const sections: { header: string; entries: SectionEntry[] }[] = [
+    { header: '', entries: [] },
+  ];
+
+  let currentSection = sections[0];
+
+  for (let i = 0; i < lines.length; i++) {
+    const line = lines[i];
+    const trimmed = line.trim();
+
+    // New section header
+    if (trimmed.startsWith('[') && !trimmed.startsWith('[[')) {
+      currentSection = { header: trimmed, entries: [] };
+      sections.push(currentSection);
+      continue;
+    }
+
+    // Skip comments and empty lines — they don't need deduplication
+    if (!trimmed || trimmed.startsWith('#')) {
+      continue;
+    }
+
+    // Extract the key part (before the first '=')
+    const eqIdx = trimmed.indexOf('=');
+    if (eqIdx === -1) continue;
+    const key = trimmed.substring(0, eqIdx).trim();
+
+    // Track the last line index seen for this key
+    const existing = currentSection.entries.find((e) => e.key === key);
+    if (existing) {
+      // Mark previous occurrence for removal
+      lines[existing.lineIndex] = null as unknown as string;
+      existing.lineIndex = i;
+    } else {
+      currentSection.entries.push({ key, lineIndex: i });
+    }
+  }
+
+  return lines.filter((l) => l !== null).join('\n');
+}
+
 // Store the accumulated config modifications in a WeakMap keyed by page
 const configCache = new WeakMap<Page, any>();
 
@@ -751,7 +802,11 @@ export async function modifyConfigToml(
           if (!res.ok) throw new Error(`HTTP ${res.status}`);
           return res.text();
         });
-        config = TOML.parse(configToml);
+        // Pre-process TOML to remove duplicate keys before parsing.
+        // Some server configurations may have duplicate keys (e.g., debug = true
+        // appearing twice under [general]) which strict TOML parsers reject.
+        const deduplicatedToml = deduplicateTomlKeys(configToml);
+        config = TOML.parse(deduplicatedToml);
         break; // Success, exit retry loop
       } catch (error) {
         lastError = error;