e2e(FR-2472): fix model-card-v2 flag persistence and serving submit resilience

Author: ironAiken2

e2e/E2E_COVERAGE_REPORT.md

@@ -22,9 +22,9 @@
 | Dashboard | `/dashboard` | 9 | 7 | 🔶 78% |
 | Session List | `/session` | 22 | 14 | 🔶 64% |
 | Session Launcher | `/session/start` | 14 | 3 | 🔶 21% |
-| Serving | `/serving` | 7 | 0 | ❌ 0% |
+| Serving | `/serving` | 7 | 2 | 🔶 29% |
 | Endpoint Detail | `/serving/:serviceId` | 20 | 9 | 🔶 45% |
-| Service Launcher | `/service/start` | 5 | 0 | ❌ 0% |
+| Service Launcher | `/service/start` | 5 | 1 | 🔶 20% |
 | VFolder / Data | `/data` | 45 | 32 | 🔶 71% |
 | Model Store | `/model-store` | 6 | 6 | ✅ 100% |
 | Admin Model Store | `/admin-model-store` | 22 | 22 | ✅ 100% |
@@ -46,7 +46,11 @@
 | App Launcher | (modal) | 18 | 10 | 🔶 56% |
 | Chat | `/chat/:id?` | 6 | 6 | ✅ 100% |
 | Plugin System | (config-based) | 12 | 12 | ✅ 100% |
+<<<<<<< HEAD
 | **Total** | | **357** | **204** | **57%** |
+=======
+| **Total** | | **372** | **228** | **61%** |
+>>>>>>> a3f2e0fba (e2e(FR-2472): align route table test with current BAIRouteNodes columns)
 
 ---
 
@@ -223,7 +227,7 @@
 
 ### 6. Serving / Model Service (`/serving`)
 
-**Test files:** None (visual regression only: [`e2e/visual_regression/serving/serving_page.test.ts`](visual_regression/serving/serving_page.test.ts))
+**Test files:** [`e2e/serving/serving-deploy-lifecycle.spec.ts`](serving/serving-deploy-lifecycle.spec.ts) (integration, `@integration @serving`)
 
 **Filter:** Active | Destroyed (radio)
 **Primary action:** "Start Service" → navigates to `/service/start`
@@ -232,15 +236,15 @@
 
 | Feature | Status | Test |
 | --------------------------------------------------------- | ------ | ---- |
-| Endpoint list rendering | ❌ | - |
+| Endpoint list rendering | ✅ | `Admin can deploy a model service via ServiceLauncher UI` (verifies row visible in serving list) |
 | "Start Service" → navigate to `/service/start` | ❌ | - |
 | Endpoint name click → EndpointDetailPage | ❌ | - |
 | Status filtering (Active/Destroyed) | ❌ | - |
 | Property filtering | ❌ | - |
 | Edit endpoint → navigate to `/service/update/:endpointId` | ❌ | - |
-| Delete endpoint → confirm dialog | ❌ | - |
+| Delete endpoint → confirm dialog | ✅ | `Admin can terminate a deployed service` |
 
-**Coverage: ❌ 0/7 features**
+**Coverage: 🔶 2/7 features**
 
 ---
 
@@ -281,17 +285,17 @@
 
 ### 8. Service Launcher (`/service/start`, `/service/update/:endpointId`)
 
-**Test files:** None
+**Test files:** [`e2e/serving/serving-deploy-lifecycle.spec.ts`](serving/serving-deploy-lifecycle.spec.ts) (integration, `@integration @serving`)
 
 | Feature | Status | Test |
 | ----------------------- | ------ | ---- |
-| Create model service | ❌ | - |
+| Create model service | ✅ | `Admin can deploy a model service via ServiceLauncher UI` |
 | Update existing service | ❌ | - |
 | Resource configuration | ❌ | - |
 | Model folder selection | ❌ | - |
 | Form validation | ❌ | - |
 
-**Coverage: ❌ 0/5 features**
+**Coverage: 🔶 1/5 features**
 
 ---
 

e2e/serving/endpoint-route-table.spec.ts

@@ -137,11 +137,11 @@ test.describe(
       await expect(
         card.getByRole('columnheader', { name: 'Status', exact: true }),
       ).toBeVisible();
+      // TODO(needs-backend): Re-enable when BAIRouteNodes exposes the Traffic
+      // Status column. It is currently commented out in BAIRouteNodes.tsx
+      // pending backend support for per-route traffic status (FR-2591).
       await expect(
-        card.getByRole('columnheader', { name: 'Traffic Status' }),
-      ).toBeVisible();
-      await expect(
-        card.getByRole('columnheader', { name: 'Traffic Ratio' }),
+        card.getByRole('columnheader', { name: 'Created At' }),
       ).toBeVisible();
     });
 
@@ -305,7 +305,11 @@ test.describe(
     // 3. Property Filter
     // ─────────────────────────────────────────────────────────────────────────
 
-    test('3.1 Admin can see the Traffic Status filter property in the property filter selector', async ({
+    // TODO(needs-backend): Re-enable when the EndpointDetailPage route property
+    // filter exposes a "Traffic Status" option. The filter is currently only
+    // populated with Health Status, pending backend support for per-route
+    // traffic status (FR-2591).
+    test.fixme('3.1 Admin can see the Traffic Status filter property in the property filter selector', async ({
       page,
       request,
     }) => {
@@ -325,7 +329,9 @@ test.describe(
       await page.keyboard.press('Escape');
     });
 
-    test('3.2 Admin can filter routes by trafficStatus ACTIVE using the property filter', async ({
+    // TODO(needs-backend): Re-enable when the route property filter exposes a
+    // "Traffic Status" option (FR-2591).
+    test.fixme('3.2 Admin can filter routes by trafficStatus ACTIVE using the property filter', async ({
       page,
       request,
     }) => {
@@ -358,7 +364,9 @@ test.describe(
       await expect(filterTag.first()).toBeVisible();
     });
 
-    test('3.3 Admin can filter routes by trafficStatus INACTIVE using the property filter', async ({
+    // TODO(needs-backend): Re-enable when the route property filter exposes a
+    // "Traffic Status" option (FR-2591).
+    test.fixme('3.3 Admin can filter routes by trafficStatus INACTIVE using the property filter', async ({
       page,
       request,
     }) => {
@@ -391,7 +399,11 @@ test.describe(
       await expect(filterTag.first()).toBeVisible();
     });
 
-    test('3.4 Admin can remove an applied filter to restore the full route list', async ({
+    // TODO(needs-backend): Re-enable when the route property filter exposes a
+    // "Traffic Status" option (FR-2591). The underlying remove-filter behavior
+    // is covered indirectly via the Health Status filter once BAIRouteNodes
+    // supports a secondary filter.
+    test.fixme('3.4 Admin can remove an applied filter to restore the full route list', async ({
       page,
       request,
     }) => {
@@ -451,11 +463,10 @@ test.describe(
       await expect(
         card.getByRole('columnheader', { name: 'Status', exact: true }),
       ).toBeVisible();
+      // TODO(needs-backend): Re-enable when BAIRouteNodes exposes the Traffic
+      // Status column (FR-2591).
       await expect(
-        card.getByRole('columnheader', { name: 'Traffic Status' }),
-      ).toBeVisible();
-      await expect(
-        card.getByRole('columnheader', { name: 'Traffic Ratio' }),
+        card.getByRole('columnheader', { name: 'Created At' }),
       ).toBeVisible();
     });
 
@@ -474,9 +485,8 @@ test.describe(
         .first();
       await expect(healthyTag).toBeVisible();
 
-      // Verify ACTIVE traffic status tag
-      const activeTag = card.locator('.ant-tag').filter({ hasText: 'ACTIVE' });
-      await expect(activeTag.first()).toBeVisible();
+      // TODO(needs-backend): Re-enable ACTIVE traffic-status tag assertion
+      // once BAIRouteNodes exposes the Traffic Status column (FR-2591).
     });
 
     test('4.3 Admin sees a PROVISIONING route with a processing-colored status tag', async ({
@@ -507,7 +517,9 @@ test.describe(
       await expect(unhealthyTag).toBeVisible();
     });
 
-    test('4.5 Admin sees INACTIVE traffic status tags displayed', async ({
+    // TODO(needs-backend): Re-enable when BAIRouteNodes exposes the Traffic
+    // Status column. INACTIVE tags render inside that column (FR-2591).
+    test.fixme('4.5 Admin sees INACTIVE traffic status tags displayed', async ({
       page,
       request,
     }) => {
@@ -522,7 +534,10 @@ test.describe(
       await expect(inactiveTags.first()).toBeVisible();
     });
 
-    test('4.6 Admin sees the traffic ratio value in the Traffic Ratio column', async ({
+    // TODO(needs-backend): Re-enable when BAIRouteNodes exposes the Traffic Ratio
+    // column. It is currently commented out in BAIRouteNodes.tsx pending backend
+    // support for per-route traffic ratio.
+    test.fixme('4.6 Admin sees the traffic ratio value in the Traffic Ratio column', async ({
       page,
       request,
     }) => {
@@ -720,21 +735,22 @@ test.describe(
       ).toBeVisible();
     });
 
-    test('7.2 Admin can sort routes by Traffic Ratio column', async ({
+    // TODO(needs-backend): Re-enable when BAIRouteNodes exposes the Traffic Ratio
+    // column. It is currently commented out in BAIRouteNodes.tsx pending backend
+    // support for per-route traffic ratio.
+    test.fixme('7.2 Admin can sort routes by Traffic Ratio column', async ({
       page,
       request,
     }) => {
       await setupAndNavigateToDetail(page, request);
 
       const card = getRoutesInfoCard(page);
 
-      // Click the "Traffic Ratio" column header to sort
       const trafficRatioHeader = card.getByRole('columnheader', {
         name: 'Traffic Ratio',
       });
       await trafficRatioHeader.click();
 
-      // Verify a sort indicator is shown
       await expect(
         trafficRatioHeader.locator('.ant-table-column-sorter'),
       ).toBeVisible();

e2e/serving/fixtures/model-definition.yaml

@@ -8,5 +8,4 @@ models:
       port: 8000
       health_check:
         path: /health
-        initial_delay: 5.0
         max_retries: 10

e2e/serving/mocking/model-store-mock.ts

@@ -288,6 +288,20 @@ const EMPTY_TOKEN_LIST = {
   items: [],
 };
 
+/**
+ * Shared minimal `modelDeployment` node used by EndpointDetailPage mocks. The
+ * page reads `modelDeployment.metadata.status` as the single source of truth
+ * for `isDeploymentDeploying` / `hasAnyHealthyRoute` when the `model-card-v2`
+ * feature flag is injected by the tests.
+ */
+const buildModelDeployment = (
+  status: 'DEPLOYING' | 'READY' | 'TERMINATED',
+) => ({
+  metadata: { status },
+  currentRevision: null,
+  revisionHistory: { edges: [] },
+});
+
 /**
  * Mock for EndpointDetailPageQuery — "Preparing your service" state.
  * replicas=1, deploymentScopedSchedulingHistories.count=0 → hasReachedReady=false.
@@ -305,6 +319,7 @@ export function endpointDetailPreparingMockResponse() {
     routes: { edges: [], count: 0 },
     healthyRoutes: { count: 0 },
     deploymentScopedSchedulingHistories: { count: 0 },
+    modelDeployment: buildModelDeployment('DEPLOYING'),
   });
 }
 
@@ -324,6 +339,7 @@ export function endpointDetailZeroReplicasMockResponse() {
     routes: { edges: [], count: 0 },
     healthyRoutes: { count: 0 },
     deploymentScopedSchedulingHistories: { count: 0 },
+    modelDeployment: buildModelDeployment('DEPLOYING'),
   });
 }
 
@@ -343,6 +359,7 @@ export function endpointDetailTerminatedMockResponse() {
     routes: { edges: [], count: 0 },
     healthyRoutes: { count: 0 },
     deploymentScopedSchedulingHistories: { count: 0 },
+    modelDeployment: buildModelDeployment('TERMINATED'),
   });
 }
 
@@ -363,6 +380,7 @@ export function endpointDetailServiceReadyMockResponse() {
     routes: { edges: [], count: 0 },
     healthyRoutes: { count: 1 },
     deploymentScopedSchedulingHistories: { count: 1 },
+    modelDeployment: buildModelDeployment('READY'),
   });
 }
 
@@ -383,6 +401,7 @@ export function endpointDetailHealthyButNoSchedulingHistoryMockResponse() {
     routes: { edges: [], count: 0 },
     healthyRoutes: { count: 1 },
     deploymentScopedSchedulingHistories: { count: 0 },
+    modelDeployment: buildModelDeployment('READY'),
   });
 }
 
@@ -402,5 +421,8 @@ export function endpointDetailReadyButNoHealthyRoutesMockResponse() {
     routes: { edges: [], count: 0 },
     healthyRoutes: { count: 0 },
     deploymentScopedSchedulingHistories: { count: 1 },
+    // No healthy routes → hasAnyHealthyRoute=false; use non-READY status so
+    // the "Service Ready" alert is suppressed.
+    modelDeployment: buildModelDeployment('DEPLOYING'),
   });
 }