refactor(FR-2479): standardize confirmation UX with BAIConfirmModalWithInput and Popconfirm#6471
refactor(FR-2479): standardize confirmation UX with BAIConfirmModalWithInput and Popconfirm#6471ironAiken2 wants to merge 1 commit intomainfrom
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.64% (-0% 🔻) |
1738/20107 |
| 🔴 | Branches | 7.84% (-0.01% 🔻) |
1104/14085 |
| 🔴 | Functions | 5.19% (-0% 🔻) |
283/5453 |
| 🔴 | Lines | 8.35% (-0% 🔻) |
1630/19522 |
Test suite run success
847 tests passing in 38 suites.
Report generated by 🧪jest coverage report action from 500a0f7
There was a problem hiding this comment.
Pull request overview
This PR standardizes destructive-action confirmations across the WebUI by migrating modal.confirm() usage to BAIConfirmModalWithInput (typed-input confirmations) and switching TOTP deactivation confirmations to inline Popconfirm, while removing the now-orphaned PopConfirmWithInput component.
Changes:
- Replaced several destructive
modal.confirm()flows withBAIConfirmModalWithInputacross agents, endpoints, resource presets, shell scripts, and image modification modals. - Converted TOTP “turn off” confirmation from modal-based confirm to inline
Popconfirmin two settings modals. - Deleted the unused
PopConfirmWithInput.tsxcomponent.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| react/src/pages/AIAgentPage.tsx | Replace agent delete/reset confirmation with typed-input confirm modal. |
| react/src/components/EndpointList.tsx | Replace endpoint deletion confirmation with typed-input confirm modal. |
| react/src/components/ResourcePresetList.tsx | Replace resource preset deletion confirmation with typed-input confirm modal. |
| react/src/components/ShellScriptEditModal.tsx | Replace script deletion confirmation with typed-input confirm modal. |
| react/src/components/ManageAppsModal.tsx | Add typed-input confirmation when installed image modifications require reinstall. |
| react/src/components/ManageImageResourceLimitModal.tsx | Add typed-input confirmation when installed image resource limit changes require reinstall. |
| react/src/components/UserSettingModal.tsx | Switch TOTP deactivation confirmation to inline Popconfirm. |
| react/src/components/UserProfileSettingModal.tsx | Switch TOTP deactivation confirmation to inline Popconfirm. |
| react/src/components/PopConfirmWithInput.tsx | Remove orphaned duplicate confirmation component. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
1c059ee to
a070324
Compare
a070324 to
123e214
Compare
123e214 to
f0b926a
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 81.87% | 429/524 |
| 🟡 | Branches | 70.43% | 362/514 |
| 🟡 | Functions | 76.86% | 93/121 |
| 🟢 | Lines | 83.19% | 391/470 |
Test suite run success
319 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from 500a0f7
nowgnuesLee
left a comment
There was a problem hiding this comment.
If this is our policy going forward, could you add it to .claude/rules?
c44153a to
91cef6f
Compare
…thInput and Popconfirm
91cef6f to
500a0f7
Compare

Resolves #6437 (FR-2479)
Summary
modal.confirm()toBAIConfirmModalWithInput(typed-input confirmation)ResourcePresetList.tsx— preset deletionEndpointList.tsx— endpoint deletionShellScriptEditModal.tsx— script deletionAIAgentPage.tsx— agent deletion and resetManageAppsModal.tsx— image reinstallation confirmationManageImageResourceLimitModal.tsx— image reinstallation confirmationmodal.confirm()toPopconfirmUserSettingModal.tsx— TOTP deactivation toggleUserProfileSettingModal.tsx— TOTP deactivation togglePopConfirmWithInput.tsx(0 imports)Test plan
PopConfirmWithInput.tsxis removed