refactor(FR-2479): standardize confirmation UX with BAIConfirmModalWithInput and Popconfirm#6471
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 23, 2026
Conversation
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.59% | 1757/20454 |
| 🔴 | Branches | 7.87% | 1131/14373 |
| 🔴 | Functions | 5.14% | 285/5546 |
| 🔴 | Lines | 8.31% | 1649/19844 |
Test suite run success
856 tests passing in 39 suites.
Report generated by 🧪jest coverage report action from 262823e
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes destructive-action confirmations across the WebUI by migrating modal.confirm() usage to BAIConfirmModalWithInput (typed-input confirmations) and switching TOTP deactivation confirmations to inline Popconfirm, while removing the now-orphaned PopConfirmWithInput component.
Changes:
- Replaced several destructive
modal.confirm()flows withBAIConfirmModalWithInputacross agents, endpoints, resource presets, shell scripts, and image modification modals. - Converted TOTP “turn off” confirmation from modal-based confirm to inline
Popconfirmin two settings modals. - Deleted the unused
PopConfirmWithInput.tsxcomponent.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| react/src/pages/AIAgentPage.tsx | Replace agent delete/reset confirmation with typed-input confirm modal. |
| react/src/components/EndpointList.tsx | Replace endpoint deletion confirmation with typed-input confirm modal. |
| react/src/components/ResourcePresetList.tsx | Replace resource preset deletion confirmation with typed-input confirm modal. |
| react/src/components/ShellScriptEditModal.tsx | Replace script deletion confirmation with typed-input confirm modal. |
| react/src/components/ManageAppsModal.tsx | Add typed-input confirmation when installed image modifications require reinstall. |
| react/src/components/ManageImageResourceLimitModal.tsx | Add typed-input confirmation when installed image resource limit changes require reinstall. |
| react/src/components/UserSettingModal.tsx | Switch TOTP deactivation confirmation to inline Popconfirm. |
| react/src/components/UserProfileSettingModal.tsx | Switch TOTP deactivation confirmation to inline Popconfirm. |
| react/src/components/PopConfirmWithInput.tsx | Remove orphaned duplicate confirmation component. |
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ironAiken2
force-pushed
the
refactor/issue-6437-standardize-confirmation-ux
branch
2 times, most recently
from
1c059ee to
a070324
Compare
ironAiken2
force-pushed
the
refactor/issue-6437-standardize-confirmation-ux
branch
from
a070324 to
123e214
Compare
ironAiken2
force-pushed
the
refactor/issue-6437-standardize-confirmation-ux
branch
from
123e214 to
f0b926a
Compare
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 81.87% | 429/524 |
| 🟡 | Branches | 70.43% | 362/514 |
| 🟡 | Functions | 76.86% | 93/121 |
| 🟢 | Lines | 83.19% | 391/470 |
Test suite run success
319 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from 262823e
nowgnuesLee
requested changes
Apr 9, 2026
nowgnuesLee
requested changes
Apr 9, 2026
Contributor
nowgnuesLee
left a comment
nowgnuesLee
left a comment
There was a problem hiding this comment.
If this is our policy going forward, could you add it to .claude/rules?
ironAiken2
force-pushed
the
refactor/issue-6437-standardize-confirmation-ux
branch
2 times, most recently
from
c44153a to
91cef6f
Compare
ironAiken2
force-pushed
the
refactor/issue-6437-standardize-confirmation-ux
branch
from
91cef6f to
500a0f7
Compare
ironAiken2
force-pushed
the
refactor/issue-6437-standardize-confirmation-ux
branch
2 times, most recently
from
bbba0b0 to
f8d187e
Compare
agatha197
reviewed
Apr 22, 2026
ironAiken2
force-pushed
the
refactor/issue-6437-standardize-confirmation-ux
branch
from
f8d187e to
3954766
Compare
Contributor
Author
|
@nowgnuesLee Addressed — added |
Merge activity
|
…thInput and Popconfirm (#6471) Resolves #6437 (FR-2479) ## Summary - **Phase 1**: Upgrade 6 destructive actions from `modal.confirm()` to `BAIConfirmModalWithInput` (typed-input confirmation) - `ResourcePresetList.tsx` — preset deletion - `EndpointList.tsx` — endpoint deletion - `ShellScriptEditModal.tsx` — script deletion - `AIAgentPage.tsx` — agent deletion and reset - `ManageAppsModal.tsx` — image reinstallation confirmation - `ManageImageResourceLimitModal.tsx` — image reinstallation confirmation - **Phase 2**: Convert 2 TOTP toggle confirmations from `modal.confirm()` to `Popconfirm` - `UserSettingModal.tsx` — TOTP deactivation toggle - `UserProfileSettingModal.tsx` — TOTP deactivation toggle - **Phase 3**: Remove orphaned `PopConfirmWithInput.tsx` (0 imports) ## Test plan - [ ] Delete a resource preset — typed confirmation modal appears, must type preset name - [ ] Delete an endpoint — typed confirmation modal appears, must type endpoint name - [ ] Delete a shell script — typed confirmation modal appears - [ ] Delete/reset an AI agent — typed confirmation modal appears - [ ] Modify apps on installed image — typed confirmation modal appears - [ ] Modify resource limits on installed image — typed confirmation modal appears - [ ] Toggle TOTP off (UserSettingModal) — Popconfirm appears inline - [ ] Toggle TOTP off (UserProfileSettingModal) — Popconfirm appears inline - [ ] Verify `PopConfirmWithInput.tsx` is removed
graphite-app
Bot
force-pushed
the
refactor/issue-6437-standardize-confirmation-ux
branch
from
3954766 to
262823e
Compare
graphite-app
Bot
deleted the
refactor/issue-6437-standardize-confirmation-ux
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6437 (FR-2479)
Summary
modal.confirm()toBAIConfirmModalWithInput(typed-input confirmation)ResourcePresetList.tsx— preset deletionEndpointList.tsx— endpoint deletionShellScriptEditModal.tsx— script deletionAIAgentPage.tsx— agent deletion and resetManageAppsModal.tsx— image reinstallation confirmationManageImageResourceLimitModal.tsx— image reinstallation confirmationmodal.confirm()toPopconfirmUserSettingModal.tsx— TOTP deactivation toggleUserProfileSettingModal.tsx— TOTP deactivation togglePopConfirmWithInput.tsx(0 imports)Test plan
PopConfirmWithInput.tsxis removed