fix(FR-2502): allow admin to see all vfolders across projects/domains#6525
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 10, 2026
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 9, 2026
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 9.1% | 1750/19237 |
| 🔴 | Branches | 8.17% | 1100/13456 |
| 🔴 | Functions | 5.51% | 288/5231 |
| 🔴 | Lines | 8.78% | 1641/18689 |
Test suite run success
854 tests passing in 39 suites.
Report generated by 🧪jest coverage report action from f34a79a
graphite-app
Bot
changed the base branch from
04-07-fix_fr-2476_add_missing_permission_argument_to_admin_vfolder_queries
to
graphite-base/6525
graphite-app
Bot
force-pushed
the
graphite-base/6525
branch
from
a26a287 to
9f3cb82
Compare
graphite-app
Bot
force-pushed
the
04-09-fix_fr-2502_allow_admin_to_see_all_vfolders_across_projects_domains
branch
from
b55c07a to
6f93712
Compare
graphite-app
Bot
force-pushed
the
04-09-fix_fr-2502_allow_admin_to_see_all_vfolders_across_projects_domains
branch
from
6f93712 to
956744d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the domain-scoped restriction from the admin vfolder list query so superadmins can view vfolders across all projects/domains on /admin-data.
Changes:
- Dropped
scope_idfrom thevfolder_nodesRelay query (main list + active/deleted counts). - Removed the now-unused
useCurrentDomainValueimport anddomainNamelocal variable. - Added an inline comment documenting that omitting
scope_idis intentional for superadmin visibility.
Merge activity
|
…#6525) Resolves #6524 (FR-2502) ## Summary - `AdminVFolderNodeListPage` was restricted to the current domain via `scope_id: domain:${domainName}`, so superadmin could only see folders owned by themselves and not vfolders created by other users - Remove `scope_id` from the admin query (all three `vfolder_nodes` calls: main list, active count, deleted count) so superadmin sees all vfolders across projects/domains - Matches the existing pattern in `AdminComputeSessionListPage` which intentionally omits `scope_id` for the same reason - Drop the now-unused `useCurrentDomainValue` import and `domainName` local ## Stack Depends on #6467 (FR-2476), which adds `permission: read_attribute` to the same queries. The permission fix alone does not make other users' folders visible; removing the domain scope is also required. ## Test plan - [ ] `/admin-data` page shows vfolders owned by other users (across all projects/domains) - [ ] Active and deleted folder tab counts reflect all vfolders - [ ] Existing filters (name/status/type/permission/usage mode) still work ## Verification ``` === Relay: PASS === === Lint: PASS === === Format: PASS === === TypeScript: PASS === === ALL PASS === ```
graphite-app
Bot
force-pushed
the
04-09-fix_fr-2502_allow_admin_to_see_all_vfolders_across_projects_domains
branch
from
956744d to
f34a79a
Compare
graphite-app
Bot
deleted the
04-09-fix_fr-2502_allow_admin_to_see_all_vfolders_across_projects_domains
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6524 (FR-2502)
Summary
AdminVFolderNodeListPagewas restricted to the current domain viascope_id: domain:${domainName}, so superadmin could only see folders owned by themselves and not vfolders created by other usersscope_idfrom the admin query (all threevfolder_nodescalls: main list, active count, deleted count) so superadmin sees all vfolders across projects/domainsAdminComputeSessionListPagewhich intentionally omitsscope_idfor the same reasonuseCurrentDomainValueimport anddomainNamelocalStack
Depends on #6467 (FR-2476), which adds
permission: read_attributeto the same queries. The permission fix alone does not make other users' folders visible; removing the domain scope is also required.Test plan
/admin-datapage shows vfolders owned by other users (across all projects/domains)Verification