e2e(FR-2504): add E2E tests for RBAC role management#6531
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
Adds Playwright E2E coverage for the RBAC Role Management UI (/rbac) in Backend.AI WebUI, focusing on role list interactions, role lifecycle operations, and role detail drawer actions.
Changes:
- Added role list-view E2E tests (table render, status toggling, search, sort, refresh).
- Added role CRUD E2E tests (create, edit, deactivate/activate, purge; with a WIP duplicate-name case).
- Added role detail-drawer E2E tests (open/close, permissions management, user assignments).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
e2e/rbac/rbac-role-list.spec.ts |
Covers /rbac list view behaviors: rendering, filters/search, sorting, refresh. |
e2e/rbac/rbac-role-crud.spec.ts |
Covers role CRUD lifecycle flows end-to-end against the UI. |
e2e/rbac/rbac-role-detail.spec.ts |
Covers role detail drawer interactions, permission creation/deletion, and user assignment/revocation. |
36c1d43 to
56ea373
Compare
b3a7cdc to
6d11050
Compare
6d11050 to
9dd2988
Compare
agatha197
left a comment
There was a problem hiding this comment.
When I tested it, I failed
RBAC Role Permissions Management
tests due to permission selection failing.
9dd2988 to
a1d4ca9
Compare
Just fixed :) |
a1d4ca9 to
1d8f21f
Compare
agatha197
left a comment
There was a problem hiding this comment.
4 failed
[chromium] › e2e/rbac/rbac-role-crud.spec.ts:56:9 › RBAC Role CRUD › Superadmin can create a new custom role with name and description @rbac @critical @functional
[chromium] › e2e/rbac/rbac-role-detail.spec.ts:158:9 › RBAC Role Detail Drawer › Drawer shows "Role Assignments" and "Permissions" tabs @rbac @critical @functional
[chromium] › e2e/rbac/rbac-role-detail.spec.ts:262:9 › RBAC Role Permissions Management › Superadmin can add a permission to a role @rbac @critical @functional
[chromium] › e2e/rbac/rbac-role-detail.spec.ts:559:9 › RBAC Role Assignments Management › Superadmin can assign a user to a role @rbac @critical @functional
almost done! can you check again?
1d8f21f to
71dbe79
Compare
71dbe79 to
d8fa2b1
Compare
e4675bb to
26990f9
Compare
|
@agatha197 Addressed the 4 failing tests via the stacked PR #6882 + test updates on this branch: Schema alignment (PR #6882, parent in the stack)
Test updates on this PR
Could you re-run the failing specs once more? Thanks! |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.6% | 1757/20437 |
| 🔴 | Branches | 7.89% | 1131/14338 |
| 🔴 | Functions | 5.14% | 285/5545 |
| 🔴 | Lines | 8.32% | 1649/19831 |
Test suite run success
856 tests passing in 39 suites.
Report generated by 🧪jest coverage report action from 17f951c
26990f9 to
db84a8e
Compare
d8fa2b1 to
c8db424
Compare
c8db424 to
af02bfd
Compare
Merge activity
|
Resolves #6530 ([FR-2504](https://lablup.atlassian.net/browse/FR-2504)) ## Summary - Add E2E tests for RBAC role CRUD lifecycle (create, edit, rename, deactivate, delete) - Add E2E tests for RBAC role list view (table rendering, filtering, sorting, pagination) - Add E2E tests for RBAC role detail drawer (permissions management, user assignments, edge cases) ## Test plan - [ ] Run `npx playwright test e2e/rbac/` against a Backend.AI cluster with RBAC enabled - [ ] Verify all 3 spec files pass: `rbac-role-crud`, `rbac-role-list`, `rbac-role-detail` [FR-2504]: https://lablup.atlassian.net/browse/FR-2504?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
af02bfd to
17f951c
Compare

Resolves #6530 (FR-2504)
Summary
Test plan
npx playwright test e2e/rbac/against a Backend.AI cluster with RBAC enabledrbac-role-crud,rbac-role-list,rbac-role-detail