docs(FR-2534): add 2FA/TOTP, SSO, and session extension to login documentation by nowgnuesLee · Pull Request #6572 · lablup/backend.ai-webui

nowgnuesLee · 2026-04-10T02:12:26Z

Resolves #6678 (FR-2534)

Summary

Document 2FA/TOTP authentication setup and verification flow
Document SSO (Keycloak) login via the "Login with Keycloak" button
Document session extension for users approaching session timeout
Add a note about concurrent session detection and automatic logout behavior
Apply reviewer fixes for accuracy and consistency across all 4 languages

Changes

login/login.md (en/ko/ja/th): 2FA/TOTP section, SSO section, session extension section, concurrent session note

Test plan

Verify 2FA setup steps match the actual TOTP flow
Verify SSO login button label matches the UI
Verify session extension notification behavior is accurately described

🤖 Generated with Claude Code

nowgnuesLee · 2026-04-10T02:12:38Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

nowgnuesLee

Review: PR #6572 — docs: add 2FA/TOTP, SSO, and session extension to login documentation

Summary

Good documentation update. The previously untranslated English remnants in JA/TH files (e.g., 管理者istrator, ผู้ดูแลระบบistrator) are now properly translated, and the new 2FA/TOTP/SSO sections are well-structured with correct structural parity across all 4 languages. A few issues below.

Findings

PR Title / Scope

[Correctness] Should Fix: The PR title mentions "session extension" but there is no session extension content anywhere in the diff. Please either add the session extension documentation or update the PR title to remove the claim.

[File: src/en/login/login.md]

[Correctness] Should Fix (L139-141): The forgot password section says:

click the Forgot password? text and then the Change link

But in the actual UI (LoginFormPanel.tsx L431-442), "Forgot password?" is a non-clickable Typography.Text label — only "Change" is the clickable Typography.Link. The documentation implies the user needs to click both elements. Please rewrite to something like:

click the Change link (next to "Forgot password?") on the login panel.

The same inaccuracy exists in all other language versions (KO, JA, TH) — same fix applies.

[File: src/en/login/login.md]

[i18n/UI Label] Nice to Have (L57): The doc says Click the **Advanced** link which matches the actual i18n key login.AdvancedSettings = "Advanced". Good.

[File: src/ko/login/login.md]

[i18n/UI Label] Nice to Have (L79): The doc says **비밀번호를 잊어버렸습니까?** — this matches the i18n value login.ForgotPassword = "비밀번호를 잊어버렸습니까?". Good.

[i18n/UI Label] Nice to Have: **비밀번호 재설정** matches login.ChangePassword = "비밀번호 재설정". Good.

[File: src/ja/login/login.md]

[i18n/UI Label] Nice to Have: **パスワードをお忘れですか？** matches login.ForgotPassword = "パスワードをお忘れですか？". **パスワードを変更する** matches login.ChangePassword = "パスワードを変更する". Good.

[File: src/th/login/login.md]

[i18n/UI Label] Nice to Have: **ลืมรหัสผ่าน?** matches login.ForgotPassword = "ลืมรหัสผ่าน?". **เปลี่ยน** matches login.ChangePassword = "เปลี่ยน". Good.

Cross-reference verification

[Correctness] Verified: The [2FA Setup](#2fa-setup) cross-reference links point to <a id="2fa-setup"></a> anchors that exist in all 4 language versions of header/header.md. No broken links.

Image verification

[Correctness] Verified: ask_otp_when_login.png exists in the images directory.

Feature verification against codebase

[Correctness] Verified: SSO (SAML/OpenID), OTP login, TOTP setup on first login, Connection Mode (Session/API), and API Endpoint configuration all match the actual implementation in LoginFormPanel.tsx, LoginView.tsx, ForceTOTPChecker.tsx, and TOTPActivateModal.tsx.

Recommendation

Approve with suggestions. Two items to address:

Should Fix: Remove "session extension" from the PR title, or add the missing content.
Should Fix: Fix the forgot password flow description across all 4 languages — "Forgot password?" is a label, not a clickable element.

agatha197

LGTM

This reverts commit d3ca954. #6575 was merged with base=main because `gt track --parent main` on a locally untracked branch caused Graphite to record main as its parent. The subsequent `gt submit --publish --force` pushed this base change to GitHub, and the PR was then squash merged, collapsing 29 commits from 6 stacked PRs into a single commit on main: - #6570 docs(FR-2532): share_vfolder labels - #6571 docs(FR-2533): user_settings - #6572 docs(FR-2534): 2FA/TOTP/SSO login - #6573 docs(FR-2535): header session timer & menu - #6574 docs(FR-2536): Start From URL & announcement banner - #6575 docs(FR-2537): dashboard board customization & auto-refresh Reverting so each PR can be merged in its original stack order. After this revert merges: - #6575 will be reopened with its original base (#6574's branch) - #6625's base will be restored to #6611's branch - The other open PRs (#6570, #6571, #6572, #6573, #6574) retain their original bases and will be mergeable in stack order

graphite-app · 2026-04-17T09:53:08Z

Merge activity

Apr 17, 9:53 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 17, 9:57 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #6571.
Apr 17, 9:57 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #6571.
Apr 17, 10:10 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 17, 10:15 AM UTC: Merged by the Graphite merge queue.

…mentation (#6572) Resolves #6678 (FR-2534) ## Summary - Document **2FA/TOTP** authentication setup and verification flow - Document **SSO (Keycloak)** login via the "Login with Keycloak" button - Document **session extension** for users approaching session timeout - Add a note about concurrent session detection and automatic logout behavior - Apply reviewer fixes for accuracy and consistency across all 4 languages ## Changes - `login/login.md` (en/ko/ja/th): 2FA/TOTP section, SSO section, session extension section, concurrent session note ## Test plan - [ ] Verify 2FA setup steps match the actual TOTP flow - [ ] Verify SSO login button label matches the UI - [ ] Verify session extension notification behavior is accurately described 🤖 Generated with [Claude Code](https://claude.com/claude-code)

github-actions Bot assigned nowgnuesLee Apr 10, 2026

github-actions Bot added the size:L 100~500 LoC label Apr 10, 2026

nowgnuesLee mentioned this pull request Apr 10, 2026

docs(FR-2532): fix incorrect permission labels in share_vfolder documentation #6570

Merged

2 tasks

nowgnuesLee commented Apr 10, 2026

View reviewed changes

github-actions Bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Apr 10, 2026

nowgnuesLee force-pushed the 04-10-docs_add_2fa_totp_sso_and_session_extension_to_login_documentation branch from e9ad2f4 to 316a216 Compare April 10, 2026 09:25

nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from 7d08cb3 to 0f0a17f Compare April 10, 2026 09:25

github-actions Bot added size:S 10~30 LoC and removed size:XL 500~ LoC labels Apr 10, 2026

nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from 0f0a17f to bbd0558 Compare April 11, 2026 03:46

nowgnuesLee force-pushed the 04-10-docs_add_2fa_totp_sso_and_session_extension_to_login_documentation branch from 316a216 to 269a642 Compare April 11, 2026 03:46

github-actions Bot added size:L 100~500 LoC and removed size:S 10~30 LoC labels Apr 11, 2026

nowgnuesLee force-pushed the 04-10-docs_add_2fa_totp_sso_and_session_extension_to_login_documentation branch from 269a642 to 959bd09 Compare April 12, 2026 14:16

nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from bbd0558 to 5fc8537 Compare April 12, 2026 14:16

nowgnuesLee changed the title ~~docs: add 2FA/TOTP, SSO, and session extension to login documentation~~ docs(FR-2534): add 2FA/TOTP, SSO, and session extension to login documentation Apr 14, 2026

nowgnuesLee force-pushed the 04-10-docs_add_2fa_totp_sso_and_session_extension_to_login_documentation branch from 83425aa to 68a0055 Compare April 15, 2026 07:08

nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from f114a55 to 4b6d722 Compare April 15, 2026 07:08

nowgnuesLee mentioned this pull request Apr 15, 2026

docs(FR-2571): address PR #6631 review feedback (excl. model store) #6708

Open

4 tasks

nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from 4b6d722 to 8e13af1 Compare April 15, 2026 07:38

nowgnuesLee force-pushed the 04-10-docs_add_2fa_totp_sso_and_session_extension_to_login_documentation branch 2 times, most recently from ace1668 to 6008c9a Compare April 15, 2026 09:19

nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch 2 times, most recently from 64248cc to c78b6fe Compare April 16, 2026 09:36

nowgnuesLee force-pushed the 04-10-docs_add_2fa_totp_sso_and_session_extension_to_login_documentation branch from 6008c9a to 5b6759c Compare April 16, 2026 09:36

nowgnuesLee mentioned this pull request Apr 16, 2026

docs(FR-2571): document Model Store V2 and Auto Scaling Rules V2 (26.4.0+) #6760

Open

6 tasks

agatha197 force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from c78b6fe to dfa849a Compare April 16, 2026 14:47

agatha197 force-pushed the 04-10-docs_add_2fa_totp_sso_and_session_extension_to_login_documentation branch from 5b6759c to 6e701a1 Compare April 16, 2026 14:47

agatha197 mentioned this pull request Apr 16, 2026

docs: add endpoint detail page revision info, alert banners, and edit behavior docs #6767

Open

agatha197 approved these changes Apr 17, 2026

View reviewed changes

yomybaby force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from dfa849a to 7e07be2 Compare April 17, 2026 08:43

yomybaby changed the base branch from 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones to graphite-base/6572 April 17, 2026 08:43

yomybaby mentioned this pull request Apr 17, 2026

docs(FR-2571): address 26.4 docs feedback — remove legacy model serving sections and apply KO wording fixes #6778

Open

5 tasks

graphite-app Bot force-pushed the 04-10-docs_add_2fa_totp_sso_and_session_extension_to_login_documentation branch from 6e701a1 to 67ab610 Compare April 17, 2026 10:11

github-actions Bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Apr 17, 2026

graphite-app Bot changed the base branch from graphite-base/6572 to 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones April 17, 2026 10:12

Base automatically changed from 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones to main April 17, 2026 10:14

graphite-app Bot merged commit 67ab610 into main Apr 17, 2026
3 checks passed

graphite-app Bot deleted the 04-10-docs_add_2fa_totp_sso_and_session_extension_to_login_documentation branch April 17, 2026 10:15

nowgnuesLee mentioned this pull request Apr 17, 2026

Add 2FA/TOTP, SSO, and session extension to login documentation #6784

Open

github-pages Bot temporarily deployed to github-pages April 17, 2026 10:15 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(FR-2534): add 2FA/TOTP, SSO, and session extension to login documentation#6572

docs(FR-2534): add 2FA/TOTP, SSO, and session extension to login documentation#6572
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_add_2fa_totp_sso_and_session_extension_to_login_documentation

nowgnuesLee commented Apr 10, 2026 •

edited

Loading

Uh oh!

nowgnuesLee commented Apr 10, 2026 •

edited

Loading

Uh oh!

nowgnuesLee left a comment

Uh oh!

agatha197 left a comment

Uh oh!

graphite-app Bot commented Apr 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nowgnuesLee commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Uh oh!

nowgnuesLee commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

nowgnuesLee left a comment

Choose a reason for hiding this comment

Review: PR #6572 — docs: add 2FA/TOTP, SSO, and session extension to login documentation

Summary

Findings

PR Title / Scope

[File: src/en/login/login.md]

[File: src/en/login/login.md]

[File: src/ko/login/login.md]

[File: src/ja/login/login.md]

[File: src/th/login/login.md]

Cross-reference verification

Image verification

Feature verification against codebase

Recommendation

Uh oh!

agatha197 left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nowgnuesLee commented Apr 10, 2026 •

edited

Loading

nowgnuesLee commented Apr 10, 2026 •

edited

Loading

graphite-app Bot commented Apr 17, 2026 •

edited

Loading