Skip to content

docs(FR-2538): fix button labels in import_run documentation#6576

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_fix_button_labels_in_import_run_documentation
Apr 17, 2026
Merged

docs(FR-2538): fix button labels in import_run documentation#6576
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_fix_button_labels_in_import_run_documentation

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented Apr 10, 2026

Resolves #6682 (FR-2538)

Summary

  • Update import_run documentation to reflect current UI button labels and direct-launch behavior
  • Replace outdated button references (IMPORT & RUNImport & Run, GET TO FOLDERGet To Folder)
  • Update the Import Notebook workflow to describe the updated "Import & Run" / "Start with options" split button behavior
  • Update badge code copy button label references
  • Apply reviewer fixes for grammar and accuracy

Changes

  • import_run/import_run.md (en/ko/ja/th): corrected button labels, updated workflow description, badge code copy button labels

Test plan

  • Verify button labels match the current Import & Run page UI
  • Verify the split button (Import & Run / Start with options) behavior description is accurate

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor Author

nowgnuesLee commented Apr 10, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor Author

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: PR #6576 — docs: fix button labels in import_run documentation

Summary

Good cleanup PR. Button labels are updated to match actual i18n labels, untranslated English paragraphs in ja/th are properly translated, and "data folder" is correctly replaced with "storage folder" per TERMINOLOGY.md. A few items to address below.

Findings

[en/import_run/import_run.md]

[i18n Completeness] Should Fix: Lines 27-28 and 31 still use 'LAUNCH' (all-caps) which doesn't match the actual i18n label "Launch". Since this PR's purpose is fixing button labels to match UI, it would be good to fix these in the same PR. Also, per the Documentation Style Guide, UI button labels should use backticks (`Launch`) rather than single quotes.

Same applies to line 15 — 'Import & Run' should be `Import & Run` for consistency with how Storage Host and Get To Folder are formatted later in the file.

[ja/import_run/import_run.md]

[i18n Completeness] Should Fix: The Launch button label is kept in English (「Launch」) on multiple lines, but the actual Japanese i18n label is 「ローンチ」 (resources/i18n/ja.json key session.launcher.Launch). If we are matching UI labels, this should use the localized version.

[th/import_run/import_run.md]

[i18n Completeness] Should Fix: Same as Japanese — 'Launch' is kept in English, but the Thai i18n label is 'เริ่ม' (resources/i18n/th.json). Please use the localized label.

[ko/import_run/import_run.md]

No issues found. Labels match ko.json correctly. Terminology updated properly.

What looks good

  • All 4 languages updated consistently for the main scope (Import & Run, Notebook Badge Code, Storage Host, Get To Folder)
  • "data folder" -> "storage folder" aligns with TERMINOLOGY.md across all languages
  • Previously untranslated English paragraphs in ja and th are now properly translated
  • Section headings in ja and th are translated while keeping English anchor IDs intact

Recommendation

Approve with suggestions. The core changes are correct and well-done. The Launch label inconsistency is a nice-to-have fix in this PR since it falls within scope, but not a blocker.

@nowgnuesLee nowgnuesLee changed the base branch from 04-10-docs_add_board_customization_and_auto-refresh_to_dashboard_docs to graphite-base/6576 April 10, 2026 09:24
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from d82f724 to ce673af Compare April 10, 2026 09:25
@github-actions github-actions Bot added area:lib Library and SDK related issue. area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC and removed size:L 100~500 LoC labels Apr 10, 2026
@nowgnuesLee nowgnuesLee changed the base branch from graphite-base/6576 to 04-10-docs_add_board_customization_and_auto-refresh_to_dashboard_docs April 10, 2026 09:34
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_add_board_customization_and_auto-refresh_to_dashboard_docs branch from 8f2078d to f64aa1e Compare April 11, 2026 03:46
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from ce41fa8 to 6660e5a Compare April 11, 2026 03:46
@github-actions github-actions Bot added size:L 100~500 LoC and removed size:XL 500~ LoC labels Apr 11, 2026
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_add_board_customization_and_auto-refresh_to_dashboard_docs branch from f64aa1e to 091f2a1 Compare April 12, 2026 14:16
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from 6660e5a to 109e3cc Compare April 12, 2026 14:16
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from 409d1e5 to df8f65e Compare April 15, 2026 07:08
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from df8f65e to 8310e72 Compare April 15, 2026 07:38
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_add_board_customization_and_auto-refresh_to_dashboard_docs branch 2 times, most recently from 4cf7969 to b4501a4 Compare April 15, 2026 09:19
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch 2 times, most recently from 5fe6509 to 436894c Compare April 16, 2026 09:36
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_add_board_customization_and_auto-refresh_to_dashboard_docs branch from b4501a4 to 113421c Compare April 16, 2026 09:36
@agatha197 agatha197 force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from 436894c to f664fda Compare April 16, 2026 14:47
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby changed the base branch from 04-10-docs_add_board_customization_and_auto-refresh_to_dashboard_docs to graphite-base/6576 April 17, 2026 08:55
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 17, 2026

Merge activity

@graphite-app graphite-app Bot changed the base branch from graphite-base/6576 to main April 17, 2026 09:17
@yomybaby yomybaby force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from f664fda to bcf8b04 Compare April 17, 2026 10:55
@github-actions github-actions Bot added size:M 30~100 LoC and removed size:L 100~500 LoC labels Apr 17, 2026
Resolves #6682 (FR-2538)

## Summary

- Update import_run documentation to reflect current UI button labels and direct-launch behavior
- Replace outdated button references (`IMPORT & RUN` → `Import & Run`, `GET TO FOLDER` → `Get To Folder`)
- Update the Import Notebook workflow to describe the updated "Import & Run" / "Start with options" split button behavior
- Update badge code copy button label references
- Apply reviewer fixes for grammar and accuracy

## Changes

- `import_run/import_run.md` (en/ko/ja/th): corrected button labels, updated workflow description, badge code copy button labels

## Test plan

- [ ] Verify button labels match the current Import & Run page UI
- [ ] Verify the split button (Import & Run / Start with options) behavior description is accurate

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Fix button labels in import_run documentation (FR-2538)

3 participants