docs(FR-2538): fix button labels in import_run documentation#6576
Conversation
nowgnuesLee
left a comment
There was a problem hiding this comment.
Review: PR #6576 — docs: fix button labels in import_run documentation
Summary
Good cleanup PR. Button labels are updated to match actual i18n labels, untranslated English paragraphs in ja/th are properly translated, and "data folder" is correctly replaced with "storage folder" per TERMINOLOGY.md. A few items to address below.
Findings
[en/import_run/import_run.md]
[i18n Completeness] Should Fix: Lines 27-28 and 31 still use 'LAUNCH' (all-caps) which doesn't match the actual i18n label "Launch". Since this PR's purpose is fixing button labels to match UI, it would be good to fix these in the same PR. Also, per the Documentation Style Guide, UI button labels should use backticks (`Launch`) rather than single quotes.
Same applies to line 15 — 'Import & Run' should be `Import & Run` for consistency with how Storage Host and Get To Folder are formatted later in the file.
[ja/import_run/import_run.md]
[i18n Completeness] Should Fix: The Launch button label is kept in English (「Launch」) on multiple lines, but the actual Japanese i18n label is 「ローンチ」 (resources/i18n/ja.json key session.launcher.Launch). If we are matching UI labels, this should use the localized version.
[th/import_run/import_run.md]
[i18n Completeness] Should Fix: Same as Japanese — 'Launch' is kept in English, but the Thai i18n label is 'เริ่ม' (resources/i18n/th.json). Please use the localized label.
[ko/import_run/import_run.md]
No issues found. Labels match ko.json correctly. Terminology updated properly.
What looks good
- All 4 languages updated consistently for the main scope (Import & Run, Notebook Badge Code, Storage Host, Get To Folder)
- "data folder" -> "storage folder" aligns with TERMINOLOGY.md across all languages
- Previously untranslated English paragraphs in ja and th are now properly translated
- Section headings in ja and th are translated while keeping English anchor IDs intact
Recommendation
Approve with suggestions. The core changes are correct and well-done. The Launch label inconsistency is a nice-to-have fix in this PR since it falls within scope, but not a blocker.
d82f724 to
ce673af
Compare
8f2078d to
f64aa1e
Compare
ce41fa8 to
6660e5a
Compare
f64aa1e to
091f2a1
Compare
6660e5a to
109e3cc
Compare
409d1e5 to
df8f65e
Compare
df8f65e to
8310e72
Compare
4cf7969 to
b4501a4
Compare
5fe6509 to
436894c
Compare
b4501a4 to
113421c
Compare
436894c to
f664fda
Compare
Merge activity
|
f664fda to
bcf8b04
Compare
Resolves #6682 (FR-2538) ## Summary - Update import_run documentation to reflect current UI button labels and direct-launch behavior - Replace outdated button references (`IMPORT & RUN` → `Import & Run`, `GET TO FOLDER` → `Get To Folder`) - Update the Import Notebook workflow to describe the updated "Import & Run" / "Start with options" split button behavior - Update badge code copy button label references - Apply reviewer fixes for grammar and accuracy ## Changes - `import_run/import_run.md` (en/ko/ja/th): corrected button labels, updated workflow description, badge code copy button labels ## Test plan - [ ] Verify button labels match the current Import & Run page UI - [ ] Verify the split button (Import & Run / Start with options) behavior description is accurate 🤖 Generated with [Claude Code](https://claude.com/claude-code)
bcf8b04 to
37f6b0b
Compare

Resolves #6682 (FR-2538)
Summary
IMPORT & RUN→Import & Run,GET TO FOLDER→Get To Folder)Changes
import_run/import_run.md(en/ko/ja/th): corrected button labels, updated workflow description, badge code copy button labelsTest plan
🤖 Generated with Claude Code