docs(FR-2540): fix session type filters in session_page documentation by nowgnuesLee · Pull Request #6578 · lablup/backend.ai-webui

nowgnuesLee · 2026-04-10T02:12:36Z

Resolves #6684 (FR-2540)

Summary

Fix incorrect session type filter label in the session page documentation: Upload Sessions (not "System" or "Batch")
Rewrite the JA and TH session_page filter section with correct i18n label translations verified against resources/i18n/ files
Apply reviewer fixes to KO documentation

Changes

session_page/session_page.md (en/ko/ja/th): corrected session type filter labels

Test plan

Verify "Upload Sessions" filter label matches the actual UI in all languages
Verify JA/TH translations match resources/i18n/ja.json and resources/i18n/th.json

🤖 Generated with Claude Code

nowgnuesLee · 2026-04-10T02:12:48Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

nowgnuesLee

Review: PR #6578 — docs: fix session type filters in session_page documentation

Summary

The PR correctly adds the missing All filter tab but incorrectly replaces Upload Sessions with System. The i18n key is session.System, but the actual label users see in the UI is "Upload Sessions". Documentation should match the displayed UI labels, not the internal key names.

Findings

All 4 files (en, ja, ko, th)

Correctness (Must Fix): The label System does not match the UI. The tab uses t('session.System') which resolves to:

EN: "Upload Sessions"
KO: "업로드 세션"
JA: "アップロードセッション"
TH: "เซสชันอัปโหลด"

Per the Translation Guide: "Documentation must use the same UI labels that users actually see in the application." Please verify against resources/i18n/{lang}.json.

The correct filter list in EN should be:

`All`, `Interactive`, `Batch`, `Inference`, or `Upload Sessions`

The old documentation was only missing All -- the Upload Sessions label was already correct and should not have been changed to System.

Reference: react/src/pages/ComputeSessionListPage.tsx lines 362-368 and resources/i18n/en.json key session.System.

Recommendation

Request changes -- The All tab addition is correct, but "System" should remain "Upload Sessions" (the user-visible label). Same applies across all 4 language files.

graphite-app · 2026-04-17T09:15:19Z

Merge activity

Apr 17, 9:15 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 17, 9:18 AM UTC: The Graphite merge queue removed this pull request due to removal of a downstack PR #6577.
Apr 17, 10:56 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 17, 11:02 AM UTC: Merged by the Graphite merge queue.

…#6578) Resolves #6684 (FR-2540) ## Summary - Fix incorrect session type filter label in the session page documentation: **Upload Sessions** (not "System" or "Batch") - Rewrite the JA and TH session_page filter section with correct i18n label translations verified against `resources/i18n/` files - Apply reviewer fixes to KO documentation ## Changes - `session_page/session_page.md` (en/ko/ja/th): corrected session type filter labels ## Test plan - [ ] Verify "Upload Sessions" filter label matches the actual UI in all languages - [ ] Verify JA/TH translations match `resources/i18n/ja.json` and `resources/i18n/th.json` 🤖 Generated with [Claude Code](https://claude.com/claude-code)

github-actions Bot assigned nowgnuesLee Apr 10, 2026

github-actions Bot added the size:XS ~10 LoC label Apr 10, 2026

nowgnuesLee mentioned this pull request Apr 10, 2026

docs(FR-2537): add board customization and auto-refresh to dashboard docs #6575

Merged

3 tasks

nowgnuesLee commented Apr 10, 2026

View reviewed changes

nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 23967a0 to cb80247 Compare April 10, 2026 09:25

nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from e729f78 to f68540a Compare April 10, 2026 09:25

github-actions Bot added size:M 30~100 LoC and removed size:XS ~10 LoC labels Apr 10, 2026

nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from cb80247 to a2ccc83 Compare April 10, 2026 09:33

nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from f68540a to e698b5e Compare April 10, 2026 09:33

github-actions Bot added size:XS ~10 LoC and removed size:M 30~100 LoC labels Apr 10, 2026

nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from a2ccc83 to 6520e17 Compare April 11, 2026 03:46

nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from e698b5e to 775f024 Compare April 11, 2026 03:46

github-actions Bot added size:M 30~100 LoC and removed size:XS ~10 LoC labels Apr 11, 2026

nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 6520e17 to 934d9a9 Compare April 12, 2026 14:16

nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from 775f024 to 5e29246 Compare April 12, 2026 14:16

nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from 9c75e04 to 645fced Compare April 14, 2026 05:45

nowgnuesLee changed the title ~~docs: fix session type filters in session_page documentation~~ docs(FR-2540): fix session type filters in session_page documentation Apr 14, 2026

nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from 645fced to c12bf4b Compare April 15, 2026 07:08

nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 14026d1 to 945764f Compare April 15, 2026 07:08

nowgnuesLee mentioned this pull request Apr 15, 2026

docs(FR-2571): address PR #6631 review feedback (excl. model store) #6708

Merged

4 tasks

nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from c12bf4b to 6468147 Compare April 15, 2026 07:38

nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 945764f to 378e887 Compare April 15, 2026 07:38

nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch 2 times, most recently from b3e8e0a to bf4254b Compare April 16, 2026 09:36

nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 3b20c1e to 8528fd6 Compare April 16, 2026 09:36

nowgnuesLee mentioned this pull request Apr 16, 2026

docs(FR-2571): document Model Store V2 and Auto Scaling Rules V2 (26.4.0+) #6760

Merged

6 tasks

agatha197 force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from bf4254b to 92406fb Compare April 16, 2026 14:47

agatha197 force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 8528fd6 to 7be42e6 Compare April 16, 2026 14:47

agatha197 mentioned this pull request Apr 16, 2026

docs: add endpoint detail page revision info, alert banners, and edit behavior docs #6767

Merged

yomybaby mentioned this pull request Apr 17, 2026

docs(FR-2571): address 26.4 docs feedback — remove legacy model serving sections and apply KO wording fixes #6778

Merged

5 tasks

yomybaby approved these changes Apr 17, 2026

View reviewed changes

graphite-app Bot force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 7be42e6 to db98be4 Compare April 17, 2026 10:57

graphite-app Bot force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from 92406fb to a1eeb49 Compare April 17, 2026 10:58

Base automatically changed from 04-10-docs_update_copy_button_location_in_my_environments_documentation to main April 17, 2026 11:01

graphite-app Bot merged commit a1eeb49 into main Apr 17, 2026
4 checks passed

graphite-app Bot deleted the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch April 17, 2026 11:02

nowgnuesLee mentioned this pull request Apr 17, 2026

Fix session type filters in session_page documentation #6792

Open

github-pages Bot temporarily deployed to github-pages April 17, 2026 11:02 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(FR-2540): fix session type filters in session_page documentation#6578

docs(FR-2540): fix session type filters in session_page documentation#6578
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_fix_session_type_filters_in_session_page_documentation

nowgnuesLee commented Apr 10, 2026 •

edited

Loading

Uh oh!

nowgnuesLee commented Apr 10, 2026 •

edited

Loading

Uh oh!

nowgnuesLee left a comment

Uh oh!

graphite-app Bot commented Apr 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nowgnuesLee commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Uh oh!

nowgnuesLee commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

nowgnuesLee left a comment

Choose a reason for hiding this comment

Review: PR #6578 — docs: fix session type filters in session_page documentation

Summary

Findings

All 4 files (en, ja, ko, th)

Recommendation

Uh oh!

graphite-app Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nowgnuesLee commented Apr 10, 2026 •

edited

Loading

nowgnuesLee commented Apr 10, 2026 •

edited

Loading

graphite-app Bot commented Apr 17, 2026 •

edited

Loading