Skip to content

docs(FR-2541): fix permission label formatting in vfolder documentation#6579

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_fix_permission_label_formatting_in_vfolder_documentation
Apr 17, 2026
Merged

docs(FR-2541): fix permission label formatting in vfolder documentation#6579
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_fix_permission_label_formatting_in_vfolder_documentation

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented Apr 10, 2026

Resolves #6685 (FR-2541)

Summary

  • Fix permission label formatting in vfolder documentation to use consistent Title Case and bold styling
  • Replace incorrect terminology "data folder" → "storage folder" in JA and TH translations
  • Update vfolder page with correct field names and terminology aligned with TERMINOLOGY.md
  • Add bold formatting to field names in the permission table

Changes

  • vfolder/vfolder.md (en/ko/ja/th): permission label formatting, "storage folder" terminology, field name styling

Test plan

  • Verify permission label names match the actual vfolder UI in all languages
  • Verify "storage folder" is used consistently (not "data folder") in JA/TH

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor Author

nowgnuesLee commented Apr 10, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor Author

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: PR #6579 — docs: fix permission label formatting in vfolder documentation

Summary

This PR fixes two documentation issues:

  1. Permission label formatting: aligns quoted permission labels with actual UI i18n values (e.g., EN: "Read only", KO: "읽기 전용", JA: "読み取り専用", TH: "อ่านเท่านั้น")
  2. Terminology: replaces "data folder" with "storage folder" in EN docs, matching the TERMINOLOGY.md standard

All changes verified against the source of truth:

  • resources/i18n/{lang}.json data.ReadOnly keys match the quoted labels in each language
  • TERMINOLOGY.md explicitly lists "data folder" under Terms to Avoid with "storage folder / vfolder" as the replacement
  • Thai "compute session" term corrected from "เซสชันการคอมพิวเตอร์" to "เซสชันการคำนวณ", matching TERMINOLOGY.md

Findings

No issues found. The changes are accurate, consistent across all 4 languages, and follow established terminology guidelines.

Recommendation

LGTM

@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from dde1522 to 1143c51 Compare April 10, 2026 02:20
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from e729f78 to f68540a Compare April 10, 2026 09:25
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 1143c51 to 4595e4a Compare April 10, 2026 09:25
@github-actions github-actions Bot added size:XS ~10 LoC and removed size:S 10~30 LoC labels Apr 10, 2026
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from f68540a to e698b5e Compare April 10, 2026 09:33
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 4595e4a to dfb9cbd Compare April 10, 2026 09:33
@github-actions github-actions Bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Apr 10, 2026
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from e698b5e to 775f024 Compare April 11, 2026 03:46
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from dfb9cbd to 0a4de8a Compare April 11, 2026 03:46
@github-actions github-actions Bot added size:L 100~500 LoC and removed size:S 10~30 LoC labels Apr 11, 2026
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 0a4de8a to afd6699 Compare April 12, 2026 14:16
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from 775f024 to 5e29246 Compare April 12, 2026 14:16
@nowgnuesLee nowgnuesLee changed the title docs: fix permission label formatting in vfolder documentation docs(FR-2541): fix permission label formatting in vfolder documentation Apr 14, 2026
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from 645fced to c12bf4b Compare April 15, 2026 07:08
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 2001b34 to 6308a70 Compare April 15, 2026 07:08
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 6308a70 to cea06be Compare April 15, 2026 07:38
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch 2 times, most recently from 6468147 to b3e8e0a Compare April 15, 2026 09:19
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch 2 times, most recently from b39f701 to c04a4cd Compare April 16, 2026 09:36
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from b3e8e0a to bf4254b Compare April 16, 2026 09:36
@agatha197 agatha197 force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from bf4254b to 92406fb Compare April 16, 2026 14:47
@agatha197 agatha197 force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from c04a4cd to 8d665dc Compare April 16, 2026 14:47
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 17, 2026

Merge activity

…on (#6579)

Resolves #6685 (FR-2541)

## Summary

- Fix permission label formatting in vfolder documentation to use consistent Title Case and bold styling
- Replace incorrect terminology "data folder" → "storage folder" in JA and TH translations
- Update vfolder page with correct field names and terminology aligned with `TERMINOLOGY.md`
- Add bold formatting to field names in the permission table

## Changes

- `vfolder/vfolder.md` (en/ko/ja/th): permission label formatting, "storage folder" terminology, field name styling

## Test plan

- [ ] Verify permission label names match the actual vfolder UI in all languages
- [ ] Verify "storage folder" is used consistently (not "data folder") in JA/TH

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app Bot force-pushed the 04-10-docs_fix_session_type_filters_in_session_page_documentation branch from 92406fb to a1eeb49 Compare April 17, 2026 10:58
@graphite-app graphite-app Bot force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 8d665dc to bde839e Compare April 17, 2026 10:59
Base automatically changed from 04-10-docs_fix_session_type_filters_in_session_page_documentation to main April 17, 2026 11:02
@graphite-app graphite-app Bot merged commit bde839e into main Apr 17, 2026
4 checks passed
@graphite-app graphite-app Bot deleted the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch April 17, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Fix permission label formatting in vfolder documentation (FR-2541)

3 participants