fix(FR-2522): trim whitespace from login email/username field#6598
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the React login flow by ensuring the SESSION-based login path trims leading/trailing whitespace from the user_id (email/username) field before creating the client and attempting authentication.
Changes:
- Trim
user_idinconnectUsingSessionvia(form.getFieldValue('user_id') || '').trim()to match the already-trimmed usage elsewhere in the login flow.
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.95% | 1750/19543 |
| 🔴 | Branches | 8.07% | 1100/13636 |
| 🔴 | Functions | 5.41% | 288/5325 |
| 🔴 | Lines | 8.64% | 1641/18986 |
Test suite run success
854 tests passing in 39 suites.
Report generated by 🧪jest coverage report action from b63ed9a
Merge activity
|
Resolves #6597 (FR-2522) ## Summary - Add `.trim()` to the `user_id` field value in `connectUsingSession` to strip leading/trailing whitespace before login - This matches the existing `.trim()` behavior in `connectUsingAPI` - Regression was introduced during the Lit component removal migration (originally fixed in FR-556) ## Verification ``` === ALL PASS === ``` ## Test plan - [ ] Type email with leading/trailing spaces in login form → login succeeds - [ ] Paste email with extra whitespace → login succeeds - [ ] Normal login without spaces → still works as before 🤖 Generated with [Claude Code](https://claude.com/claude-code)
graphite-app
Bot
force-pushed
the
04-10-fix_fr-2522_trim_whitespace_from_login_email_username_field
branch
from
c9b8ad1 to
b63ed9a
Compare
graphite-app
Bot
deleted the
04-10-fix_fr-2522_trim_whitespace_from_login_email_username_field
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6597 (FR-2522)
Summary
.trim()to theuser_idfield value inconnectUsingSessionto strip leading/trailing whitespace before login.trim()behavior inconnectUsingAPIVerification
Test plan
🤖 Generated with Claude Code