refactor(FR-2494): improve auto scaling rule v2 UI — step size sign, condition tag, preset searchable#6748
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 16, 2026
Conversation
Contributor
Author
5 tasks
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.68% (-0% 🔻) |
1738/20017 |
| 🔴 | Branches | 7.89% (-0.01% 🔻) |
1104/13985 |
| 🔴 | Functions | 5.21% | 283/5430 |
| 🔴 | Lines | 8.38% (-0% 🔻) |
1630/19440 |
Test suite run success
847 tests passing in 38 suites.
Report generated by 🧪jest coverage report action from 439bef6
Contributor
There was a problem hiding this comment.
Pull request overview
Refines the Auto Scaling Rule v2 UI to make Prometheus-based rules clearer and easier to use by improving condition labeling, step-size sign display, and preset selection UX.
Changes:
- Show Prometheus preset name in the condition tag (instead of raw metric name) and remove the separate “Prometheus Preset” column.
- Update Step Size display to use
+ / − / ±based on threshold configuration and show MIN/MAX replicas accordingly. - Make Prometheus preset preview show a small spinner while loading and enable searchable preset selection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
react/src/components/AutoScalingRuleList.tsx |
Updates condition rendering to use preset names and adjusts step-size / replica rendering logic. |
react/src/components/AutoScalingRuleEditorModal.tsx |
Improves Prometheus preset selection (search) and preview loading UX; tweaks label text. |
agatha197
force-pushed
the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_step_size_sign_condition_tag_preset_searchable
branch
from
8395e2c to
371c91b
Compare
agatha197
force-pushed
the
04-16-fix_fr-2494_fix_time_window_ko_translation_metricname_reset_on_source_change_and_prometheus_preview_restore
branch
from
d0d953e to
fdabd22
Compare
agatha197
force-pushed
the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_step_size_sign_condition_tag_preset_searchable
branch
from
371c91b to
d35f12e
Compare
yomybaby
approved these changes
Apr 16, 2026
Merge activity
|
…condition tag, preset searchable (#6748) resolves #NNN (FR-MMM) <!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. --> <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
graphite-app
Bot
force-pushed
the
04-16-fix_fr-2494_fix_time_window_ko_translation_metricname_reset_on_source_change_and_prometheus_preview_restore
branch
from
fdabd22 to
0bf260d
Compare
graphite-app
Bot
force-pushed
the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_step_size_sign_condition_tag_preset_searchable
branch
from
d35f12e to
439bef6
Compare
Base automatically changed from
04-16-fix_fr-2494_fix_time_window_ko_translation_metricname_reset_on_source_change_and_prometheus_preview_restore
to
main
April 16, 2026 06:56
graphite-app
Bot
deleted the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_step_size_sign_condition_tag_preset_searchable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #NNN (FR-MMM)
Checklist: (if applicable)