refactor(FR-2494): improve auto scaling rule v2 UI — loading, unmount, step size sign addon, threshold % suffix#6749
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 16, 2026
Conversation
Contributor
Author
5 tasks
agatha197
changed the title
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.68% (-0% 🔻) |
1738/20027 |
| 🔴 | Branches | 7.9% (+0% 🔼) |
1104/13983 |
| 🔴 | Functions | 5.21% (-0.01% 🔻) |
283/5436 |
| 🔴 | Lines | 8.38% (-0% 🔻) |
1630/19450 |
Test suite run success
847 tests passing in 38 suites.
Report generated by 🧪jest coverage report action from 08fe2ec
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Auto Scaling Rule v2 editor UX to improve perceived responsiveness and cleanup behavior, primarily by adjusting modal unmounting and introducing better inline loading affordances for Prometheus preset previews.
Changes:
- Wrap the rule editor modal with
BAIUnmountAfterCloseand move modal body work behind an innerSuspenseboundary (withSkeletonfallback). - Improve Prometheus preset preview behavior (refresh button loading, isolated Suspense for just the value text).
- Update editor inputs to show clearer units/signs (step-size sign prefix and
%suffix for KERNEL thresholds).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| react/src/components/AutoScalingRuleList.tsx | Wraps the editor modal with BAIUnmountAfterClose to unmount after close animations. |
| react/src/components/AutoScalingRuleEditorModal.tsx | Splits modal content to contain Suspense, changes loading fallbacks, and adds UI affordances (sign/unit addons) plus preview loading behavior. |
agatha197
force-pushed
the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_loading_indicator_unmount_step_size_addon_suffix_suspense_boundary
branch
from
de7b121 to
a1f8c90
Compare
agatha197
force-pushed
the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_step_size_sign_condition_tag_preset_searchable
branch
from
8395e2c to
371c91b
Compare
agatha197
changed the base branch from
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_step_size_sign_condition_tag_preset_searchable
to
graphite-base/6749
agatha197
force-pushed
the
graphite-base/6749
branch
from
371c91b to
d35f12e
Compare
agatha197
force-pushed
the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_loading_indicator_unmount_step_size_addon_suffix_suspense_boundary
branch
from
a1f8c90 to
b3de401
Compare
agatha197
changed the base branch from
graphite-base/6749
to
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_step_size_sign_condition_tag_preset_searchable
agatha197
force-pushed
the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_loading_indicator_unmount_step_size_addon_suffix_suspense_boundary
branch
from
b3de401 to
b47a605
Compare
nowgnuesLee
requested changes
Apr 16, 2026
agatha197
force-pushed
the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_loading_indicator_unmount_step_size_addon_suffix_suspense_boundary
branch
4 times, most recently
from
a1c5f8f to
d50fc67
Compare
yomybaby
approved these changes
Apr 16, 2026
Merge activity
|
…, step size sign addon, threshold % suffix (#6749) Resolves #6749 (FR-2494) ## Changes - **Loading indicator**: Refresh button shows loading state on both initial Prometheus preset selection and manual refresh - **BAIUnmountAfterClose**: Wrap editor modal to properly unmount after close - **Step size sign addon**: Use `Space.Compact` + `Space.Addon` to display +/−/± as a prefix (range: ±, scale-out: +, scale-in: −) - **Threshold % suffix**: Show % unit suffix on threshold inputs when metric source is KERNEL - **Suspense boundary**: Add Suspense boundary inside the modal to prevent the rule list from refreshing when the modal opens - **Skeleton fallback**: Show `Skeleton` instead of `Spin` while the modal content loads
graphite-app
Bot
force-pushed
the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_step_size_sign_condition_tag_preset_searchable
branch
from
d35f12e to
439bef6
Compare
graphite-app
Bot
force-pushed
the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_loading_indicator_unmount_step_size_addon_suffix_suspense_boundary
branch
from
d50fc67 to
08fe2ec
Compare
Base automatically changed from
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_step_size_sign_condition_tag_preset_searchable
to
main
April 16, 2026 06:57
graphite-app
Bot
deleted the
04-16-refactor_fr-2494_improve_auto_scaling_rule_v2_ui_loading_indicator_unmount_step_size_addon_suffix_suspense_boundary
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6749 (FR-2494)
Changes
Space.Compact+Space.Addonto display +/−/± as a prefix (range: ±, scale-out: +, scale-in: −)Skeletoninstead ofSpinwhile the modal content loads