test(FR-2622): add E2E tests for bulk vfolder trash on model card bulk deletion#7137
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
0463915 to
6d58c28
Compare
…features (bulk folder trash)
6d58c28 to
589494b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #6841 (FR-2622)
Summary
Adds E2E test coverage for the bulk vfolder trash feature introduced in #7135 (Admin Model Card bulk delete with folder option).
New test cases in
e2e/admin-model-card/admin-model-card-delete.spec.ts:Data > Trash.BulkDeleteCompletedbehavior — folders remain intact and only cards are removed.Stability work for parallel execution:
Tests run with 7 parallel workers, which significantly increases backend latency for both mutations and filter searches. Adjusted the deletion suite accordingly:
5.3,5.9,5.10) to 300000ms and the success notification wait to 240000ms.getAlsoDeleteFoldersBulkCheckbox()toAdminModelCardPagePOM.Coverage report update:
e2e/E2E_COVERAGE_REPORT.md— Admin Model Store: 26 → 28 features (28/28, 100%); total covered: 412 → 414 / 267 features.Test plan
pnpm playwright test e2e/admin-model-card/admin-model-card-delete.spec.ts— 10/10 pass under 7-worker parallel execution (~1.4 min)Data > Trashfilter after bulk deleteexpect(...).toBeHidden({ timeout: ... })polling on the bulk dialog — replaced with notification visibility assertionafterEachcleanup respects per-test resource state (5.9 omits folders fromcreatedResourcessince the test body permanently removes them)Checklist: