Skip to content

test(FR-2622): add E2E tests for bulk vfolder trash on model card bulk deletion#7137

Open
agatha197 wants to merge 1 commit into04-28-feat_fr-2622_add_bulk_vfolder_trash_support_on_model_card_bulk_deletionfrom
04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion
Open

test(FR-2622): add E2E tests for bulk vfolder trash on model card bulk deletion#7137
agatha197 wants to merge 1 commit into04-28-feat_fr-2622_add_bulk_vfolder_trash_support_on_model_card_bulk_deletionfrom
04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 28, 2026

Resolves #6841 (FR-2622)

Summary

Adds E2E test coverage for the bulk vfolder trash feature introduced in #7135 (Admin Model Card bulk delete with folder option).

New test cases in e2e/admin-model-card/admin-model-card-delete.spec.ts:

  • 5.9 — Admin can bulk-delete model cards and move associated folders to trash: Selects multiple cards, enables the "Also delete the associated model folders" checkbox in the bulk delete modal, asserts the success notification, and verifies folders appear in Data > Trash.
  • 5.10 — Admin can bulk-delete model cards without moving folders to trash: Confirms the unchecked path preserves the original BulkDeleteCompleted behavior — folders remain intact and only cards are removed.

Stability work for parallel execution:

Tests run with 7 parallel workers, which significantly increases backend latency for both mutations and filter searches. Adjusted the deletion suite accordingly:

  • Switched from "wait for dialog hidden" to "wait for visible success notification" — intermediate UI states are unreliable under load, but the success toast is the user-visible outcome.
  • Bumped per-test timeout for bulk-delete cases (5.3, 5.9, 5.10) to 300000ms and the success notification wait to 240000ms.
  • Bumped filter/table-load waits from 10000ms → 30000ms across the file.
  • Reduced test 5.3 from 3 cards → 2 cards to lighten backend load on parallel runs.
  • Added getAlsoDeleteFoldersBulkCheckbox() to AdminModelCardPage POM.

Coverage report update:

  • e2e/E2E_COVERAGE_REPORT.md — Admin Model Store: 26 → 28 features (28/28, 100%); total covered: 412 → 414 / 267 features.

Test plan

  • pnpm playwright test e2e/admin-model-card/admin-model-card-delete.spec.ts — 10/10 pass under 7-worker parallel execution (~1.4 min)
  • Test 5.9 verifies trash entries via Data > Trash filter after bulk delete
  • Test 5.10 verifies cards are deleted but folders remain
  • No expect(...).toBeHidden({ timeout: ... }) polling on the bulk dialog — replaced with notification visibility assertion
  • afterEach cleanup respects per-test resource state (5.9 omits folders from createdResources since the test body permanently removes them)

Checklist:

  • Documentation
  • Minimum required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions Bot added the size:L 100~500 LoC label Apr 28, 2026
Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 force-pushed the 04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion branch 2 times, most recently from 0463915 to 6d58c28 Compare April 28, 2026 12:29
@agatha197 agatha197 force-pushed the 04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion branch from 6d58c28 to 589494b Compare April 28, 2026 12:31
@agatha197 agatha197 marked this pull request as ready for review April 28, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant