fix: populate replica info for hc-opt-out routes in check_running_routes

The hc_pairs filter was gating ``routes_missing_replica`` as well, so
revisions that omit ``service.health_check`` never had their
``replica_host``/``replica_port`` populated. ``sync_appproxy`` would
then reject them indefinitely with "no replica connection info to
sync", breaking the BA-5985 promise that opt-out routes start
receiving traffic as soon as they reach RUNNING.

Split the two phases:

- Replica population now runs over all session-verified successes,
  hc-agnostic, since AppProxy registration needs host/port regardless
  of probing policy.
- RouteHealthRecord initialization stays hc-gated — opt-out revisions
  never get probed, so they don't need a Valkey record.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: fregataa

src/ai/backend/manager/sokovan/deployment/route/executor.py

@@ -255,24 +255,28 @@ async def check_running_routes(self, routes: Sequence[RouteData]) -> RouteExecut
         if not successes:
             return RouteExecutionResult(successes=successes, errors=errors)
 
-        hc_configs = await self._deployment_repo.fetch_health_check_configs({
-            r.revision_id for r in successes
-        })
-        hc_pairs: list[_RouteWithHealthCheck] = [
-            _RouteWithHealthCheck(route=r, health_check=hc)
-            for r in successes
-            if (hc := hc_configs.get(r.revision_id)) is not None
-        ]
-
+        # Replica population is hc-agnostic — opt-out routes still need
+        # host/port for ``sync_appproxy`` to register them with AppProxy.
         # ``_populate_replica_info`` mutates ``replica_host``/``replica_port``
-        # in place so the rows it just populated flow into the Phase-4 filter.
-        routes_missing_replica = [p.route for p in hc_pairs if not p.route.replica_host]
+        # in place so populated rows flow into the hc-pair filter below.
+        routes_missing_replica = [r for r in successes if not r.replica_host]
         if routes_missing_replica:
             with RouteRecorderContext.shared_phase("populate_replica_info"):
                 with RouteRecorderContext.shared_step("fetch_kernel_connection_info"):
                     await self._populate_replica_info(routes_missing_replica)
 
-        pairs_with_replica = [p for p in hc_pairs if p.route.replica_host and p.route.replica_port]
+        # Only revisions that declared ``service.health_check`` get a
+        # RouteHealthRecord in Valkey; opt-out revisions never get probed.
+        hc_configs = await self._deployment_repo.fetch_health_check_configs({
+            r.revision_id for r in successes
+        })
+        pairs_with_replica: list[_RouteWithHealthCheck] = [
+            _RouteWithHealthCheck(route=r, health_check=hc)
+            for r in successes
+            if r.replica_host
+            and r.replica_port
+            and (hc := hc_configs.get(r.revision_id)) is not None
+        ]
         if pairs_with_replica:
             await self._ensure_health_records(pairs_with_replica)