fix(BA-5829): clean BEP refs, drop unused type:ignore, break circular import

Per #11285 review:

- Strip the BEP-1052 §X annotations from descriptions, comments, and
  docstrings — the BEP number doesn't help future readers and clutters
  the schema.
- Move `BulkCreate/UpdateMyAppConfigFragmentsPayloadGQL` from
  `app_config_fragment/types/bulk_payloads.py` into
  `app_config/types/bulk_payloads.py`. They referenced `AppConfigGQL`
  while `AppConfigGQL` already references `AppConfigFragmentGQL`, so
  splitting them keeps the import direction one-way and resolves the
  `tests/component/user/test_keypair_ops.py` collection error reported
  by `test-component`.
- Drop unused `# type: ignore[misc]` on `gql_mutation` decorators
  (the helper preserves the wrapped function's signature, so mypy no
  longer treats the result as untyped).

Author: jopemachine

src/ai/backend/manager/api/adapters/app_config.py

@@ -1,4 +1,4 @@
-"""AppConfig (merged view) domain adapter — BEP-1052 §5.
+"""AppConfig (merged view) domain adapter
 
 Reads the per-user merged AppConfig view and writes the underlying USER
 fragments via the same `app_config_fragment` service processors. The
@@ -69,7 +69,7 @@
 
 
 class AppConfigAdapter(BaseAdapter):
-    """Adapter for the merged AppConfig view (BEP-1052 §5).
+    """Adapter for the merged AppConfig view.
 
     Backed by the `app_config_fragment` service processors — the merged
     view is computed from raw fragments — but exposed as a separate
@@ -146,7 +146,7 @@ async def admin_search_app_configs(
             has_previous_page=result.has_previous_page,
         )
 
-    # ── Self-service bulk writes (BEP-1052 §3) ───────────────────────
+    # ── Self-service bulk writes ───────────────────────
     #
     # Each bulk processor returns a `BulkProcessResult[T]` whose
     # `.result` field is the underlying `*ActionResult` produced by the
@@ -156,19 +156,12 @@ async def admin_search_app_configs(
     async def my_bulk_create(
         self, input: BulkCreateMyAppConfigFragmentsInput
     ) -> BulkCreateMyAppConfigFragmentsPayload:
-        me = current_user()
-        if me is None:
-            raise UnreachableError("User context is not available")
         items = [
             MyAppConfigFragmentBulkItem(name=item.name, config=dict(item.config))
             for item in input.items
         ]
         wrapper = await self._processors.app_config_fragment.bulk_create_my.wait_for_complete(
-            BulkCreateMyAppConfigFragmentsAction(
-                entity_ids=[],
-                user_id=me.user_id,
-                items=items,
-            )
+            BulkCreateMyAppConfigFragmentsAction(entity_ids=[], items=items)
         )
         result = wrapper.result
         return BulkCreateMyAppConfigFragmentsPayload(
@@ -179,19 +172,12 @@ async def my_bulk_create(
     async def my_bulk_update(
         self, input: BulkUpdateMyAppConfigFragmentsInput
     ) -> BulkUpdateMyAppConfigFragmentsPayload:
-        me = current_user()
-        if me is None:
-            raise UnreachableError("User context is not available")
         items = [
             MyAppConfigFragmentBulkItem(name=item.name, config=dict(item.config))
             for item in input.items
         ]
         wrapper = await self._processors.app_config_fragment.bulk_update_my.wait_for_complete(
-            BulkUpdateMyAppConfigFragmentsAction(
-                entity_ids=[],
-                user_id=me.user_id,
-                items=items,
-            )
+            BulkUpdateMyAppConfigFragmentsAction(entity_ids=[], items=items)
         )
         result = wrapper.result
         return BulkUpdateMyAppConfigFragmentsPayload(

src/ai/backend/manager/api/adapters/app_config_fragment.py

@@ -109,9 +109,9 @@
 
 
 class AppConfigFragmentAdapter(BaseAdapter):
-    """Adapter for AppConfigFragment raw-row operations (BEP-1052 §2).
+    """Adapter for AppConfigFragment raw-row operations.
 
-    Writes are bulk-only (BEP-1052 §3); single-item create / update /
+    Writes are bulk-only; single-item create / update /
     purge entry points are intentionally absent. Self-service my_bulk
     writes (which return the recomputed merged view) live on
     `AppConfigAdapter` alongside the merged-view reads.
@@ -266,7 +266,7 @@ def _data_to_dto(data: AppConfigFragmentData) -> AppConfigFragmentNode:
             updated_at=data.updated_at,
         )
 
-    # ── Bulk mutations (BEP-1052 §3) ───────────────────────────────
+    # ── Bulk mutations ───────────────────────────────
     #
     # Each bulk processor returns a `BulkProcessResult[T]` whose
     # `.result` field is the underlying `*ActionResult` produced by the

src/ai/backend/manager/api/gql/app_config/types/__init__.py

@@ -1,6 +1,6 @@
 from .bulk_payloads import (
-    MyBulkCreateAppConfigFragmentsPayloadGQL,
-    MyBulkUpdateAppConfigFragmentsPayloadGQL,
+    BulkCreateMyAppConfigFragmentsPayloadGQL,
+    BulkUpdateMyAppConfigFragmentsPayloadGQL,
 )
 from .filters import (
     AppConfigFilterGQL,
@@ -14,6 +14,6 @@
     "AppConfigGQL",
     "AppConfigOrderByGQL",
     "AppConfigOrderFieldGQL",
-    "MyBulkCreateAppConfigFragmentsPayloadGQL",
-    "MyBulkUpdateAppConfigFragmentsPayloadGQL",
+    "BulkCreateMyAppConfigFragmentsPayloadGQL",
+    "BulkUpdateMyAppConfigFragmentsPayloadGQL",
 ]

src/ai/backend/manager/api/gql/app_config/types/bulk_payloads.py

@@ -3,10 +3,10 @@
 from __future__ import annotations
 
 from ai.backend.common.dto.manager.v2.app_config.response import (
-    MyBulkCreateAppConfigFragmentsPayload as MyBulkCreatePayloadDTO,
+    BulkCreateMyAppConfigFragmentsPayload as BulkCreateMyPayloadDTO,
 )
 from ai.backend.common.dto.manager.v2.app_config.response import (
-    MyBulkUpdateAppConfigFragmentsPayload as MyBulkUpdatePayloadDTO,
+    BulkUpdateMyAppConfigFragmentsPayload as BulkUpdateMyPayloadDTO,
 )
 from ai.backend.common.meta.meta import NEXT_RELEASE_VERSION
 from ai.backend.manager.api.gql.app_config.types.node import AppConfigGQL
@@ -24,12 +24,12 @@
 @gql_pydantic_type(
     BackendAIGQLMeta(
         added_version=NEXT_RELEASE_VERSION,
-        description="Payload for `myBulkCreateAppConfigFragments` (recomputed views).",
+        description="Payload for `bulkCreateMyAppConfigFragments` (recomputed views).",
     ),
-    model=MyBulkCreatePayloadDTO,
-    name="MyBulkCreateAppConfigFragmentsPayload",
+    model=BulkCreateMyPayloadDTO,
+    name="BulkCreateMyAppConfigFragmentsPayload",
 )
-class MyBulkCreateAppConfigFragmentsPayloadGQL(PydanticOutputMixin[MyBulkCreatePayloadDTO]):
+class BulkCreateMyAppConfigFragmentsPayloadGQL(PydanticOutputMixin[BulkCreateMyPayloadDTO]):
     created: list[AppConfigGQL] = gql_field(
         description="Recomputed merged AppConfig views for each created USER fragment.",
     )
@@ -41,12 +41,12 @@ class MyBulkCreateAppConfigFragmentsPayloadGQL(PydanticOutputMixin[MyBulkCreateP
 @gql_pydantic_type(
     BackendAIGQLMeta(
         added_version=NEXT_RELEASE_VERSION,
-        description="Payload for `myBulkUpdateAppConfigFragments` (recomputed views).",
+        description="Payload for `bulkUpdateMyAppConfigFragments` (recomputed views).",
     ),
-    model=MyBulkUpdatePayloadDTO,
-    name="MyBulkUpdateAppConfigFragmentsPayload",
+    model=BulkUpdateMyPayloadDTO,
+    name="BulkUpdateMyAppConfigFragmentsPayload",
 )
-class MyBulkUpdateAppConfigFragmentsPayloadGQL(PydanticOutputMixin[MyBulkUpdatePayloadDTO]):
+class BulkUpdateMyAppConfigFragmentsPayloadGQL(PydanticOutputMixin[BulkUpdateMyPayloadDTO]):
     updated: list[AppConfigGQL] = gql_field(
         description="Recomputed merged AppConfig views for each updated USER fragment.",
     )

src/ai/backend/manager/api/gql/app_config_fragment/__init__.py

@@ -19,7 +19,7 @@
 )
 
 __all__ = [
-    # Queries — scope-bound list belongs on DomainV2 / UserV2 child fields per BEP-1052
+    # Queries — scope-bound list belongs on DomainV2 / UserV2 child fields
     "app_config_fragment",
     "scoped_app_config_fragments",
     "admin_app_config_fragments",

src/ai/backend/manager/api/gql/app_config_fragment/resolver/mutation.py

@@ -6,8 +6,8 @@
 
 from ai.backend.common.meta.meta import NEXT_RELEASE_VERSION
 from ai.backend.manager.api.gql.app_config.types import (
-    MyBulkCreateAppConfigFragmentsPayloadGQL,
-    MyBulkUpdateAppConfigFragmentsPayloadGQL,
+    BulkCreateMyAppConfigFragmentsPayloadGQL,
+    BulkUpdateMyAppConfigFragmentsPayloadGQL,
 )
 from ai.backend.manager.api.gql.app_config_fragment.types import (
     AdminBulkCreateAppConfigFragmentInputGQL,
@@ -16,8 +16,8 @@
     AdminBulkPurgeAppConfigFragmentsPayloadGQL,
     AdminBulkUpdateAppConfigFragmentInputGQL,
     AdminBulkUpdateAppConfigFragmentsPayloadGQL,
-    MyBulkCreateAppConfigFragmentInputGQL,
-    MyBulkUpdateAppConfigFragmentInputGQL,
+    BulkCreateMyAppConfigFragmentInputGQL,
+    BulkUpdateMyAppConfigFragmentInputGQL,
 )
 from ai.backend.manager.api.gql.decorators import (
     BackendAIGQLMeta,
@@ -87,7 +87,7 @@ async def admin_bulk_purge_app_config_fragments(
         ),
     )
 )
-async def my_bulk_create_app_config_fragments(
+async def bulk_create_my_app_config_fragments(
     info: Info[StrawberryGQLContext],
     input: BulkCreateMyAppConfigFragmentInputGQL,
 ) -> BulkCreateMyAppConfigFragmentsPayloadGQL:
@@ -104,7 +104,7 @@ async def my_bulk_create_app_config_fragments(
         ),
     )
 )
-async def my_bulk_update_app_config_fragments(
+async def bulk_update_my_app_config_fragments(
     info: Info[StrawberryGQLContext],
     input: BulkUpdateMyAppConfigFragmentInputGQL,
 ) -> BulkUpdateMyAppConfigFragmentsPayloadGQL:

src/ai/backend/manager/api/gql/app_config_fragment/resolver/query.py

@@ -1,6 +1,6 @@
 """AppConfigFragment GQL query resolvers.
 
-Per BEP-1052 §2 the scope-bound list is exposed via child fields on
+Per the scope-bound list is exposed via child fields on
 `DomainV2.appConfigFragments` / `UserV2.appConfigFragments`, not as a
 root resolver. Only the single-row read and the cross-scope admin
 search live here. The scope-bound REST endpoint

src/ai/backend/manager/api/gql/app_config_fragment/types/__init__.py

@@ -39,8 +39,8 @@
     "AppConfigFragmentOrderByGQL",
     "AppConfigFragmentOrderFieldGQL",
     "AppConfigScopeTypeGQL",
-    "MyBulkCreateAppConfigFragmentInputGQL",
-    "MyBulkUpdateAppConfigFragmentInputGQL",
+    "BulkCreateMyAppConfigFragmentInputGQL",
+    "BulkUpdateMyAppConfigFragmentInputGQL",
     "MyAppConfigFragmentItemInputGQL",
     "PurgeAppConfigFragmentKeyGQL",
 ]