fix(BA-5829): clean BEP refs, drop unused type:ignore, break circular import

Per #11285 review:

- Strip the BEP-1052 §X annotations from descriptions, comments, and
  docstrings — the BEP number doesn't help future readers and clutters
  the schema.
- Move `BulkCreate/UpdateMyAppConfigFragmentsPayloadGQL` from
  `app_config_fragment/types/bulk_payloads.py` into
  `app_config/types/bulk_payloads.py`. They referenced `AppConfigGQL`
  while `AppConfigGQL` already references `AppConfigFragmentGQL`, so
  splitting them keeps the import direction one-way and resolves the
  `tests/component/user/test_keypair_ops.py` collection error reported
  by `test-component`.
- Drop unused `# type: ignore[misc]` on `gql_mutation` decorators
  (the helper preserves the wrapped function's signature, so mypy no
  longer treats the result as untyped).

Author: jopemachine

src/ai/backend/common/dto/manager/v2/app_config/__init__.py

@@ -1,5 +1,5 @@
 """
-AppConfig (merged view) DTOs v2 for Manager API (BEP-1052 §5).
+AppConfig (merged view) DTOs v2 for Manager API.
 """
 
 from .request import (

src/ai/backend/common/dto/manager/v2/app_config/request.py

@@ -1,5 +1,5 @@
 """
-Request DTOs for AppConfig (merged view) DTO v2 (BEP-1052 §5).
+Request DTOs for AppConfig (merged view) DTO v2.
 """
 
 from __future__ import annotations
@@ -62,7 +62,7 @@ class SearchMyAppConfigsInput(_AppConfigSearchInputBase):
     """Input for self-service merged-view search (`/v2/app-configs/my/search`).
 
     The adapter pins the caller as the user scope; no `user_id` argument
-    is accepted here (BEP-1052 §5 — `filter.userId` is ignored).
+    is accepted here.
     """
 
 

src/ai/backend/common/dto/manager/v2/app_config/response.py

@@ -1,5 +1,5 @@
 """
-Response DTOs for AppConfig (merged view) DTO v2 (BEP-1052 §5).
+Response DTOs for AppConfig (merged view) DTO v2.
 """
 
 from __future__ import annotations
@@ -25,7 +25,7 @@
 
 
 class AppConfigNode(BaseResponseModel):
-    """Merged per-user AppConfig view (BEP-1052 §5).
+    """Merged per-user AppConfig view.
 
     `fragments` are ordered low → high merge priority (matching the
     policy's `scope_sources`). `config` is the deep-merged result,
@@ -66,7 +66,7 @@ class BulkCreateMyAppConfigFragmentsPayload(BaseResponseModel):
     """Payload for `bulkCreateMyAppConfigFragments`.
 
     Each successfully created row produces a recomputed merged
-    `AppConfigNode`; failures are collected per-item (BEP-1052 §3).
+    `AppConfigNode`; failures are collected per-item.
     """
 
     created: list[AppConfigNode] = Field(

src/ai/backend/common/dto/manager/v2/app_config/types.py

@@ -1,5 +1,5 @@
 """
-Common types for AppConfig (merged view) DTO v2 (BEP-1052 §5).
+Common types for AppConfig (merged view) DTO v2.
 """
 
 from __future__ import annotations

src/ai/backend/manager/api/adapters/app_config.py

@@ -154,14 +154,14 @@ async def admin_search_app_configs(
     # reasons travel back through the per-item `failed` list.
 
     async def my_bulk_create(
-        self, input: MyBulkCreateAppConfigFragmentsInput
-    ) -> MyBulkCreateAppConfigFragmentsPayload:
+        self, input: BulkCreateMyAppConfigFragmentsInput
+    ) -> BulkCreateMyAppConfigFragmentsPayload:
         items = [
             MyAppConfigFragmentBulkItem(name=item.name, config=dict(item.config))
             for item in input.items
         ]
-        wrapper = await self._processors.app_config_fragment.my_bulk_create.wait_for_complete(
-            MyBulkCreateAppConfigFragmentsAction(entity_ids=[], items=items)
+        wrapper = await self._processors.app_config_fragment.bulk_create_my.wait_for_complete(
+            BulkCreateMyAppConfigFragmentsAction(entity_ids=[], items=items)
         )
         result = wrapper.result
         return MyBulkCreateAppConfigFragmentsPayload(
@@ -170,14 +170,14 @@ async def my_bulk_create(
         )
 
     async def my_bulk_update(
-        self, input: MyBulkUpdateAppConfigFragmentsInput
-    ) -> MyBulkUpdateAppConfigFragmentsPayload:
+        self, input: BulkUpdateMyAppConfigFragmentsInput
+    ) -> BulkUpdateMyAppConfigFragmentsPayload:
         items = [
             MyAppConfigFragmentBulkItem(name=item.name, config=dict(item.config))
             for item in input.items
         ]
-        wrapper = await self._processors.app_config_fragment.my_bulk_update.wait_for_complete(
-            MyBulkUpdateAppConfigFragmentsAction(entity_ids=[], items=items)
+        wrapper = await self._processors.app_config_fragment.bulk_update_my.wait_for_complete(
+            BulkUpdateMyAppConfigFragmentsAction(entity_ids=[], items=items)
         )
         result = wrapper.result
         return MyBulkUpdateAppConfigFragmentsPayload(

src/ai/backend/manager/api/adapters/app_config_fragment.py

@@ -112,8 +112,10 @@
 class AppConfigFragmentAdapter(BaseAdapter):
     """Adapter for AppConfigFragment raw-row operations.
 
-    Writes are bulk-only (BEP-1052 §3); single-item create / update /
-    purge entry points are intentionally absent.
+    Writes are bulk-only; single-item create / update /
+    purge entry points are intentionally absent. Self-service my_bulk
+    writes (which return the recomputed merged view) live on
+    `AppConfigAdapter` alongside the merged-view reads.
     """
 
     async def get(self, key_input: AppConfigFragmentKeyInput) -> GetAppConfigFragmentPayload:
@@ -265,143 +267,7 @@ def _data_to_dto(data: AppConfigFragmentData) -> AppConfigFragmentNode:
             updated_at=data.updated_at,
         )
 
-    # ── Merged-view (AppConfig, BEP-1052 §5) ───────────────────────
-
-    async def my_app_config(self, name: str) -> GetUserAppConfigPayload:
-        """Read the caller's own merged AppConfig for `name`.
-
-        Resolves the current user from the context; there is no way to
-        target another user through this method.
-        """
-        me = current_user()
-        if me is None:
-            raise UnreachableError("User context is not available")
-        result = await self._processors.app_config_fragment.get_user_app_config.wait_for_complete(
-            GetUserAppConfigAction(user_id=me.user_id, config_name=name)
-        )
-        return GetUserAppConfigPayload(item=self._app_config_data_to_dto(result.app_config))
-
-    async def admin_get_user_app_config(
-        self, input: GetUserAppConfigInput
-    ) -> GetUserAppConfigPayload:
-        """Read a specific user's merged AppConfig (admin only)."""
-        result = await self._processors.app_config_fragment.get_user_app_config.wait_for_complete(
-            GetUserAppConfigAction(user_id=input.user_id, config_name=input.name)
-        )
-        return GetUserAppConfigPayload(item=self._app_config_data_to_dto(result.app_config))
-
-    async def my_search_app_configs(
-        self, input: SearchMyAppConfigsInput
-    ) -> SearchAppConfigsPayload:
-        """Paginated merged-view search over the caller's own AppConfigs."""
-        me = current_user()
-        if me is None:
-            raise UnreachableError("User context is not available")
-        querier = self._build_app_config_querier(input)
-        result = (
-            await self._processors.app_config_fragment.search_user_app_configs.wait_for_complete(
-                SearchUserAppConfigsAction(
-                    scope=UserAppConfigSearchScope(user_id=me.user_id),
-                    querier=querier,
-                )
-            )
-        )
-        return SearchAppConfigsPayload(
-            items=[self._app_config_data_to_dto(item) for item in result.items],
-            total_count=result.total_count,
-            has_next_page=result.has_next_page,
-            has_previous_page=result.has_previous_page,
-        )
-
-    async def admin_search_app_configs(
-        self, input: SearchAppConfigsInput
-    ) -> SearchAppConfigsPayload:
-        """Cross-user merged-view search (admin only).
-
-        `filter.user_id` pins the query to a single user; otherwise
-        pagination walks across every user.
-        """
-        querier = self._build_app_config_querier(input)
-        result = (
-            await self._processors.app_config_fragment.admin_search_app_configs.wait_for_complete(
-                AdminSearchAppConfigsAction(querier=querier)
-            )
-        )
-        return SearchAppConfigsPayload(
-            items=[self._app_config_data_to_dto(item) for item in result.items],
-            total_count=result.total_count,
-            has_next_page=result.has_next_page,
-            has_previous_page=result.has_previous_page,
-        )
-
-    def _build_app_config_querier(
-        self,
-        input: SearchMyAppConfigsInput | SearchAppConfigsInput,
-    ) -> BatchQuerier:
-        """Querier builder shared by `my_search_app_configs` and
-        `admin_search_app_configs`.
-
-        The merged-view SQL resolves cursor/order internally via the
-        repository layer; this helper forwards only the filter / order /
-        pagination fields so cursor tiebreakers stay consistent with
-        the raw-fragment querier.
-        """
-        conditions = self._convert_app_config_filter(input.filter) if input.filter else []
-        orders = self._convert_app_config_orders(input.order) if input.order else []
-        return self._build_querier(
-            conditions=conditions,
-            orders=orders,
-            pagination_spec=self._PAGINATION_SPEC,
-            first=input.first,
-            after=input.after,
-            last=input.last,
-            before=input.before,
-            limit=input.limit,
-            offset=input.offset,
-        )
-
-    def _convert_app_config_filter(self, filter: AppConfigFilter) -> list[QueryCondition]:
-        conditions: list[QueryCondition] = []
-        if filter.name is not None:
-            condition = self.convert_string_filter(
-                filter.name,
-                contains_factory=AppConfigFragmentConditions.by_name_contains,
-                equals_factory=AppConfigFragmentConditions.by_name_equals,
-                starts_with_factory=AppConfigFragmentConditions.by_name_starts_with,
-                ends_with_factory=AppConfigFragmentConditions.by_name_ends_with,
-                in_factory=AppConfigFragmentConditions.by_name_in,
-            )
-            if condition is not None:
-                conditions.append(condition)
-        # `filter.user_id` handling lives inside the merged-view SQL
-        # (repository layer) rather than in a BatchQuerier condition —
-        # see `AppConfigFragmentDBSource.admin_search_app_configs`.
-        return conditions
-
-    @staticmethod
-    def _convert_app_config_orders(orders: list[AppConfigOrder]) -> list[QueryOrder]:
-        result: list[QueryOrder] = []
-        for order in orders:
-            ascending = order.direction == OrderDirection.ASC
-            match order.field:
-                case AppConfigOrderField.NAME:
-                    result.append(AppConfigFragmentOrders.name(ascending))
-                case AppConfigOrderField.USER_ID:
-                    # USER_ID ordering is applied inside the merged-view SQL
-                    # because the raw `app_config_fragments` row does not
-                    # carry a user_id column directly.
-                    continue
-        return result
-
-    def _app_config_data_to_dto(self, data: AppConfigData) -> AppConfigNode:
-        return AppConfigNode(
-            user_id=data.user_id,
-            name=data.name,
-            fragments=[self._data_to_dto(fragment) for fragment in data.fragments],
-            config=dict(data.config) if data.config is not None else None,
-        )
-
-    # ── Bulk mutations (BEP-1052 §3) ───────────────────────────────
+    # ── Bulk mutations ───────────────────────────────
     #
     # Each bulk processor returns a `BulkProcessResult[T]` whose
     # `.result` field is the underlying `*ActionResult` produced by the

src/ai/backend/manager/api/gql/app_config/__init__.py

@@ -1,4 +1,4 @@
-"""AppConfig (merged view) GraphQL API package (BEP-1052 §5)."""
+"""AppConfig (merged view) GraphQL API package."""
 
 from .resolver import (
     admin_app_configs,

src/ai/backend/manager/api/gql/app_config/resolver/query.py

@@ -1,4 +1,4 @@
-"""AppConfig (merged view) GQL query resolvers (BEP-1052 §5)."""
+"""AppConfig (merged view) GQL query resolvers."""
 
 from __future__ import annotations
 
@@ -36,7 +36,7 @@
         added_version=NEXT_RELEASE_VERSION,
         description=(
             "Caller's own merged AppConfig list (auth required). Chain per policy "
-            "(BEP-1052 §5); the adapter pins `(USER, current_user)` internally."
+            "; the adapter pins `(USER, current_user)` internally."
         ),
     )
 )  # type: ignore[misc]
@@ -108,7 +108,7 @@ async def admin_app_configs(
         added_version=NEXT_RELEASE_VERSION,
         description=(
             "Public (no-auth) `PUBLIC`-scope app-config fragments — the subset of "
-            "raw fragments that carry no personally-scoped data (BEP-1052 §3)."
+            "raw fragments that carry no personally-scoped data."
         ),
     )
 )  # type: ignore[misc]

src/ai/backend/manager/api/gql/app_config/types/__init__.py

@@ -1,3 +1,7 @@
+from .bulk_payloads import (
+    BulkCreateMyAppConfigFragmentsPayloadGQL,
+    BulkUpdateMyAppConfigFragmentsPayloadGQL,
+)
 from .filters import (
     AppConfigFilterGQL,
     AppConfigOrderByGQL,
@@ -10,4 +14,6 @@
     "AppConfigGQL",
     "AppConfigOrderByGQL",
     "AppConfigOrderFieldGQL",
+    "BulkCreateMyAppConfigFragmentsPayloadGQL",
+    "BulkUpdateMyAppConfigFragmentsPayloadGQL",
 ]

src/ai/backend/manager/api/gql/app_config/types/bulk_payloads.py

@@ -3,10 +3,10 @@
 from __future__ import annotations
 
 from ai.backend.common.dto.manager.v2.app_config.response import (
-    MyBulkCreateAppConfigFragmentsPayload as MyBulkCreatePayloadDTO,
+    BulkCreateMyAppConfigFragmentsPayload as BulkCreateMyPayloadDTO,
 )
 from ai.backend.common.dto.manager.v2.app_config.response import (
-    MyBulkUpdateAppConfigFragmentsPayload as MyBulkUpdatePayloadDTO,
+    BulkUpdateMyAppConfigFragmentsPayload as BulkUpdateMyPayloadDTO,
 )
 from ai.backend.common.meta.meta import NEXT_RELEASE_VERSION
 from ai.backend.manager.api.gql.app_config.types.node import AppConfigGQL
@@ -24,12 +24,12 @@
 @gql_pydantic_type(
     BackendAIGQLMeta(
         added_version=NEXT_RELEASE_VERSION,
-        description="Payload for `myBulkCreateAppConfigFragments` (recomputed views).",
+        description="Payload for `bulkCreateMyAppConfigFragments` (recomputed views).",
     ),
-    model=MyBulkCreatePayloadDTO,
-    name="MyBulkCreateAppConfigFragmentsPayload",
+    model=BulkCreateMyPayloadDTO,
+    name="BulkCreateMyAppConfigFragmentsPayload",
 )
-class MyBulkCreateAppConfigFragmentsPayloadGQL(PydanticOutputMixin[MyBulkCreatePayloadDTO]):
+class BulkCreateMyAppConfigFragmentsPayloadGQL(PydanticOutputMixin[BulkCreateMyPayloadDTO]):
     created: list[AppConfigGQL] = gql_field(
         description="Recomputed merged AppConfig views for each created USER fragment.",
     )
@@ -41,12 +41,12 @@ class MyBulkCreateAppConfigFragmentsPayloadGQL(PydanticOutputMixin[MyBulkCreateP
 @gql_pydantic_type(
     BackendAIGQLMeta(
         added_version=NEXT_RELEASE_VERSION,
-        description="Payload for `myBulkUpdateAppConfigFragments` (recomputed views).",
+        description="Payload for `bulkUpdateMyAppConfigFragments` (recomputed views).",
     ),
-    model=MyBulkUpdatePayloadDTO,
-    name="MyBulkUpdateAppConfigFragmentsPayload",
+    model=BulkUpdateMyPayloadDTO,
+    name="BulkUpdateMyAppConfigFragmentsPayload",
 )
-class MyBulkUpdateAppConfigFragmentsPayloadGQL(PydanticOutputMixin[MyBulkUpdatePayloadDTO]):
+class BulkUpdateMyAppConfigFragmentsPayloadGQL(PydanticOutputMixin[BulkUpdateMyPayloadDTO]):
     updated: list[AppConfigGQL] = gql_field(
         description="Recomputed merged AppConfig views for each updated USER fragment.",
     )