Skip to content

Commit cfb4990

Browse files
committed
refactor: Simplify metric collect logic
1 parent 9f6a8ee commit cfb4990

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

src/ai/backend/agent/stats.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
FlattenedDeviceMetric,
5252
FlattenedKernelMetric,
5353
FlattenedProcessMetric,
54-
MetricValueFieldPair,
5554
)
5655
from .utils import remove_exponent
5756

@@ -728,7 +727,6 @@ async def collect_container_stat(
728727
)
729728
results = await asyncio.gather(*_tasks, return_exceptions=True)
730729
updated_kernel_ids: set[KernelId] = set()
731-
raw_kernel_value_pairs: dict[tuple[KernelId, MetricKey], list[MetricValueFieldPair]] = {}
732730
self._stage_observer.observe_stage(
733731
stage="before_observe",
734732
upper_layer="collect_container_stat",
@@ -768,10 +766,6 @@ async def collect_container_stat(
768766
)
769767
else:
770768
self.kernel_metrics[kernel_id][metric_key].update(measure)
771-
value_pairs = [(CURRENT_METRIC_KEY, str(measure.value))]
772-
if measure.capacity is not None:
773-
value_pairs.append((CAPACITY_METRIC_KEY, str(measure.capacity)))
774-
raw_kernel_value_pairs[(kernel_id, metric_key)] = value_pairs
775769

776770
prometheus_kernel_updates: list[FlattenedKernelMetric] = []
777771
kernel_serialized_updates: list[tuple[KernelId, bytes]] = []
@@ -789,12 +783,12 @@ async def collect_container_stat(
789783
)
790784
continue
791785
serializable_metrics[key] = metric_value
792-
if (raw_value_pairs := raw_kernel_value_pairs.get((kernel_id, key))) is None:
793-
continue
794786
value_pairs = [
795-
*raw_value_pairs,
787+
(CURRENT_METRIC_KEY, metric_value["current"]),
796788
(PCT_METRIC_KEY, metric_value["pct"]),
797789
]
790+
if (capacity := metric_value.get("capacity")) is not None:
791+
value_pairs.append((CAPACITY_METRIC_KEY, capacity))
798792
if (max_value := metric_value.get("stats.max")) is not None:
799793
value_pairs.append((MAX_METRIC_KEY, max_value))
800794
if (avg_value := metric_value.get("stats.avg")) is not None:

0 commit comments

Comments
 (0)