feat(BA-5836): AppConfigFragment service vertical (service / DTO / adapter)#11296
Draft
jopemachine wants to merge 5 commits intoBA-5827from
Draft
feat(BA-5836): AppConfigFragment service vertical (service / DTO / adapter)#11296jopemachine wants to merge 5 commits intoBA-5827from
jopemachine wants to merge 5 commits intoBA-5827from
Conversation
github-actions
Bot
added
size:XL
jopemachine
added a commit
that referenced
this pull request
Apr 25, 2026
This was referenced Apr 25, 2026
feat(BA-5814): AppConfigPolicy foundation (data / repository / service / adapter, bulk-aware)
#11266
Draft
jopemachine
added a commit
that referenced
this pull request
Apr 25, 2026
jopemachine
added a commit
that referenced
this pull request
Apr 25, 2026
jopemachine
commented
Apr 26, 2026
jopemachine
commented
Apr 26, 2026
Member
Author
|
Please add service-level tests by referring to the existing code. |
jopemachine
added a commit
that referenced
this pull request
Apr 26, 2026
github-actions
Bot
added
the
require:db-migration
3 tasks
jopemachine
added a commit
that referenced
this pull request
Apr 26, 2026
jopemachine
added a commit
that referenced
this pull request
Apr 27, 2026
jopemachine
added a commit
that referenced
this pull request
Apr 27, 2026
…apter, bulk-aware) Layers the service / adapter / DTO surface on top of the AppConfigFragment foundation that BA-5827 (#11282) lands. Per BEP-1052 §3, all writes are bulk-only (admin + self-service) with partial-success semantics; reads expose `get`, scope-bound `search`, and cross-scope `admin_search`. - v2 DTOs (`common/dto/manager/v2/app_config_fragment/`) — shared by the GQL and REST surfaces in subsequent PRs. - Service + 8 action files + processor package; bulk actions extend `BaseBulkAction[T]` so `BulkActionProcessor` can route per-item validators (RBAC etc. — none wired yet, no-op forward). - Adapter (`api/adapters/app_config_fragment.py`) flesh-out, registered in the adapter registry; `bulk_create_my` / `bulk_update_my` pull `user_id` from `current_user()` instead of accepting it on the action. - Filter `conditions.py` and `orders.py` for typed Fragment search. - `services/factory.py` + `services/processors.py` wiring.
…num match - Rename `bulk_create_my` / `bulk_update_my` → `my_bulk_create` / `my_bulk_update` across action classes, files, service methods, processors, and the request DTO module to match the existing `my_` prefix convention used elsewhere in the v2 surface (e.g. `my_keypair`). - Switch order-field dispatch in `AppConfigFragmentAdapter` from string `.value` matching to direct StrEnum matching against `AppConfigFragmentOrderField`. - Promote per-item bulk failure logs from `log.debug` to `log.warning`. - Drop BEP-1052 §X references from doctrings, comments, and inline notes across the service / adapter / DTO modules. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…e / adapter Propagate the BA-5827 column rename through the service vertical: the bulk-mutation DTOs, the service's bulk methods, the bulk-item data classes, the adapter's data-to-DTO mapping, and the bulk-error field all now reference `config` instead of `extra_config`. Tracks the underlying JSONB column name for naming consistency end-to-end. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Stacked PRs
This PR is part of a 10-PR stack delivering BEP-1052. Merge in order:
chore(BA-5822): drop legacy AppConfig layerfeat(BA-5814): AppConfigPolicy foundationfeat(BA-5815): AppConfigPolicy GraphQLfeat(BA-5844): AppConfigPolicy REST v2feat(BA-5827): AppConfigFragment foundationfeat(BA-5836): AppConfigFragment service vertical← you are herefeat(BA-5829): AppConfigFragment + AppConfig GraphQLfeat(BA-5830): AppConfigFragment + AppConfig REST v2feat(BA-5832): AppConfig v2 SDK + CLIfeat(BA-5837): ValkeyCache for AppConfigFragment merged-view readsCI on intermediate PRs may show test churn since each one only lands a slice of the new layer. The full picture is guaranteed to build at the tip (#11298).
Summary
Splits the AppConfigFragment service vertical out of #11282 (BA-5827) so each PR stays under ~2k lines.
What's in here
common/dto/manager/v2/app_config_fragment/) — shared input/output models for the GQL + REST surfaces in subsequent PRsBaseBulkAction[T]and run throughBulkActionProcessorfor per-item validator routing (RBAC etc. — none wired yet, no-op forward)AppConfigFragmentAdapterflesh-out and registration in the adapter registrybulk_create_my/bulk_update_myresolveuser_idfromcurrent_user()rather than accepting it on the actionconditions.pyandorders.pyfor typed Fragment searchservices/factory.py+services/processors.pywiringStack
Test plan
📚 Documentation preview 📚: https://sorna--11296.org.readthedocs.build/en/11296/
📚 Documentation preview 📚: https://sorna-ko--11296.org.readthedocs.build/ko/11296/