feat(BA-6701): expose allow-list rank on the v2 API surface#12517
Merged
Conversation
jopemachine
added a commit
that referenced
this pull request
Jul 3, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 3, 2026
0f29c09 to
82c26ae
Compare
76f61f2 to
974923c
Compare
jopemachine
added a commit
that referenced
this pull request
Jul 6, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4afa2cb to
ec8f884
Compare
974923c to
76f61f2
Compare
ec8f884 to
4afa2cb
Compare
76f61f2 to
367f886
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: octodog <mu001@lablup.com>
4afa2cb to
2177b3f
Compare
HyeockJinKim
reviewed
Jul 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes the app config allow-list merge rank (introduced in the stacked #12516) across the v2 API surface, and adds a rank-only update operation so admins can re-order the merge post-create (needed because purge now cascades to fragments, making purge+recreate unsuitable). It's a pure API-layer change with no new schema/behavior beyond surfacing the field and the new operation. It fits into the larger BEP-1052 AppConfigFragment/AppConfig stack (epic BA-5781).
Changes:
- Surface
rankonCreateAppConfigAllowListInput(optional, scope-type default when omitted),AppConfigAllowListNode(required), and a newRANKorder field, across DTO/adapter/GraphQL/OpenAPI. - Add a rank-only admin update path end-to-end:
AppConfigAllowListUpdaterSpec, repository/db_sourceupdate, service action/processor,PATCH /v2/app-config-allow-list/{id},adminUpdateAppConfigAllowListmutation, SDKadmin_update, and./bai admin app-config-allow-list update --rank. - Regenerate GraphQL/OpenAPI schema docs and add repository/service/GraphQL/client tests plus a changelog fragment.
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
common/dto/manager/v2/app_config_allow_list/request.py |
Adds optional rank to create input and new UpdateAppConfigAllowListInput. |
common/dto/manager/v2/app_config_allow_list/response.py |
Adds rank to node and new UpdateAppConfigAllowListPayload. |
common/dto/manager/v2/app_config_allow_list/types.py |
Adds RANK order field. |
manager/api/adapters/app_config_allow_list/adapter.py |
Maps rank in create/node, adds admin_update, handles RANK ordering. |
manager/api/gql/app_config_allow_list/types.py |
Adds rank GQL field, RANK order enum, and update input/payload GQL types. |
manager/api/gql/app_config_allow_list/resolver.py |
Adds admin_update_app_config_allow_list mutation. |
manager/api/gql/app_config_allow_list/__init__.py, api/gql/schema.py |
Exports/wires the new mutation. |
manager/api/rest/v2/app_config_allow_list/handler.py, registry.py |
Adds PATCH route + admin_update handler. |
manager/repositories/app_config_allow_list/updaters.py |
New AppConfigAllowListUpdaterSpec (rank-only). |
manager/repositories/app_config_allow_list/repository.py, db_source/db_source.py |
Adds update with not-found handling. |
manager/services/app_config_allow_list/actions/update.py, service.py, processors.py |
New update action/service method/processor wiring. |
client/v2/domains_v2/app_config_allow_list.py, client/cli/v2/admin/app_config_allow_list.py |
SDK admin_update and CLI --rank/update. |
docs/manager/{rest,graphql}-reference/* |
Regenerated OpenAPI/GraphQL schema docs. |
changes/12517.feature.md, .claude/skills/bai-cli/SKILL.md |
Changelog fragment and CLI entity reference update. |
tests/unit/.../{repositories,services,api/gql,client_v2}/... |
Update/rank test coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HyeockJinKim
approved these changes
Jul 6, 2026
jopemachine
added a commit
that referenced
this pull request
Jul 6, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jopemachine
added a commit
that referenced
this pull request
Jul 7, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the allow-list
rank(introduced in #12516) on the v2 API surface. Pure API-layer change — no schema or behavior change beyond the new field:common/dto/manager/v2/app_config_allow_list): optionalrankonCreateAppConfigAllowListInput(defaults to the scope type's default rank when omitted), requiredrankonAppConfigAllowListNode, and aRANKorder field.rankbetween the DTO and the creator spec / domain data, and handles theRANKordering.rankon theAppConfigAllowListnode andCreateAppConfigAllowListInput(version-tagged withNEXT_RELEASE_VERSION),RANKinAppConfigAllowListOrderField; supergraph / v2 schema regenerated../bai admin app-config-allow-list create --rank.updateoperation (rank only) — with rank on the allow list, re-ordering the merge needs a post-create adjustment (purge now cascades to fragments, so purge+recreate is not a substitute):AppConfigAllowListUpdaterSpec+ service action/processor,PATCH /v2/app-config-allow-list/{id},adminUpdateAppConfigAllowListGQL mutation, SDKadmin_update, and./bai admin app-config-allow-list update <id> --rank. The identity pair (config_name,scope_type) stays immutable.Verified against the live server: REST/GQL/CLI create with default (user=300) and explicit (
--rank 250) ranks,rankordering in both directions, and rank update via both the CLI (update --rank 275) and the GQL mutation.📚 Stacked PRs
Part of the AppConfigFragment / AppConfig stack under BEP-1052 (epic BA-5781). Merge in order:
feat(BA-6552): app_config_fragments DB model and Alembic migrationfeat(BA-6553): repository layerrefactor(BA-6619): consolidate AppConfigScopeType into common.datarefactor(BA-6620): ExistsQuerier + AppConfigAllowList.existsfeat(BA-6554): AppConfigFragment service layerfeat(BA-6628): move fragment rank to the allow list with scope defaults(replaces feat(BA-6628): conditional-bulk repository primitives #12429)feat(BA-6701): expose allow-list rank on the v2 API surface← you are herefeat(BA-6628): cascade fragment deletion from the allow listfeat(BA-6626): app_config_fragment bulk repository layerfeat(BA-6618): AppConfigFragment bulk CRUD service layerfeat(BA-6555): app_config service layer (merge engine)feat(BA-6556): AppConfig REST v2 API🤖 Generated with Claude Code
📚 Documentation preview 📚: https://sorna--12517.org.readthedocs.build/en/12517/
📚 Documentation preview 📚: https://sorna-ko--12517.org.readthedocs.build/ko/12517/
📚 Documentation preview 📚: https://sorna--12517.org.readthedocs.build/en/12517/
📚 Documentation preview 📚: https://sorna-ko--12517.org.readthedocs.build/ko/12517/
📚 Documentation preview 📚: https://sorna--12517.org.readthedocs.build/en/12517/
📚 Documentation preview 📚: https://sorna-ko--12517.org.readthedocs.build/ko/12517/
📚 Documentation preview 📚: https://sorna--12517.org.readthedocs.build/en/12517/
📚 Documentation preview 📚: https://sorna-ko--12517.org.readthedocs.build/ko/12517/
📚 Documentation preview 📚: https://sorna--12517.org.readthedocs.build/en/12517/
📚 Documentation preview 📚: https://sorna-ko--12517.org.readthedocs.build/ko/12517/