Skip to content

Commit e597ef1

Browse files
committed
fix: await dataset preview access links
1 parent 87e738c commit e597ef1

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

packages/service/common/s3/uploadPolicy/service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ export const resolveUploadFile = ({
376376

377377
const resolvedExtension = explicitExtension
378378
? explicitExtension
379-
: matchedAllowedExtension || evidence.officeExtension || evidence.detectedExtension;
379+
: matchedAllowedExtension || evidence.officeExtension || evidence.detectedExtension || '';
380380
return {
381381
filename: resolveAcceptedFilename({ filename, extension: resolvedExtension }),
382382
contentType: evidence.detectedMime,

projects/app/src/pages/api/core/dataset/file/getRawTextPreviewChunks.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,15 @@ async function handler(
5454
maxChunks: maxPreviewChunkCount
5555
});
5656

57-
const chunksWithJWT = chunks.slice(0, 10).map((chunk) => ({
58-
q: replaceS3KeyToPreviewUrl(chunk.q, addDays(new Date(), 1)),
59-
a: replaceS3KeyToPreviewUrl(chunk.a, addDays(new Date(), 1))
60-
}));
57+
const chunksWithPreviewUrls = await Promise.all(
58+
chunks.slice(0, 10).map(async (chunk) => ({
59+
q: await replaceS3KeyToPreviewUrl(chunk.q, addDays(new Date(), 1)),
60+
a: await replaceS3KeyToPreviewUrl(chunk.a, addDays(new Date(), 1))
61+
}))
62+
);
6163

6264
return GetPreviewChunksResponseSchema.parse({
63-
chunks: chunksWithJWT,
65+
chunks: chunksWithPreviewUrls,
6466
total: chunks.length
6567
});
6668
}

projects/app/test/pages/api/core/dataset/file/getRawTextPreviewChunks.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest';
44
const mocks = vi.hoisted(() => ({
55
authDataset: vi.fn(),
66
rawText2Chunks: vi.fn(),
7-
replaceS3KeyToPreviewUrl: vi.fn((value: string) => value)
7+
replaceS3KeyToPreviewUrl: vi.fn(async (value: string) => value)
88
}));
99

1010
vi.mock('@/service/middleware/entry', () => ({

0 commit comments

Comments
 (0)