Skip to content

Commit e67d43e

Browse files
fix: enhance IsWebSocket() test cases with Connection header validation
1 parent 6a1dc4e commit e67d43e

1 file changed

Lines changed: 19 additions & 2 deletions

File tree

context_test.go

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -969,15 +969,21 @@ func TestContext_IsWebSocket(t *testing.T) {
969969
{
970970
&context{
971971
request: &http.Request{
972-
Header: http.Header{HeaderUpgrade: []string{"websocket"}},
972+
Header: http.Header{
973+
HeaderUpgrade: []string{"websocket"},
974+
HeaderConnection: []string{"upgrade"},
975+
},
973976
},
974977
},
975978
assert.True,
976979
},
977980
{
978981
&context{
979982
request: &http.Request{
980-
Header: http.Header{HeaderUpgrade: []string{"Websocket"}},
983+
Header: http.Header{
984+
HeaderUpgrade: []string{"Websocket"},
985+
HeaderConnection: []string{"Upgrade"},
986+
},
981987
},
982988
},
983989
assert.True,
@@ -996,6 +1002,17 @@ func TestContext_IsWebSocket(t *testing.T) {
9961002
},
9971003
assert.False,
9981004
},
1005+
{
1006+
&context{
1007+
request: &http.Request{
1008+
Header: http.Header{
1009+
HeaderUpgrade: []string{"websocket"},
1010+
HeaderConnection: []string{"close"},
1011+
},
1012+
},
1013+
},
1014+
assert.False,
1015+
},
9991016
}
10001017

10011018
for i, tt := range tests {

0 commit comments

Comments
 (0)