fix(security): 2 improvements across 2 files#513
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Unsafe Content Security Policy with 'unsafe-inline' and 'unsafe-eval' - Security: Unsafe Content Security Policy with 'unsafe-inline' and 'unsafe-eval' Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Unsafe Content Security Policy with 'unsafe-inline' and 'unsafe-eval' - Security: Unsafe Content Security Policy with 'unsafe-inline' and 'unsafe-eval' Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:src/renderer/chooser.html:L6The chooser.html file uses a very permissive Content-Security-Policy that allows 'unsafe-inline' for scripts and styles, and 'unsafe-eval' for scripts. This significantly weakens the security benefits of CSP and could allow XSS attacks if any user-controlled data reaches the renderer.
Solution
Remove 'unsafe-inline' and 'unsafe-eval' from the CSP. Use nonce or hash-based CSP for inline scripts. If 'unsafe-eval' is needed for a specific library, consider using a safer alternative or sandboxing that code.
Changes
src/renderer/chooser.html(modified)src/renderer/index.html(modified)