AllowSynchronousContinuations false

ladeak · ladeak · commit f71e440c2fdf · 2025-08-10T19:46:57.000+02:00
diff --git a/src/CHttpServer/CHttpServer/Http2ResponseWriter.cs b/src/CHttpServer/CHttpServer/Http2ResponseWriter.cs
@@ -28,7 +28,7 @@ public Http2ResponseWriter(FrameWriter frameWriter, uint maxFrameSize)
         _maxFrameSize = (int)maxFrameSize;
         _buffer = [];
         _hpackEncoder = new DynamicHPackEncoder();
-        _channel = Channel.CreateUnbounded<StreamWriteRequest>(new UnboundedChannelOptions() { SingleReader = true, AllowSynchronousContinuations = true });
+        _channel = Channel.CreateUnbounded<StreamWriteRequest>(new UnboundedChannelOptions() { SingleReader = true, AllowSynchronousContinuations = false });
         _priorityChannel = Channel.CreateUnbounded<StreamWriteRequest>(new UnboundedChannelOptions() { SingleReader = true, AllowSynchronousContinuations = false });
     }
 
@@ -198,7 +198,6 @@ private async ValueTask WriteHeadersAsync(Http2Stream h2Stream)
         if (flushingBuffer.Length <= currentMaxFrameSize)
         {
             _frameWriter.WriteHeader(h2Stream.StreamId, flushingBuffer, endHeaders: true, endStream: false);
-            await _frameWriter.FlushAsync();
             return;
         }
         else

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public Http2ResponseWriter(FrameWriter frameWriter, uint maxFrameSize)`
`28`	`28`	`_maxFrameSize = (int)maxFrameSize;`
`29`	`29`	`_buffer = [];`
`30`	`30`	`_hpackEncoder = new DynamicHPackEncoder();`
`31`		`- _channel = Channel.CreateUnbounded<StreamWriteRequest>(new UnboundedChannelOptions() { SingleReader = true, AllowSynchronousContinuations = true });`
	`31`	`+ _channel = Channel.CreateUnbounded<StreamWriteRequest>(new UnboundedChannelOptions() { SingleReader = true, AllowSynchronousContinuations = false });`
`32`	`32`	`_priorityChannel = Channel.CreateUnbounded<StreamWriteRequest>(new UnboundedChannelOptions() { SingleReader = true, AllowSynchronousContinuations = false });`
`33`	`33`	`}`
`34`	`34`
`@@ -198,7 +198,6 @@ private async ValueTask WriteHeadersAsync(Http2Stream h2Stream)`
`198`	`198`	`if (flushingBuffer.Length <= currentMaxFrameSize)`
`199`	`199`	`{`
`200`	`200`	`_frameWriter.WriteHeader(h2Stream.StreamId, flushingBuffer, endHeaders: true, endStream: false);`
`201`		`- await _frameWriter.FlushAsync();`
`202`	`201`	`return;`
`203`	`202`	`}`
`204`	`203`	`else`