Skip to content

Flaky MultipleWrites_HeaderFrame* tests #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ladeak merged 2 commits into from
Jun 21, 2026
Merged

Flaky MultipleWrites_HeaderFrame* tests #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ce05af
MultipleWrites_HeaderFrame_ReservedFrame modified: in case the server…
Jun 21, 2026
88f9987
Same concern addressed in MultipleWrites_HeaderFrame
Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions tests/CHttpServer.Tests/Http3/Http3StreamTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Net.Quic;
using System.Diagnostics;
using System.Net.Quic;
using CHttpServer.Http3;
using Microsoft.AspNetCore.Http.Features;

Expand Down Expand Up @@ -55,22 +56,24 @@ public async Task MultipleWrites_HeaderFrame()

TaskCompletionSource tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);
sut.Initialize(null, await serverStreamTask);
var testApp = new TestBase.TestApplication(ctx =>
var testApp = new TestBase.TestApplication(async ctx =>
{
Assert.Equal("/", ctx.Request.Path);
Assert.Equal("https", ctx.Request.Scheme);
Assert.Equal("localhost", ctx.Request.Host.ToString());
Assert.Equal(HttpMethod.Get.ToString(), ctx.Request.Method);
tcs.SetResult();
return Task.CompletedTask;

// This callback shall not complete before the 2nd flush, otherwise the
// server might close the stream before the flush succeeds.
await tcs.Task;
});
var processing = sut.ProcessStreamAsync(testApp, TestContext.Current.CancellationToken);

// Second Write
await clientStream.WriteAsync(headersFrame[i..], TestContext.Current.CancellationToken);
await clientStream.FlushAsync(TestContext.Current.CancellationToken);
tcs.SetResult();

await tcs.Task.WaitAsync(DefaultTimeout, TestContext.Current.CancellationToken);
clientStream.Close();
await processing;
await quicConnection.DisposeAsync();
Expand Down Expand Up @@ -112,37 +115,38 @@ public async Task SingleWrite_HeaderFrame_ReservedFrame()
public async Task MultipleWrites_HeaderFrame_ReservedFrame()
{
byte[] data = [.. Http3FrameFixture.GetHeadersFrame(), .. Http3FrameFixture.GetReservedFrame(10)];
var quicConnection = await QuicConnectionFixture.SetupConnectionAsync(Port, TestContext.Current.CancellationToken);
await using var quicConnection = await QuicConnectionFixture.SetupConnectionAsync(Port, TestContext.Current.CancellationToken);
for (int i = 1; i < data.Length; i++)
{
var serverStreamTask = Task.Run(async () => await quicConnection.ServerConnection.AcceptInboundStreamAsync());
var sut = new Http3Stream([]);

var clientStream = await quicConnection.ClientConnection.OpenOutboundStreamAsync(QuicStreamType.Bidirectional, TestContext.Current.CancellationToken);
await using var clientStream = await quicConnection.ClientConnection.OpenOutboundStreamAsync(QuicStreamType.Bidirectional, TestContext.Current.CancellationToken);
await clientStream.WriteAsync(data.AsMemory(0, i), TestContext.Current.CancellationToken);
await clientStream.FlushAsync(TestContext.Current.CancellationToken);

TaskCompletionSource tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);
TaskCompletionSource secondFlushCompleted = new(TaskCreationOptions.RunContinuationsAsynchronously);
sut.Initialize(null, await serverStreamTask);
var testApp = new TestBase.TestApplication(ctx =>
var testApp = new TestBase.TestApplication(async ctx =>
{
Assert.Equal("/", ctx.Request.Path);
Assert.Equal("https", ctx.Request.Scheme);
Assert.Equal("localhost", ctx.Request.Host.ToString());
Assert.Equal(HttpMethod.Get.ToString(), ctx.Request.Method);
tcs.SetResult();
return Task.CompletedTask;

// This callback shall not complete before the 2nd flush, otherwise the
// server might close the stream before the flush succeeds.
await secondFlushCompleted.Task;
});
var processing = sut.ProcessStreamAsync(testApp, TestContext.Current.CancellationToken);

await clientStream.WriteAsync(data.AsMemory(i), TestContext.Current.CancellationToken);
await clientStream.FlushAsync(TestContext.Current.CancellationToken);
secondFlushCompleted.SetResult();

await tcs.Task.WaitAsync(DefaultTimeout, TestContext.Current.CancellationToken);
clientStream.Close();
await processing;
clientStream.Close();
}
await quicConnection.DisposeAsync();
}

[Fact]
Expand Down
Loading