Add unit test for release-specific SearchableEnvironment handling#11
Draft
Copilot wants to merge 3 commits intoissue_4399from
Draft
Add unit test for release-specific SearchableEnvironment handling#11Copilot wants to merge 3 commits intoissue_4399from
Copilot wants to merge 3 commits intoissue_4399from
Conversation
Currently in SearchableEnvironment we only check if the project level is larger java9plus but when constructing a release specific SearchableEnvironment this needs to take the release option into account instead. Fix eclipse-jdt#4399
Added testReleaseSpecificReconciliation() to verify that SearchableEnvironment correctly enables Java 9+ features based on the release attribute of source folders, not just the project compliance level. The test validates the fix for issue eclipse-jdt#4399 where code in a release=21 folder can correctly reference types and members across different release levels (base src, release=9, and release=21) even when the project uses JCL18_LIB. Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unit test for ReconcilerMultiRelease feature
Add unit test for release-specific SearchableEnvironment handling
Oct 22, 2025
47cfb3e to
64eb2e5
Compare
12fad88 to
6165d65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a comprehensive unit test to validate the fix for issue eclipse-jdt#4399, which addresses how
SearchableEnvironmentdetermines whether to enable Java 9+ features (like module support) when processing release-specific source folders.Background
In PR eclipse-jdt#4529,
SearchableEnvironment.javawas updated to check both thereleaseparameter and the project compliance level when determining if Java 9+ features should be enabled:Previously, only the project compliance level was checked, which meant that source folders with
release=9or higher would not have Java 9+ features enabled if the overall project was set to Java 8 or lower.Test Implementation
This PR adds
testReleaseSpecificReconciliation()toReconcilerMultiReleaseTeststo verify the fix works correctly. The test:JCL18_LIBbut includes source folders withrelease=9andrelease=21attributesrelease=21folder can reference:release=9folderrelease=21folderSearchableEnvironmentcorrectly uses the release attribute to enable Java 9+ featuresExample Scenario
The test validates this multi-release structure:
The test ensures that reconciliation of
D.javacompletes without errors, validating that the release-specificSearchableEnvironmentcorrectly resolves all types and members across different release levels.Fixes eclipse-jdt#4399
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
repo.eclipse.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/eclipse.jdt.core/eclipse.jdt.core org.codehaus.plexus.classworlds.launcher.Launcher clean compile -pl org.eclipse.jdt.core.tests.model -am -DskipTests(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.