Skip to content

Fix flaky PluginBasedLaunchTest by synchronizing PluginRegistry after target load #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix flaky PluginBasedLaunchTest by synchronizing PluginRegistry after target load #73

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
848c703
Initial plan
Copilot Nov 6, 2025
6064259
Fix test flakiness by waiting for PluginRegistry sync after target load
Copilot Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/ui/tests/util/TargetPlatformUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ public static void loadAndSetTarget(ITargetDefinition target) throws Interrupted
if (!result.isOK()) {
throw new AssertionError(result.getMessage(), result.getException());
}

// Wait for any follow-up jobs (e.g., PluginRegistry updates) to complete
// This ensures that the PluginRegistry is fully synchronized with the new target
TestUtils.waitForJobs("loadAndSetTarget", 100, 10000);
}

private static List<NameVersionDescriptor> addRunningPlatformBundles(Collection<ITargetLocation> bundleContainers,
Expand Down