Fix CGPDFContextCreateWithURL JNI binding for macOS compilation#18
Draft
Fix CGPDFContextCreateWithURL JNI binding for macOS compilation#18
Conversation
Changed the mediaBox parameter from 'flags=struct' to 'cast=(const CGRect *)' in OS.java and updated the corresponding os.c generated code to pass lparg1 as a pointer instead of dereferencing it. This fixes the compilation error on macOS where the API expects a pointer to CGRect, not the struct itself. Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix errors in PDF support on mac environment
Fix CGPDFContextCreateWithURL JNI binding for macOS compilation
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS native code for PDF support failed to compile due to incorrect JNI parameter marshalling in
CGPDFContextCreateWithURL.Changes
mediaBoxparameter annotation fromflags=structtocast=(const CGRect *)to match the macOS API signatureTechnical Detail
The JNI generator was dereferencing the CGRect pointer when the Core Graphics API expects a pointer:
API signature:
CGPDFContextCreateWithURL(CFURLRef url, const CGRect * __nullable mediaBox, CFDictionaryRef __nullable auxiliaryInfo)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ci.eclipse.org/usr/bin/curl curl -s REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.