Document query parameter parsing bug in PR #1217#151
Draft
Copilot wants to merge 3 commits into
Draft
Conversation
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
…mments Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address review comments in pull request 1217
Document query parameter parsing bug in PR #1217
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR eclipse-equinox#1217 attempts to add query parameter support to bundle resource URLs but the implementation is broken. All 8 tests fail with
url.getQuery()returningnull.Issue
The
parseURL()method inBundleResourceHandler.javahas extraction logic for query/fragment (lines 100-118) but it doesn't work:Test failures:
Investigation Results
Attempted fixes:
url.getQuery()(pre-parsed by Java URL class) → nullspecsubstring → query not found in specstrparameter → still failsRoot cause unclear. Likely related to OSGi's
PlurlStreamHandler/PlurlSettermechanism or how Java URL class passes spec to custom protocol handlers.Review Comment Status
The review asks for tests to verify "both URL parsing AND openConnection + reading content". Cannot add openConnection tests until parsing works. Tests at lines 180-225 already verify both, but fail due to parsing bug.
Next steps: Debug and fix query parameter extraction, then address review comments.
See
INVESTIGATION_NOTES.mdfor detailed analysis.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.