Skip to content

(BETA) LC-173: Migrate LambdaCurry/forms to ShadCN tailwind V4#37

Merged
jaruesink merged 59 commits intomainfrom
gen/85446350-51fe-4d9e-8972-3edc10a9b2cd
Apr 17, 2025
Merged

(BETA) LC-173: Migrate LambdaCurry/forms to ShadCN tailwind V4#37
jaruesink merged 59 commits intomainfrom
gen/85446350-51fe-4d9e-8972-3edc10a9b2cd

Conversation

@codegen-sh
Copy link
Copy Markdown
Contributor

@codegen-sh codegen-sh Bot commented Mar 18, 2025

Description

This PR migrates the LambdaCurry/forms repository to ShadCN tailwind V4 as specified in LC-173.

Changes Made

  1. Updated Tailwind CSS to V4

    • Updated the tailwind dependency to v4.0.0
    • Changed darkMode: ['class'] to darkMode: 'class' in tailwind config
  2. Updated CSS variables to use the new @theme directive

    • Refactored CSS variables in main.css to use the new @theme directive
    • Moved CSS variables from :root to @layer base { @theme { ... } }
    • Updated dark mode theme variables to use the same pattern
  3. Removed forwardRef usage and added data-slot attributes

    • Refactored components to use function components instead of forwardRef
    • Added data-slot attributes to components for better styling control
    • Updated component interfaces to match the new structure
  4. Updated component styling

    • Ensured all components use the updated styling approach
    • Maintained existing functionality while updating to the new pattern

Components Updated

  • Button
  • Label
  • Checkbox
  • Form components (FormItem, FormLabel, FormControl, FormDescription, FormMessage)

Testing

All components should maintain their existing functionality while being compatible with Tailwind CSS V4.

Related Issues

Resolves LC-173

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 18, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

jaruesink and others added 11 commits March 19, 2025 20:16
LC-177: Migrate LambdaCurry/forms to latest React Router and React version
…uter; adjust Storybook configurations accordingly
…zation and PR previews

- Added `noNamespaceImport` option to `biome.json` for better TypeScript handling.
- Enhanced README with detailed instructions for PR previews and GitHub environment setup.
- Updated `yarn.lock` to reflect dependency changes, including `react-day-picker` and `remix-hook-form`.
- Introduced new GitHub Actions workflow for automatic PR previews.
- Added custom components documentation for form elements, ensuring type safety and flexibility.
- Refactored checkbox and radio group components to support custom component injection.
…r integration

- Upgraded  from version 18 to 19 in  and .
- Replaced  with  in multiple story files to support React Router.
- Adjusted import paths for components in CSS and story files for consistency.
- Enhanced checkbox and radio group components with additional data attributes for better accessibility.
@jaruesink jaruesink marked this pull request as ready for review March 21, 2025 21:10
@jaruesink jaruesink changed the title LC-173: Migrate LambdaCurry/forms to ShadCN tailwind V4 (BETA) LC-173: Migrate LambdaCurry/forms to ShadCN tailwind V4 Mar 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 21, 2025

📝 Storybook Preview: View Storybook

This preview will be updated automatically when you push new changes to this PR.

Note: The preview will be available after the workflow completes and the PR is approved for deployment.

codegen-sh Bot and others added 5 commits April 1, 2025 19:09
…tack types, improving code clarity and consistency. Clean up JSX formatting for better readability across data table files.
…omponents and cmdk package. Refactor form components for improved readability and consistency, including type imports for React. Enhance DataTableRouterForm with auto-submit functionality on filter changes.
…sed submitHandlers and update route path. Delete unused data table story files for improved project clarity.
jaruesink and others added 21 commits April 5, 2025 00:32
…andling. Introduce sleep helper for delays, ensuring robust interaction testing. Commented out dropdown menu play function for future implementation.
…rm-v7

Update remix-hook-form to v7.0.0 for React Router 7 compatibility
…n handling. Added skeleton row IDs for loading state and optimized filter logic in the toolbar. Updated imports for better type usage.
…and refactor storybook example. Updated to use DropdownMenuSelectItem for rendering options and improved play function for better interaction testing.
…act-router

Replace nuqs with React Router 7 features in data table component
Implement Data Table Component with ShadCN and TanStack (LC-187)
- Migrate to latest React Router and React version
- Upgrade to ShadCN tailwind V4
- Optimize dependencies (move remix-router to dev dependencies)
- Update Storybook configurations and documentation
- Improve component customization support
- Enhanced radio group component styling
- Migrate to latest React Router and React version
- Upgrade to ShadCN tailwind V4
- Optimize dependencies (move remix-router to dev dependencies)
- Update Storybook configurations and documentation
- Improve component customization support
- Enhanced radio group component styling
- Migrate to latest React Router and React version
- Upgrade to ShadCN tailwind V4
- Optimize dependencies (move remix-router to dev dependencies)
- Update Storybook configurations and documentation
- Improve component customization support
- Enhanced radio group component styling
- Migrate to latest React Router and React version
- Upgrade to ShadCN tailwind V4
- Optimize dependencies (move remix-router to dev dependencies)
- Update Storybook configurations and documentation
- Improve component customization support
- Enhanced radio group component styling
… story assertions

- Changed date validation in form schema to use z.coerce.date for better handling of date inputs.
- Added assertion to check for the presence of submission confirmation text in the story.
@jaruesink jaruesink merged commit 1ddf1d2 into main Apr 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants