Remove @remix-run dependencies from docs app (LC-178)#39
Closed
codegen-sh[bot] wants to merge 1 commit intogen/85446350-51fe-4d9e-8972-3edc10a9b2cdfrom
Closed
Remove @remix-run dependencies from docs app (LC-178)#39codegen-sh[bot] wants to merge 1 commit intogen/85446350-51fe-4d9e-8972-3edc10a9b2cdfrom
codegen-sh[bot] wants to merge 1 commit intogen/85446350-51fe-4d9e-8972-3edc10a9b2cdfrom
Conversation
|
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the build error in Storybook when running
yarn build-storybookas described in LC-178.Problem
The build was failing with the following error:
This occurred because Vite/Rollup was trying to bundle the Remix dependencies, which should be treated as external.
Solution
The PR completely removes all @remix-run dependencies from the docs app by:
apps/docs/src/lib/storybook/remix-mock.tsxThis approach completely eliminates the need for any Remix dependencies in the docs app, which resolves the build error.
Changes
apps/docs/src/lib/storybook/remix-mock.tsxwith mock implementations of:Testing
yarn build-storybooknow completes successfully without any dependency on Remix packagesRelated Issues
Fixes LC-178