diff --git a/.github/workflows/github-pages.yml b/.github/workflows/github-pages.yml index 63eccfa7..de30a644 100644 --- a/.github/workflows/github-pages.yml +++ b/.github/workflows/github-pages.yml @@ -52,7 +52,9 @@ jobs: - name: Upload artifact uses: actions/upload-pages-artifact@v3 with: + # Don't remove PR previews when deploying the main branch path: 'apps/docs/storybook-static' + retention-days: 30 - name: Deploy to GitHub Pages id: deployment diff --git a/.github/workflows/pr-preview.yml b/.github/workflows/pr-preview.yml new file mode 100644 index 00000000..ea88c148 --- /dev/null +++ b/.github/workflows/pr-preview.yml @@ -0,0 +1,167 @@ +name: Deploy PR Preview + +on: + pull_request: + types: + - opened + - reopened + - synchronize + - closed + +# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages +permissions: + contents: read + pages: write + id-token: write + pull-requests: write + +# Allow only one concurrent deployment per PR +concurrency: + group: pr-preview-${{ github.event.pull_request.number }} + cancel-in-progress: true + +jobs: + # Build job + build: + runs-on: ubuntu-latest + # Don't run on closed PRs + if: github.event.action != 'closed' + + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Setup Node.js + uses: actions/setup-node@v3 + with: + node-version: '22.9.0' + + - name: Setup Yarn Corepack + run: corepack enable + + - name: Install dependencies + run: yarn install + + - name: Build Storybook + run: yarn build-storybook + + # Verify the build output + - name: Verify build output + run: | + echo "Checking build output directory..." + ls -la apps/docs/storybook-static + echo "Checking for index.html..." + if [ -f apps/docs/storybook-static/index.html ]; then + echo "index.html exists" + else + echo "index.html does not exist" + exit 1 + fi + + # Add a comment to the PR with the preview URL + - name: Comment PR + uses: actions/github-script@v6 + with: + script: | + const previewUrl = `https://lambda-curry.github.io/forms/pr-${context.issue.number}/`; + const commentBody = `📝 **Storybook Preview**: [View Storybook](${previewUrl}) + + This preview will be updated automatically when you push new changes to this PR. + + > Note: The preview will be available after the workflow completes and the PR is approved for deployment.`; + + // Get existing comments + const comments = await github.rest.issues.listComments({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + }); + + // Check if we already have a comment + const botComment = comments.data.find(comment => + comment.user.login === 'github-actions[bot]' && + comment.body.includes('Storybook Preview') + ); + + if (botComment) { + // Update existing comment + await github.rest.issues.updateComment({ + owner: context.repo.owner, + repo: context.repo.repo, + comment_id: botComment.id, + body: commentBody + }); + } else { + // Create new comment + await github.rest.issues.createComment({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + body: commentBody + }); + } + + # Create PR-specific directory structure + - name: Create PR-specific directory + run: | + mkdir -p pr-preview/pr-${{ github.event.pull_request.number }} + cp -r apps/docs/storybook-static/* pr-preview/pr-${{ github.event.pull_request.number }}/ + + # Upload the artifact for the deployment job + - name: Upload artifact + uses: actions/upload-pages-artifact@v3 + with: + path: pr-preview + retention-days: 30 + + # Deploy job + deploy: + needs: build + runs-on: ubuntu-latest + if: github.event.action != 'closed' + + # Use a specific environment with protection rules + # This ensures only approved PRs can deploy + environment: + name: pr-preview + url: ${{ steps.deployment.outputs.page_url }} + + steps: + - name: Setup Pages + uses: actions/configure-pages@v5 + + - name: Deploy to GitHub Pages + id: deployment + uses: actions/deploy-pages@v4 + + # Clean up when PR is closed + cleanup: + runs-on: ubuntu-latest + if: github.event.action == 'closed' + permissions: + contents: write + + steps: + - name: Checkout + uses: actions/checkout@v4 + with: + ref: gh-pages + + - name: Delete PR Preview + run: | + PR_NUMBER="${{ github.event.pull_request.number }}" + PR_PREVIEW_PATH="pr-preview/pr-$PR_NUMBER" + + if [ -d "$PR_PREVIEW_PATH" ]; then + echo "Removing PR preview at $PR_PREVIEW_PATH" + rm -rf "$PR_PREVIEW_PATH" + + # Commit and push the changes + git config user.name "GitHub Actions" + git config user.email "actions@github.com" + git add -A + git commit -m "Remove PR preview for PR #$PR_NUMBER" || echo "No changes to commit" + git push + else + echo "PR preview directory not found" + fi \ No newline at end of file diff --git a/README.md b/README.md index d7e71b87..631a15b3 100644 --- a/README.md +++ b/README.md @@ -1,21 +1,69 @@ -# Welcome! +# Lambda Curry Forms Checkout our [Storybook Documentation](https://lambda-curry.github.io/forms/?path=/docs/0-1-hello-world-start-here--docs) to see the components in action and get started. +A form library for React applications. + ## Getting Started -Step 1: Install the dependencies +Step 1: Install dependencies + ```bash yarn install ``` -Note: You may need to enable corepack for yarn v4 by running `corepack enable` before installing the dependencies. - - Step 2: Start Storybook + ```bash yarn storybook ``` +## Development + +### PR Previews + +When you create a pull request, a preview of the Storybook documentation will be automatically deployed. You can find the link to the preview in the PR comments. This allows you to review changes to the documentation and components before merging. + +Preview URLs follow this format: +``` +https://lambda-curry.github.io/forms/pr-preview/pr-[PR_NUMBER]/ +``` + +#### How PR Previews Work +The PR preview system: +1. Builds the Storybook documentation for each PR +2. Deploys it to a PR-specific directory on the `gh-pages` branch +3. Adds a comment to the PR with a link to the preview +4. **Automatically updates the preview when you push new changes to the PR** +5. Cleans up the preview when the PR is closed + +#### GitHub Environment Setup + +For PR previews to work properly, you need to set up a GitHub environment: + +1. Go to your repository settings +2. Navigate to "Environments" +3. Create a new environment named `pr-preview` +4. Configure environment protection rules as needed: + - You can require reviewers to approve deployment + - You can limit deployment to specific branches + - You can add wait timers before deployment + +The main branch will continue to deploy to the `github-pages` environment. + +#### Troubleshooting PR Previews + +If you encounter a 404 error when accessing the PR preview: + +1. Make sure the PR build has completed successfully by checking the GitHub Actions tab +2. Verify that the repository has GitHub Pages enabled and configured to deploy from the `gh-pages` branch +3. Check that the PR preview comment contains the correct URL +4. Ensure the PR has been approved for deployment if environment protection rules are enabled +5. Try clearing your browser cache or using an incognito window + +The PR preview is deployed to the `gh-pages` branch in a directory structure like: +``` +/pr-preview/pr-[PR_NUMBER]/ +```