Skip to content

Implement DataTableRouterForm and remove Input component (LC-187)#45

Closed
codegen-sh[bot] wants to merge 17 commits intomainfrom
codegen-data-table-lc187
Closed

Implement DataTableRouterForm and remove Input component (LC-187)#45
codegen-sh[bot] wants to merge 17 commits intomainfrom
codegen-data-table-lc187

Conversation

@codegen-sh
Copy link
Copy Markdown
Contributor

@codegen-sh codegen-sh Bot commented Apr 1, 2025

This PR implements the requested changes from PR #44 comments:

  1. Removed the new Input component and updated the data table to use the existing TextInput component

    • Deleted input.tsx file
    • Removed the export from index.ts
    • Updated data-table-toolbar.tsx to use TextInput instead
  2. Created a new DataTableRouterForm component that integrates with React Router forms:

    • Uses React Router's Form component for form submission
    • Shows a loading state while data is being fetched
    • Updates data when the router action responds
    • Submits the form automatically when filters change
  3. Added DataTableRouterToolbar that uses the existing TextInput component and handles form submission

  4. Updated DataTableFacetedFilter to support form submission when filters change

    • Added formMode prop to control whether to render hidden inputs for form submission
    • Added hidden inputs for selected filter values
  5. Created a comprehensive example in data-table-router-form.stories.tsx that demonstrates:

    • Form-based filtering with automatic submission
    • Loading state while waiting for data
    • Server-side filtering and pagination
    • URL-based state management

The implementation follows the same pattern used in the forms library with withReactRouterStubDecorator for mocking backend requests in Storybook, showing how the component would work in a real application with React Router.

codegen-bot and others added 17 commits March 18, 2025 21:56
LC-177: Migrate LambdaCurry/forms to latest React Router and React version
…uter; adjust Storybook configurations accordingly
…zation and PR previews

- Added `noNamespaceImport` option to `biome.json` for better TypeScript handling.
- Enhanced README with detailed instructions for PR previews and GitHub environment setup.
- Updated `yarn.lock` to reflect dependency changes, including `react-day-picker` and `remix-hook-form`.
- Introduced new GitHub Actions workflow for automatic PR previews.
- Added custom components documentation for form elements, ensuring type safety and flexibility.
- Refactored checkbox and radio group components to support custom component injection.
…r integration

- Upgraded  from version 18 to 19 in  and .
- Replaced  with  in multiple story files to support React Router.
- Adjusted import paths for components in CSS and story files for consistency.
- Enhanced checkbox and radio group components with additional data attributes for better accessibility.
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 1, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jaruesink jaruesink closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants