Skip to content

Add custom Input component support to TextField#55

Merged
jaruesink merged 5 commits intomainfrom
codegen-bot/add-custom-input-to-textfield
Apr 30, 2025
Merged

Add custom Input component support to TextField#55
jaruesink merged 5 commits intomainfrom
codegen-bot/add-custom-input-to-textfield

Conversation

@codegen-sh
Copy link
Copy Markdown
Contributor

@codegen-sh codegen-sh Bot commented Apr 30, 2025

This PR updates the TextField component to support custom Input components via the components prop.

Changes:

  1. Updated the TextField component to use a custom Input component if provided in the components prop
  2. Added a new storybook example that demonstrates how to use custom Input components with TextField
  3. Created two example custom inputs: a rounded input with custom styling and a search input with an icon

Implementation Details:

  • The TextField component now checks for components?.Input and uses it if available, otherwise falls back to the default TextInput
  • The custom input components in the storybook example use React.forwardRef to properly forward refs to the input element
  • Added detailed documentation in the storybook example explaining how to create and use custom input components

This enhancement allows for greater flexibility and customization of the TextField component, making it easier to create custom form inputs while maintaining the form functionality.


💻 View my workAbout Codegen

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codegen-sh
Copy link
Copy Markdown
Contributor Author

codegen-sh Bot commented Apr 30, 2025

Hey! 👋 I see one of the checks failed. I am on it! 🫡

💻 View my work

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2025

📝 Storybook Preview: View Storybook

This preview will be updated automatically when you push new changes to this PR.

Note: The preview will be available after the workflow completes and the PR is approved for deployment.

@codegen-sh
Copy link
Copy Markdown
Contributor Author

codegen-sh Bot commented Apr 30, 2025

Hey! 👋 I see one of the checks failed. I am on it! 🫡

💻 View my work

@codegen-sh
Copy link
Copy Markdown
Contributor Author

codegen-sh Bot commented Apr 30, 2025

I've fixed the failing check suite in PR #55. The issue was related to the TextField component's implementation of custom Input components.

The changes I made:

  1. Updated the TextInputProps interface in text-field.tsx to properly type the custom Input component with React.ForwardRefExoticComponent<InputProps & React.RefAttributes<HTMLInputElement>>, ensuring proper type checking for custom input components.

  2. Improved the TextField component in the remix-hook-form package to properly merge custom components with default form components, preserving any custom Input component passed via props.

These changes ensure that custom Input components are properly typed and handled throughout the component hierarchy, which should resolve the test failures.

The fix has been pushed to the original PR branch.

💻 View my work • React 👍 or 👎

… component to accept a more flexible Input prop type.
- Update package version in components to reflect recent changes.
@jaruesink jaruesink marked this pull request as ready for review April 30, 2025 16:16
@jaruesink jaruesink merged commit 2dc3e5b into main Apr 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant