LC-219: Implement bazza/ui Canary Branch Filter Components#56
LC-219: Implement bazza/ui Canary Branch Filter Components#56codegen-sh[bot] wants to merge 6 commits intomainfrom
Conversation
|
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hey! 👋 I see one of the checks failed. I am on it! 🫡 |
|
✅ Fixed failing check in this commit. The issue was that the Storybook story file was missing the proper meta export format required by Storybook v8. |
|
Hey! 👋 I see one of the checks failed. I am on it! 🫡 |
|
✅ Fixed failing check in this commit. The issue was that the data-table-filter component was missing several required dependencies:
The main package now builds successfully. There are still some issues with the storybook build, but those don't affect the main functionality of the components. 💻 View my work • React 👍 or 👎 |
|
Hey! 👋 I see one of the checks failed. I am on it! 🫡 |
|
✅ Fixed failing check in this commit. The issue was incorrect import paths in the data-table-filter.stories.tsx file. I updated the imports to use the aliased paths defined in the vite.config.mjs file instead of relative paths. |
|
📝 Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
Overview
This PR implements the advanced data table filter components from the bazza/ui canary branch into the forms repository, replacing the current filter implementation as described in LC-219.
Features
Implementation Details
The implementation includes:
New API Structure: The new API requires different props:
Column Configuration: Columns are configured using the
defineMetahelper:Internationalization: Support for multiple languages (English, Spanish, French, German)
Filter Types: Support for various data types (text, number, date, option, multiOption)
Demo Implementation: A comprehensive demo in the docs app showing all features
Migration Guide
For existing users of the DataTableFacetedFilter component, migration involves:
metapropertyfilterFnfunction for filteringTesting
The implementation has been tested with various data types and filter operations. A comprehensive demo is included in the docs app.
Documentation
Detailed documentation is provided in the README.md file in the data-table-filter directory.
💻 View my work • About Codegen