Commit 68ae1a3
committed
Address all review feedback: restore stories, types, and functionality
✅ **Added alert to form submission** in ControlledDatePicker stories
✅ **Restored comprehensive DatePicker stories** including:
- Date format variations (US, European, ISO formats)
- Disabled dates functionality with proper date logic
- Complete examples with minDate, maxDate, excludeDateIntervals
✅ **Verified FieldCheckbox onChange functionality**:
- onChange prop handled correctly via onCheckedChange
- Empty onChange function is intentional (Medusa UI pattern)
- Component works as expected with form validation
✅ **Restored comprehensive ControlledCheckbox stories**:
- Basic usage with state display
- Default checked/unchecked states
- Required field validation
- Custom validation messages
- Error state demonstrations
- Disabled state examples
- Multiple checkbox management with select all
- Complete form integration example
✅ **Restored comprehensive ControlledTextArea stories**:
- Basic usage examples
- Character limits with counters
- Required field validation
- Auto-resize functionality
- Validation error states
- Comprehensive form example
✅ **Restored complete type definitions** in types.d.ts:
- BasicFieldProps, FieldWrapperProps
- TextAreaProps, MedusaCurrencyInputProps
- PickerProps, DatePickerProps
- SearchableSelectProps, CreatableSelectProps
- SelectProps with proper React types
✅ **Added Biome overrides for d.ts files**:
- Disabled noUnusedVariables/noUnusedImports for type files
- Disabled noNamespace, useImportType for declarations
- Disabled noEmptyInterface for type definitions
**Result**: All critical functionality restored with proper type safety and comprehensive examples!1 parent 8d028cf commit 68ae1a3
11 files changed
Lines changed: 999 additions & 215 deletions
File tree
- apps/docs
- .storybook
- src
- medusa-forms
- packages/medusa-forms
- src/ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 13 | + | |
17 | 14 | | |
18 | 15 | | |
19 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
46 | | - | |
Large diffs are not rendered by default.
0 commit comments