Conversation
- Update Storybook packages from 9.0.1 to 9.0.6 - Add @storybook/test package for modern interaction testing - Update test-runner to 0.22.1 - Improve simple-server.js error handling and formatting - Update storybook-testing.mdc with modern interaction testing patterns: - Add play functions documentation - Add canvas queries and userEvent patterns - Add step grouping for complex workflows - Adapt examples for react-hook-form + @medusajs/ui context - Update version references and testing workflows This brings medusa-forms in line with the latest Storybook patterns from the forms repository while maintaining compatibility with the Medusa Forms component architecture.
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
📝 Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings the medusa-forms repository in line with the latest Storybook patterns from the forms repository, updating to modern interaction testing capabilities while maintaining compatibility with the Medusa Forms component architecture.
Changes Made
📦 Package Updates
🛠️ Configuration Improvements
📚 Documentation & Rules Updates
🎯 Key Features Added
Testing
✅ Dependencies: All packages install successfully
✅ Build: Storybook builds without errors
✅ Compatibility: Existing stories remain functional
Context
This update mirrors the recent improvements made to the forms repository (PR #97) while adapting the patterns for the medusa-forms context. The changes enable modern interaction testing capabilities while maintaining the existing component architecture using react-hook-form and @medusajs/ui.
Next Steps
After this PR is merged, developers can:
💻 View my work • About Codegen