Merge branch 'main' of https://github.com/lambda-curry/medusa-plugins into mohsen/360t-898-braintree-fraud-detection-cases-are-not-covered

Author: lcmohsen

plugins/braintree-payment/README.md

@@ -61,6 +61,7 @@ dependencies:[Modules.CACHE]
   id: 'braintree',
   options: {
     environment: process.env.BRAINTREE_ENVIRONMENT || (process.env.NODE_ENV !== 'production' ? 'sandbox' : 'production'),
+    defaultCurrencyCode: "USD",
     merchantId: process.env.BRAINTREE_MERCHANT_ID,
     publicKey: process.env.BRAINTREE_PUBLIC_KEY,
     privateKey: process.env.BRAINTREE_PRIVATE_KEY,
@@ -75,16 +76,19 @@ dependencies:[Modules.CACHE]
 #### Options
 
 - **merchantId**: Your Braintree Merchant ID.
+- **defaultCurrencyCode**: An optional field to indicate default currency code
 - **publicKey**: Your Braintree Public Key.
 - **privateKey**: Your Braintree Private Key.
 - **webhookSecret**: Secret for validating Braintree webhooks.
 - **enable3DSecure**: Enable 3D Secure authentication (`true` or `false`).
 - **savePaymentMethod**: Save payment methods for future use (default: `true`).
 - **autoCapture**: Automatically capture payments (default: `true`).
+- **allowRefundOnRefunded**: Allow refund attempts on already-refunded imported transactions (default: `false`).
 
 > **Note:**
 > - `autoCapture`: If set to `true`, payments are captured automatically after authorization.
 > - `savePaymentMethod`: If set to `true`, customer payment methods are saved for future use.
+> - `allowRefundOnRefunded`: If set to `true`, the imported payment provider will gracefully handle refund attempts on transactions that have already been refunded in Braintree. Instead of throwing an error, it will log a warning and record the refund locally only. This is useful when orders are imported and later refunded directly in Braintree.
 
 ### 3D Secure Setup
 
@@ -160,4 +164,4 @@ Implementation detail: the provider passes `context.custom_fields` directly to B
 
 This plugin is licensed under the [MIT License](LICENSE).
 
-For more information, visit the [Braintree Documentation](https://developer.paypal.com/braintree/docs).  
+For more information, visit the [Braintree Documentation](https://developer.paypal.com/braintree/docs).

plugins/braintree-payment/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lambdacurry/medusa-payment-braintree",
-  "version": "0.0.15",
+  "version": "0.0.20",
   "description": "Braintree plugin for Medusa",
   "author": "Lambda Curry (https://lambdacurry.dev)",
   "license": "MIT",

plugins/braintree-payment/src/providers/payment-braintree/README.md

@@ -35,6 +35,7 @@ Add the following configuration to the `payment` section of your `medusa-config.
   id: 'braintree',
   options: {
     environment: process.env.NODE_ENV !== 'production' ? 'sandbox' : 'production',
+    defaultCurrencyCode: "USD",
     merchantId: process.env.BRAINTREE_MERCHANT_ID,
     publicKey: process.env.BRAINTREE_PUBLIC_KEY,
     privateKey: process.env.BRAINTREE_PRIVATE_KEY,
@@ -56,6 +57,7 @@ Add the following configuration to the `payment` section of your `medusa-config.
 - **enable3DSecure**: Enable 3D Secure authentication (`true` or `false`).
 - **savePaymentMethod**: Save payment methods for future use (default: `true`).
 - **autoCapture**: Automatically capture payments (default: `true`).
+- **defaultCurrencyCode**: The default currency to use. This is optional
 - **customFields**: Array of Braintree custom field API names permitted to be forwarded from `data.custom_fields`. If empty or omitted, no user-provided custom fields are sent.
 
 ## Features

plugins/braintree-payment/src/providers/payment-braintree/src/core/__tests__/braintree-base.spec.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect, jest, beforeEach, afterEach } from '@jest/globals';
+import { afterEach, beforeEach, describe, expect, it, jest } from '@jest/globals';
 import BraintreeProviderService from '../../services/braintree-provider';
 import { BraintreeConstructorArgs, BraintreePaymentSessionData } from '../braintree-base';
 
@@ -193,7 +193,7 @@ describe('BraintreeProviderService core behaviors', () => {
     gateway.transaction.find
       .mockResolvedValueOnce({ id: 't2', status: 'settling' })
       .mockResolvedValueOnce({ id: 't2', status: 'settling' });
-    gateway.transaction.refund.mockResolvedValueOnce({ transaction: { id: 'r2' } });
+    gateway.transaction.refund.mockResolvedValueOnce({ success: true, transaction: { id: 'r2' } });
 
     const result = await service.refundPayment(input);
 
@@ -238,7 +238,7 @@ describe('BraintreeProviderService core behaviors', () => {
     gateway.transaction.find
       .mockResolvedValueOnce({ id: 't2', status: 'settled' }) // retrieveTransaction
       .mockResolvedValueOnce({ id: 't2', status: 'settled' }); // updated after refund
-    gateway.transaction.refund.mockResolvedValueOnce({ transaction: { id: 'r1' } });
+    gateway.transaction.refund.mockResolvedValueOnce({ success: true, transaction: { id: 'r1' } });
 
     const result = await service.refundPayment(input);
 

plugins/braintree-payment/src/providers/payment-braintree/src/core/__tests__/braintree-import.spec.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect, jest, beforeEach } from '@jest/globals';
+import { beforeEach, describe, expect, it, jest } from '@jest/globals';
 import BraintreeImportService from '../../services/braintree-import';
 import { BraintreeConstructorArgs } from '../braintree-base';
 
@@ -49,10 +49,11 @@ describe('BraintreeImportService', () => {
       context: { idempotency_key: 'idem' },
     } as any);
     expect(init.id).toBeDefined();
+    expect(gateway.transaction.find).toHaveBeenCalledTimes(1);
+    expect(gateway.transaction.find).toHaveBeenCalledWith('t1');
 
     const auth = await service.authorizePayment({ data: init.data } as any);
     expect(auth.status).toBe('authorized');
-    expect(gateway.transaction.find).not.toHaveBeenCalled();
 
     const cap = await service.capturePayment({ data: auth.data } as any);
     expect((cap.data as any).status).toBe('captured');
@@ -83,10 +84,88 @@ describe('BraintreeImportService', () => {
     const { service, gateway } = buildService();
     const session = { transactionId: 't3', importedAsRefunded: false, refundedTotal: 1.25, status: 'captured' } as any;
     gateway.transaction.find.mockResolvedValueOnce({ id: 't3', status: 'settled' });
-    gateway.transaction.refund.mockResolvedValueOnce({ transaction: { id: 'r3' } });
+    gateway.transaction.refund.mockResolvedValueOnce({ success: true, transaction: { id: 'r3' } });
 
     const res = await service.refundPayment({ amount: 2.75, data: session } as any);
     expect(gateway.transaction.refund).toHaveBeenCalledWith('t3', '2.75');
     expect((res.data as any).refundedTotal).toBe(4.0);
   });
+
+  it('gracefully handles already-refunded transactions when allowRefundOnRefunded is enabled', async () => {
+    const logger = { info: jest.fn(), warn: jest.fn(), error: jest.fn() } as any;
+    const cache = { get: jest.fn(), set: jest.fn() } as any;
+
+    const container: BraintreeConstructorArgs = { logger, cache };
+
+    const options = {
+      environment: 'sandbox' as const,
+      merchantId: 'merchant',
+      publicKey: 'public',
+      privateKey: 'private',
+      enable3DSecure: false,
+      savePaymentMethod: false,
+      webhookSecret: 'whsec',
+      autoCapture: true,
+      allowRefundOnRefunded: true, // Enable graceful handling
+    } as any;
+
+    const service = new BraintreeImportService(container, options);
+
+    const gateway = {
+      transaction: {
+        find: jest.fn(),
+        void: jest.fn(),
+        refund: jest.fn(),
+      },
+    } as any;
+
+    (service as any).gateway = gateway;
+
+    const session = { transactionId: 't4', importedAsRefunded: false, refundedTotal: 0, status: 'captured' } as any;
+    gateway.transaction.find.mockResolvedValueOnce({ id: 't4', status: 'settled' });
+    gateway.transaction.refund.mockRejectedValueOnce(new Error('Transaction has already been refunded'));
+
+    const res = await service.refundPayment({ amount: 10, data: session } as any);
+
+    // Should not throw error, but log warning and update locally
+    expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('already refunded in Braintree'));
+    expect((res.data as any).refundedTotal).toBe(10);
+  });
+
+  it('throws error on non-refund-related errors even with allowRefundOnRefunded enabled', async () => {
+    const logger = { info: jest.fn(), warn: jest.fn(), error: jest.fn() } as any;
+    const cache = { get: jest.fn(), set: jest.fn() } as any;
+
+    const container: BraintreeConstructorArgs = { logger, cache };
+
+    const options = {
+      environment: 'sandbox' as const,
+      merchantId: 'merchant',
+      publicKey: 'public',
+      privateKey: 'private',
+      enable3DSecure: false,
+      savePaymentMethod: false,
+      webhookSecret: 'whsec',
+      autoCapture: true,
+      allowRefundOnRefunded: true,
+    } as any;
+
+    const service = new BraintreeImportService(container, options);
+
+    const gateway = {
+      transaction: {
+        find: jest.fn(),
+        void: jest.fn(),
+        refund: jest.fn(),
+      },
+    } as any;
+
+    (service as any).gateway = gateway;
+
+    const session = { transactionId: 't5', importedAsRefunded: false, refundedTotal: 0, status: 'captured' } as any;
+    gateway.transaction.find.mockResolvedValueOnce({ id: 't5', status: 'settled' });
+    gateway.transaction.refund.mockRejectedValueOnce(new Error('Network timeout'));
+
+    await expect(service.refundPayment({ amount: 10, data: session } as any)).rejects.toThrow('Network timeout');
+  });
 });