chore: address coderabbit review feedback

jaruesink · jaruesink · commit d894b777327c · 2026-02-13T11:13:07.000-06:00
diff --git a/.cursor/rules/ai-rules-generated-00-project-context.mdc b/.cursor/rules/ai-rules-generated-00-project-context.mdc
@@ -8,7 +8,7 @@ alwaysApply: true
 
 ## What This Repo Is
 
-**react-router-starter** is a monorepo starter for React Router 7 apps with best practices from reportory: Storybook, @lambdacurry/forms, Bun test + React Testing Library, and shared AI rules.
+**react-router-starter** is a monorepo starter for React Router 7 apps with best practices: Storybook, @lambdacurry/forms, Bun test + React Testing Library, and shared AI rules.
 
 ## Structure
 
@@ -54,5 +54,5 @@ Run these from `apps/todo-app` or via workspace root scripts if defined.
 ## AI Rules Workflow
 
 - **Edit source rules** in `ai-rules/`
-- **Generate platform files** with `ai-rules generate`
-- **Check sync** with `ai-rules status`
+- **Generated outputs** in `.generated-ai-rules/` and `.cursor/rules/` are maintained by repository automation
+- **Do not edit generated files directly**; change source rules in `ai-rules/`
diff --git a/.cursor/rules/ai-rules-generated-lambda-curry-forms.mdc b/.cursor/rules/ai-rules-generated-lambda-curry-forms.mdc
@@ -105,17 +105,6 @@ export const action = async ({ request }: ActionFunctionArgs) => {
 };
 ```
 
-## Advanced Patterns
-
-### Conditional Fields
-```typescript
-const watchAccountType = methods.watch('accountType');
-
-{watchAccountType === 'business' && (
-  <TextField name="companyName" label="Company Name" />
-)}
-```
-
 ## Available Form Components
 
 ### TextField Component
diff --git a/.cursor/rules/ai-rules-generated-storybook.mdc b/.cursor/rules/ai-rules-generated-storybook.mdc
@@ -18,6 +18,7 @@ alwaysApply: false
 Components that use `Link`, `useNavigate`, `useFetcher`, or `useHref` need router context. Use a global decorator in `preview.tsx`:
 
 ```tsx
+import type { Preview } from '@storybook/react';
 import type { ComponentType } from 'react';
 import { createMemoryRouter, RouterProvider } from 'react-router-dom';
 
diff --git a/.cursor/rules/ai-rules-generated-ui-components.mdc b/.cursor/rules/ai-rules-generated-ui-components.mdc
@@ -17,6 +17,7 @@ alwaysApply: true
 import * as React from 'react';
 import { cva, type VariantProps } from 'class-variance-authority';
 import { cn } from '@todo-starter/utils';
+import { Slot } from '@radix-ui/react-slot';
 
 const buttonVariants = cva(
   'base-classes',
diff --git a/FORMS_INTEGRATION.md b/FORMS_INTEGRATION.md
@@ -13,7 +13,7 @@ This document outlines the integration of the `@lambdacurry/forms` library into
 
 ### AI Rules
 - Added `ai-rules/lambda-curry-forms.md` with comprehensive guidelines for using the forms library
-- Generate agent-specific outputs with `ai-rules generate` (AGENTS, Cursor rules, etc.)
+- Generated outputs in `ai-rules/.generated-ai-rules/` and `.cursor/rules/` are managed by repository automation; update source rules instead of editing generated files directly.
 
 ### Components Updated
 
diff --git a/ai-rules/.generated-ai-rules/ai-rules-generated-00-project-context.md b/ai-rules/.generated-ai-rules/ai-rules-generated-00-project-context.md
@@ -2,7 +2,7 @@
 
 ## What This Repo Is
 
-**react-router-starter** is a monorepo starter for React Router 7 apps with best practices from reportory: Storybook, @lambdacurry/forms, Bun test + React Testing Library, and shared AI rules.
+**react-router-starter** is a monorepo starter for React Router 7 apps with best practices: Storybook, @lambdacurry/forms, Bun test + React Testing Library, and shared AI rules.
 
 ## Structure
 
@@ -48,5 +48,5 @@ Run these from `apps/todo-app` or via workspace root scripts if defined.
 ## AI Rules Workflow
 
 - **Edit source rules** in `ai-rules/`
-- **Generate platform files** with `ai-rules generate`
-- **Check sync** with `ai-rules status`
+- **Generated outputs** in `.generated-ai-rules/` and `.cursor/rules/` are maintained by repository automation
+- **Do not edit generated files directly**; change source rules in `ai-rules/`
diff --git a/ai-rules/.generated-ai-rules/ai-rules-generated-lambda-curry-forms.md b/ai-rules/.generated-ai-rules/ai-rules-generated-lambda-curry-forms.md
@@ -99,17 +99,6 @@ export const action = async ({ request }: ActionFunctionArgs) => {
 };
 ```
 
-## Advanced Patterns
-
-### Conditional Fields
-```typescript
-const watchAccountType = methods.watch('accountType');
-
-{watchAccountType === 'business' && (
-  <TextField name="companyName" label="Company Name" />
-)}
-```
-
 ## Available Form Components
 
 ### TextField Component
diff --git a/ai-rules/.generated-ai-rules/ai-rules-generated-storybook.md b/ai-rules/.generated-ai-rules/ai-rules-generated-storybook.md
@@ -12,6 +12,7 @@
 Components that use `Link`, `useNavigate`, `useFetcher`, or `useHref` need router context. Use a global decorator in `preview.tsx`:
 
 ```tsx
+import type { Preview } from '@storybook/react';
 import type { ComponentType } from 'react';
 import { createMemoryRouter, RouterProvider } from 'react-router-dom';
 
diff --git a/ai-rules/.generated-ai-rules/ai-rules-generated-ui-components.md b/ai-rules/.generated-ai-rules/ai-rules-generated-ui-components.md
@@ -11,6 +11,7 @@
 import * as React from 'react';
 import { cva, type VariantProps } from 'class-variance-authority';
 import { cn } from '@todo-starter/utils';
+import { Slot } from '@radix-ui/react-slot';
 
 const buttonVariants = cva(
   'base-classes',
diff --git a/ai-rules/00-project-context.md b/ai-rules/00-project-context.md
@@ -8,7 +8,7 @@ fileMatching: "**/*"
 
 ## What This Repo Is
 
-**react-router-starter** is a monorepo starter for React Router 7 apps with best practices from reportory: Storybook, @lambdacurry/forms, Bun test + React Testing Library, and shared AI rules.
+**react-router-starter** is a monorepo starter for React Router 7 apps with best practices: Storybook, @lambdacurry/forms, Bun test + React Testing Library, and shared AI rules.
 
 ## Structure
 
@@ -54,5 +54,5 @@ Run these from `apps/todo-app` or via workspace root scripts if defined.
 ## AI Rules Workflow
 
 - **Edit source rules** in `ai-rules/`
-- **Generate platform files** with `ai-rules generate`
-- **Check sync** with `ai-rules status`
+- **Generated outputs** in `.generated-ai-rules/` and `.cursor/rules/` are maintained by repository automation
+- **Do not edit generated files directly**; change source rules in `ai-rules/`
diff --git a/ai-rules/lambda-curry-forms.md b/ai-rules/lambda-curry-forms.md
@@ -105,17 +105,6 @@ export const action = async ({ request }: ActionFunctionArgs) => {
 };
 ```
 
-## Advanced Patterns
-
-### Conditional Fields
-```typescript
-const watchAccountType = methods.watch('accountType');
-
-{watchAccountType === 'business' && (
-  <TextField name="companyName" label="Company Name" />
-)}
-```
-
 ## Available Form Components
 
 ### TextField Component
@@ -270,4 +259,4 @@ test('form works without JS', async ({ page }) => {
 });
 ```
 
-This modern form framework provides type-safe, accessible, and performant forms with minimal boilerplate while maintaining full customization capabilities.
+This modern form framework provides type-safe, accessible, and performant forms with minimal boilerplate while maintaining full customization capabilities.
diff --git a/ai-rules/storybook.md b/ai-rules/storybook.md
@@ -18,6 +18,7 @@ fileMatching: "apps/**/.storybook/**/*.ts, apps/**/.storybook/**/*.tsx, apps/**/
 Components that use `Link`, `useNavigate`, `useFetcher`, or `useHref` need router context. Use a global decorator in `preview.tsx`:
 
 ```tsx
+import type { Preview } from '@storybook/react';
 import type { ComponentType } from 'react';
 import { createMemoryRouter, RouterProvider } from 'react-router-dom';
 
@@ -50,4 +51,4 @@ const preview: Preview = {
 
 - Keep stories colocated with components (`component.stories.tsx`)
 - Use args and controls for props; use decorators for router and providers
-- Prefer one default export with a descriptive title; use named exports for variants
+- Prefer one default export with a descriptive title; use named exports for variants
diff --git a/ai-rules/ui-components.md b/ai-rules/ui-components.md
@@ -17,6 +17,7 @@ fileMatching: "packages/ui/**/*.tsx, packages/ui/**/*.ts, apps/**/app/**/*.tsx"
 import * as React from 'react';
 import { cva, type VariantProps } from 'class-variance-authority';
 import { cn } from '@todo-starter/utils';
+import { Slot } from '@radix-ui/react-slot';
 
 const buttonVariants = cva(
   'base-classes',
diff --git a/apps/todo-app/app/globals.css b/apps/todo-app/app/globals.css
@@ -1,10 +1,8 @@
 @import "tailwindcss";
-
+@import "tw-animate-css";
 @source "../**/*.{js,ts,jsx,tsx}";
 @source "../../../packages/ui/src/components/ui/**/*.{ts,tsx}";
 @source "../../../node_modules/@lambdacurry/forms/dist/**/*.{js,ts,jsx,tsx}";
-@plugin "tailwindcss-animate";
-
 @custom-variant dark (&:where(.dark, .dark *));
 
 @theme inline {
diff --git a/apps/todo-app/package.json b/apps/todo-app/package.json
@@ -36,12 +36,12 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.1.0",
     "@testing-library/user-event": "^14.6.1",
-    "bun-types": "^1.3.5",
     "@types/node": "^20",
+    "bun-types": "^1.3.5",
     "jsdom": "^26.1.0",
     "react-router-dom": "^7.13.0",
     "storybook": "^8",
-    "tailwindcss-animate": "^1.0.7",
+    "tw-animate-css": "^1.4.0",
     "typescript": "^5.8.3",
     "vite": "^6.3.3",
     "vite-tsconfig-paths": "^5.1.4"
diff --git a/bun.lock b/bun.lock
