feat: integrated correction into evaluation

Author: Ren-creater

evaluation_function/correction/README.md

@@ -1,70 +1,44 @@
 # FSA Correction Module
 
-Compares student FSAs against expected FSAs, leveraging the validation module for detailed feedback.
+Compares student FSAs against expected FSAs, returns `Result` with `FSAFeedback`.
 
 ## Exports
 
 ```python
 from evaluation_function.correction import (
-    analyze_fsa_correction,  # Main pipeline
+    analyze_fsa_correction,  # Main pipeline -> Result
     check_minimality,        # Check if FSA is minimal
-    CorrectionResult,        # Result model
 )
 ```
 
 ## Pipeline
 
 ```
-┌─────────────────────────────────────────────────────────────────┐
-│                   analyze_fsa_correction()                       │
-│                 (student_fsa, expected_fsa)                      │
-├─────────────────────────────────────────────────────────────────┤
-│  Step 1: Structural Validation                                   │
-│  └── is_valid_fsa() → List[ValidationError]                     │
-├─────────────────────────────────────────────────────────────────┤
-│  Step 2: Minimality Check (optional)                             │
-│  └── check_minimality() → bool                                   │
-├─────────────────────────────────────────────────────────────────┤
-│  Step 3: Structural Analysis                                     │
-│  └── get_structured_info_of_fsa() → StructuralInfo              │
-├─────────────────────────────────────────────────────────────────┤
-│  Step 4: Language Equivalence                                    │
-│  └── fsas_accept_same_language() → are_isomorphic()             │
-│      Provides detailed feedback with ElementHighlight            │
-├─────────────────────────────────────────────────────────────────┤
-│  OUTPUT: CorrectionResult                                        │
-│  ├── is_equivalent: bool                                         │
-│  ├── is_isomorphic: bool                                         │
-│  ├── is_minimal: Optional[bool]                                  │
-│  ├── validation_errors: List[ValidationError]                   │
-│  ├── equivalence_errors: List[ValidationError]                  │
-│  └── structural_info: StructuralInfo                            │
-│                                                                  │
-│  Methods:                                                        │
-│  ├── .model_dump() → dict                                       │
-│  ├── .to_fsa_feedback() → FSAFeedback                           │
-│  └── .get_language_comparison() → LanguageComparison            │
-└─────────────────────────────────────────────────────────────────┘
+analyze_fsa_correction(student_fsa, expected_fsa, require_minimal=False) -> Result
+├── 1. Validate student FSA (is_valid_fsa)
+├── 2. Check minimality (if required)
+├── 3. Structural analysis (get_structured_info_of_fsa)
+└── 4. Language equivalence (fsas_accept_same_language -> are_isomorphic)
+         └── All "why" feedback comes from here
 ```
 
-## Usage
+## Result
 
 ```python
-from evaluation_function.correction import analyze_fsa_correction, check_minimality
-
-# Compare two FSAs
-result = analyze_fsa_correction(student_fsa, expected_fsa, check_minimality=True)
-
-# Check result
-result.is_equivalent      # bool
-result.equivalence_errors # List[ValidationError] with ElementHighlight
+Result(
+    is_correct: bool,         # True if FSAs accept same language
+    feedback: str,            # Human-readable summary
+    fsa_feedback: FSAFeedback # Structured feedback for UI
+)
+```
 
-# For UI
-result.to_fsa_feedback()  # FSAFeedback schema
+## Usage
 
-# As dict
-result.model_dump()       # dict
+```python
+from evaluation_function.correction import analyze_fsa_correction
 
-# Check minimality only
-check_minimality(fsa)     # bool
+result = analyze_fsa_correction(student_fsa, expected_fsa)
+result.is_correct           # bool
+result.feedback             # "Correct!" or "Languages differ: ..."
+result.fsa_feedback.errors  # List[ValidationError] with ElementHighlight
 ```

evaluation_function/correction/__init__.py

@@ -3,19 +3,16 @@
 Compares student FSAs against expected FSAs.
 
 Exports:
-- analyze_fsa_correction: Main pipeline (FSA vs FSA -> CorrectionResult)
+- analyze_fsa_correction: Main pipeline (FSA vs FSA -> Result)
 - check_minimality: Check if FSA is minimal
-- CorrectionResult: Result model with .to_fsa_feedback(), .model_dump()
 """
 
 from .correction import (
     analyze_fsa_correction,
     check_minimality,
-    CorrectionResult,
 )
 
 __all__ = [
     "analyze_fsa_correction",
     "check_minimality",
-    "CorrectionResult",
 ]